Commit graph

2730 commits

Author SHA1 Message Date
Jeremy McSpadden
218e53addd Merge pull request #3680 from Tibsfox/fix/restore-tools-after-discuss
fix(gsd): restore full tool set after discuss flow scoping
2026-04-07 07:06:38 -05:00
Jeremy McSpadden
6308a9d6e9 Merge pull request #3681 from Tibsfox/fix/discuss-slice-structured-questions
fix(gsd): add structuredQuestionsAvailable conditional to slice discuss
2026-04-07 07:06:25 -05:00
Jeremy McSpadden
764d8ff466 Merge pull request #3682 from Tibsfox/fix/sync-worktree-skip-current-milestone
fix(gsd): skip current milestone in syncWorktreeStateBack to prevent merge conflicts
2026-04-07 07:06:14 -05:00
Jeremy McSpadden
44872ca501 Merge pull request #3683 from Tibsfox/fix/project-root-cwd-crash
fix(gsd): handle deleted cwd crash and validate main_branch pref
2026-04-07 07:05:57 -05:00
Jeremy McSpadden
864c8e7c2a Merge pull request #3684 from Tibsfox/fix/mark-note-captures-executed
fix(gsd): mark note captures as executed in triage resolution
2026-04-07 07:04:52 -05:00
Jeremy McSpadden
0163b5b5bf Merge pull request #3685 from Tibsfox/fix/mcp-server-subpath-imports
fix(mcp): use createRequire to resolve SDK wildcard subpath imports
2026-04-07 07:04:38 -05:00
Jeremy McSpadden
3e0cdcd7ea Merge pull request #3686 from Tibsfox/fix/run-uat-replay-cap
fix(gsd): cap run-uat dispatch attempts to prevent infinite replay loop
2026-04-07 07:03:54 -05:00
Jeremy McSpadden
21898dec7e Merge pull request #3689 from Tibsfox/fix/interview-notes-enter-loop
fix(tui): prevent Enter key infinite loop in interview notes mode
2026-04-07 07:03:32 -05:00
Jeremy McSpadden
559abeb95c Merge pull request #3695 from Tibsfox/fix/block-phantom-milestone-creation
fix(gsd): default insertMilestone status to queued instead of active
2026-04-07 07:03:09 -05:00
Jeremy McSpadden
91ed0055ef Merge pull request #3688 from Tibsfox/fix/provider-manager-enter-key
fix(provider): handle Enter key to initiate auth setup in provider manager
2026-04-07 07:02:48 -05:00
Jeremy McSpadden
57e9063580 Merge pull request #3691 from Tibsfox/fix/status-open-db-cold-session
fix(gsd): open DB before status derivation + respect isolation:none in quick
2026-04-07 07:02:31 -05:00
Jeremy McSpadden
301e7833ea Merge pull request #3690 from Tibsfox/fix/gitignore-bg-shell
fix(gsd): add .bg-shell/ to baseline gitignore patterns
2026-04-07 07:02:15 -05:00
Jeremy McSpadden
1146352202 Merge pull request #3692 from Tibsfox/fix/complete-task-normalize-list-inputs
fix(gsd): normalize list inputs in complete-task + fix roadmap dep parsing
2026-04-07 07:02:02 -05:00
Jeremy McSpadden
a23fb1e873 Merge pull request #3693 from Tibsfox/fix/frontmatter-parse-noise
fix(gsd): suppress repeated frontmatter YAML parse warnings
2026-04-07 06:57:43 -05:00
Jeremy McSpadden
0339317d10 Merge pull request #3696 from Tibsfox/fix/prompt-step-ordering-and-tools
fix(gsd): prompt ordering, correct tools, crash guard, compaction fix
2026-04-07 06:57:28 -05:00
Jeremy McSpadden
a7cb1389b8 Merge pull request #3697 from Tibsfox/fix/set-slice-sequence-on-insert
fix(gsd): set slice sequence at all three insertion sites
2026-04-07 06:56:53 -05:00
Jeremy McSpadden
627510695c Merge pull request #3698 from Tibsfox/fix/allow-skipped-validation-completion
fix(gsd): allow milestone completion when validation skipped by preference
2026-04-07 06:56:41 -05:00
Jeremy McSpadden
bf1d7cfd4d Merge pull request #3699 from Tibsfox/fix/import-done-milestones-as-complete
fix(gsd): import all-done milestones as complete during DB migration
2026-04-07 06:56:27 -05:00
Jeremy McSpadden
0ccb3b627b Merge pull request #3709 from Tibsfox/fix/discuss-incremental-persistence
fix(gsd): add incremental persistence to discuss prompts
2026-04-07 06:56:06 -05:00
Jeremy McSpadden
313658586a Merge pull request #3676 from Tibsfox/fix/stop-projection-overwriting-plan
fix(gsd): stop renderAllProjections from overwriting authoritative PLAN.md
2026-04-07 06:55:45 -05:00
Jeremy McSpadden
128ddba5df Merge pull request #3677 from Tibsfox/fix/pre-execution-checks-false-positives
fix(gsd): fix pre-execution-checks false positives from backticks and task.files
2026-04-07 06:03:44 -05:00
Tibsfox
3f5956d7c3 fix(gsd): add incremental persistence to discuss prompts
Discuss sessions with no persistence lost all confirmed work on crash.
Now both milestone and slice discuss prompts instruct agents to
silently save CONTEXT-DRAFT every 2 question rounds via
gsd_summary_save. The final context file overwrites the draft.

Closes #2152

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 03:27:46 -07:00
Jeremy McSpadden
69007b594f Merge pull request #3656 from Tibsfox/fix/auto-dispatch-planning-stuck 2026-04-07 04:22:49 -05:00
Tibsfox
6fa3a6ac94 test: move missing file refs from task.files to task.inputs per #3626 fix 2026-04-06 23:01:34 -07:00
Tibsfox
fa344e79a0 fix(test): escape regex metacharacters in skip-by-preference pattern test
The test regex used unescaped (?:...) groups which were interpreted as
regex syntax instead of matching the literal source text. Escape parens
to match the actual regex pattern in the source code.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:55:55 -07:00
Tibsfox
ae6f9bab8a fix(test): search for numbered step definitions in prompt ordering test
The test used indexOf which found "gsd_complete_milestone" in the
"Do NOT call" warning (line 34) before the actual step 10 definition
(line 43). Use regex to match numbered step patterns instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:54:21 -07:00
Tibsfox
94536a01fd fix(test): update notes loop test for notesVisible guard behavior
The fix adds a notesVisible guard that prevents re-opening notes when
they are already visible, even if empty. Update the test to expect
empty notes and direct advancement instead of re-opening.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:52:51 -07:00
Tibsfox
267c890823 fix(test): update action count for note captures now included in results
The fix marks note captures as executed and adds them to the actions
list. Update the mixed classifications test to expect 3 actions instead
of 2, since notes are no longer excluded.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:51:15 -07:00
Tibsfox
e8903fa716 fix(test): remove extraneous test file from wrong branch
The find-missing-summaries-closed.test.ts was accidentally committed
to this branch but belongs to fix/find-missing-summaries-skip-closed.
Remove it to fix CI failures.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:49:46 -07:00
Tibsfox
60bbf8f0b3 fix(test): update worktree sync tests to use separate milestone IDs
The fix skips the current milestone in syncWorktreeStateBack to prevent
merge conflicts. Update tests to use a different milestone ID for the
milestoneId parameter vs the milestone being synced, matching the new
skip-current-milestone behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:49:02 -07:00
Tibsfox
f8e98de19f fix(test): update stuck-planning test to expect executing after reconciliation
The fix reconciles plan-file tasks into the DB when the planner skips
persistence, so the phase correctly advances to executing instead of
remaining stuck in planning. Update the known-issue test to expect the
fixed behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:42:17 -07:00
Tibsfox
9479fe07bd fix(test): update file path consistency tests for inputs-only checking
The fix changed checkFilePathConsistency to only check task.inputs, not
task.files, since files includes paths the task will create. Update tests
to use inputs instead of files for consistency checks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:40:29 -07:00
Tibsfox
2a2ad20592 test: add regression test for sync-worktree skip current milestone
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:31:40 -07:00
Tibsfox
f028c0938d test: add regression test for discuss-slice structured questions conditional
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:30:02 -07:00
Tibsfox
3c83aa5539 test: add regression test for restoring tools after discuss flow scoping
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:29:28 -07:00
Tibsfox
8dd8744b91 test: add regression test for pre-execution backtick strip and inputs-only check
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:53 -07:00
Tibsfox
fe84893351 test: add regression test for importing done milestones as complete
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:51 -07:00
Tibsfox
ef68e37e79 test: add regression test for skipped validation completion
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:33 -07:00
Tibsfox
fceb983beb test: add regression test for slice sequence on insert
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:19 -07:00
Tibsfox
08ebf3387d test: add regression test for projection plan overwrite prevention
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:06 -07:00
Tibsfox
474c3c287d test: add regression test for prompt step ordering and runtime fixes
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:04 -07:00
Tibsfox
9ea3beab22 test: add regression test for phantom milestone default queued status
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:44 -07:00
Tibsfox
fc210a4edf test: add regression test for .bg-shell/ in gitignore BASELINE_PATTERNS
Structural verification that .bg-shell/ is included in the
BASELINE_PATTERNS array in gitignore.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:38 -07:00
Tibsfox
5222801ebd test: add regression test for frontmatter parse noise suppression
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:32 -07:00
Tibsfox
faf8c95c8a test: add regression test for provider manager Enter key handler
Structural verification that selectConfirm handler and onSetupAuth
callback exist in provider-manager.ts (#3579).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:26 -07:00
Tibsfox
b461cf75ed test: add regression test for run-uat replay cap
Structural verification that MAX_UAT_ATTEMPTS constant exists and
incrementUatCount is called before dispatch (#3624).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:12 -07:00
Tibsfox
1d428c5ffd test: add regression test for complete-task normalizeListParam
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:10 -07:00
Tibsfox
9475757d9a test: add regression test for dispatcher stuck-planning reconciliation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:10 -07:00
Tibsfox
26d1222096 test: add regression test for MCP createRequire subpath resolution
Structural verification that createRequire import and _require.resolve
usage exist in mcp-server.ts (#3603).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:24:58 -07:00
Tibsfox
7372948585 test: add regression test for status DB open in cold sessions
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:24:55 -07:00