singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(test): search for numbered step definitions in prompt ordering test

Browse source 
The test used indexOf which found "gsd_complete_milestone" in the
"Do NOT call" warning (line 34) before the actual step 10 definition
(line 43). Use regex to match numbered step patterns instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tibsfox 2026-04-06 22:54:21 -07:00
parent 474c3c287d
commit ae6f9bab8a
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/resources/extensions/gsd/tests/prompt-step-ordering.test.ts
View file

@ -35,14 +35,17 @@ const registerHooksSrc = readFileSync(
);
describe('prompt step ordering (#3696)', () => {
test('gsd_requirement_update appears before gsd_complete_milestone', () => {
const reqUpdateIdx = completeMilestoneMd.indexOf('gsd_requirement_update');
const completeMilestoneIdx = completeMilestoneMd.indexOf('gsd_complete_milestone');
assert.ok(reqUpdateIdx > -1, 'gsd_requirement_update should be in complete-milestone.md');
assert.ok(completeMilestoneIdx > -1, 'gsd_complete_milestone should be in complete-milestone.md');
test('gsd_requirement_update step appears before gsd_complete_milestone step', () => {
// Search for the numbered step definitions, not early "Do NOT call" warnings
const reqUpdateMatch = completeMilestoneMd.match(/^\d+\.\s.*gsd_requirement_update/m);
const completeMilestoneMatch = completeMilestoneMd.match(/^\d+\.\s.*gsd_complete_milestone/m);
assert.ok(reqUpdateMatch, 'gsd_requirement_update should appear in a numbered step');
assert.ok(completeMilestoneMatch, 'gsd_complete_milestone should appear in a numbered step');
const reqUpdateIdx = completeMilestoneMd.indexOf(reqUpdateMatch![0]);
const completeMilestoneIdx = completeMilestoneMd.indexOf(completeMilestoneMatch![0]);
assert.ok(
reqUpdateIdx < completeMilestoneIdx,
'gsd_requirement_update (step 9) must come before gsd_complete_milestone (step 10)',
'gsd_requirement_update step must come before gsd_complete_milestone step',
);
});