Commit graph

4165 commits

Author SHA1 Message Date
Vadim Stepanov
80b993305d
Merge pull request #4450 from grafana/helm-release/1.6.0
Merge: Release oncall Helm chart 1.6.0
2024-06-03 17:05:40 +01:00
GitHub Actions
19ecfd55b5 Release oncall Helm chart 1.6.0 2024-06-03 15:37:42 +00:00
Vadim Stepanov
74633d6685
Merge pull request #4449 from grafana/dev
dev to main
2024-06-03 16:34:24 +01:00
Dominik Broj
66f807a671
Fix escaping quotes in Insights queries (#4442)
# What this PR does

Use backticks to correctly escape quotes in queries

## Which issue(s) this PR closes

Closes https://github.com/grafana/oncall/issues/4439

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-06-03 14:14:16 +00:00
Levente Balogh
3566de38b9
Plugin.json: update with extensions info (#4407)
### What changed?

- Manually added ui-extensions metadata to the plugin.json (to be able
to lazy-load plugins in Grafana, based on [this
PR](https://github.com/grafana/grafana/pull/88288)
2024-06-03 13:21:01 +00:00
Vadim Stepanov
fafc336795
Allow custom wait delay (#4446)
# What this PR does

Same as https://github.com/grafana/oncall/pull/4422 but returns wait
delays as strings so it's backward-compatible with the mobile app API
calls.

## Which issue(s) this PR closes

Related to https://github.com/grafana/oncall/issues/2464

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-06-03 13:06:47 +00:00
Rares Mardare
cca2d0d960
Allow user unset the escalation chain on the integration (#4436)
# What this PR does

- Allow user unset the escalation chain on the integration

## Which issue(s) this PR closes

Closes https://github.com/grafana/oncall/issues/4434
2024-06-03 12:46:17 +00:00
Rares Mardare
270ceeaeaf
Theming backwards compatibility (#4438)
# What this PR does

Closes https://github.com/grafana/oncall/issues/4437
2024-06-03 12:36:02 +00:00
Joey Orlando
91fac2fa6e
Merge pull request #4445 from grafana/helm-release/1.5.5
Merge: Release oncall Helm chart 1.5.5
2024-06-03 07:52:48 -04:00
GitHub Actions
9f2f049f85 Release oncall Helm chart 1.5.5 2024-06-03 11:19:01 +00:00
Vadim Stepanov
255d1e68f1
Merge pull request #4444 from grafana/dev
v1.5.5
2024-06-03 12:17:46 +01:00
GitHub Actions
63ed19213b Release oncall Helm chart 1.5.5 2024-06-03 10:49:50 +00:00
Vadim Stepanov
e4170389dc
Revert "Allow custom wait delays" (#4441)
Reverts grafana/oncall#4422
2024-06-03 10:47:42 +00:00
Innokentii Konstantinov
3acdddc3bc
Merge pull request #4440 from grafana/dev
dev to main
2024-06-03 18:46:08 +08:00
Innokentii Konstantinov
17f448c506
Prepare OnCall for Unified Slack App (#4232)
This PR does a bunch of changes to prepare OnCall for Unified Slack App:
1. Install Slack via Chatops-Proxy. This change contains two parts:
getting a Slack install link from chatops-proxy
([code](https://github.com/grafana/oncall/pull/4232/files#diff-437a77d49fc04b92d315651b3df5991000b1ab74cf60aabb21aa77cb2823bf52R46))
and receiving a "slack installed" event from chatops-proxy
([code](https://github.com/grafana/oncall/pull/4232/files#diff-976d106f0962be5c1de5e35582193f68435ed0c17f2defd6bd2857bf6e27f65d)).
Also it means that OnCall doesn't need to register slack_links anymore
when slack is connected/disconnected. These changes are behind
UNIFIED_SLACK_APP_ENABLED flag and should be no-op if flag is not
enabled.
2. Get rid of Multiregionatily restrictions - instrument all slack
interactions with a ProxyMeta - json data telling chatops-proxy where to
route the interaction. Note, that it doesn't apply for "Add to
resolution notes" message action - it will be handled differently in
following PR.
3. Move all chatops-proxy related stuff from common/oncall-gateway to
apps/chatops-proxy

Minor changes:
1. Remove usage of **CHATOPS_V3** flag. Chatops v3 is already released
(It's a refactoring from previous quarter)

---------

Co-authored-by: Vadim Stepanov <vadimkerr@gmail.com>
Co-authored-by: Rares Mardare <rares.mardare@grafana.com>
2024-06-03 09:07:10 +00:00
Matias Bordese
2aa8639e2a
Update escalation auditor logs to expose succeeding count (#4431)
Related to https://github.com/grafana/oncall-private/issues/2619
(we need the succeeding number to make the SLO query happy with
cluster/namespace filtering)
2024-05-31 18:29:31 +00:00
Vadim Stepanov
d8e1a1dfae
Allow custom wait delays (#4422)
# What this PR does

Allows custom wait durations for:
* `Wait` escalation policy
* `>X alerts per Y minutes` escalation policy
* `Wait` user notification policy

## Which issue(s) this PR closes

Related to https://github.com/grafana/oncall/issues/2464

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.

---------

Co-authored-by: Rares Mardare <rares.mardare@grafana.com>
2024-05-31 13:18:59 +00:00
Maxim Mordasov
f7975f1280
Schedules minor fixes (#4429)
# What this PR does

Schedules minor fixes

## Which issue(s) this PR closes


## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-05-31 12:36:23 +00:00
Joey Orlando
41526b06d6
Merge pull request #4427 from grafana/helm-release/1.5.4
Merge: Release oncall Helm chart 1.5.4
2024-05-30 16:48:09 -04:00
GitHub Actions
ea27a41d80 Release oncall Helm chart 1.5.4 2024-05-30 19:57:55 +00:00
Michael Derynck
d7bf353847
Merge pull request #4426 from grafana/dev
v1.5.4
2024-05-30 13:57:05 -06:00
Matias Bordese
08d1e00430
Update escalation auditor to log total and failed escalations info (#4425)
Related to https://github.com/grafana/oncall-private/issues/2619
2024-05-30 18:53:53 +00:00
Matias Bordese
5291feeb51
Fix update slack group to not raise if group is not found (#4423)
Fixes https://github.com/grafana/oncall-private/issues/2664
2024-05-30 11:27:25 +00:00
Maxim Mordasov
d7419780e7
Schedule two-weeks and monthly view (#4318)
# What this PR does

Schedule two-weeks and monthly view, UI polishing

## Which issue(s) this PR closes

https://github.com/grafana/oncall-private/issues/2667


## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.

---------

Co-authored-by: Dominik Broj <dominik.broj@grafana.com>
2024-05-30 11:10:13 +00:00
Joey Orlando
404121e925
Merge pull request #4418 from grafana/helm-release/1.5.3
Merge: Release oncall Helm chart 1.5.3
2024-05-28 16:27:33 -04:00
GitHub Actions
349971fe5c Release oncall Helm chart 1.5.3 2024-05-28 19:51:15 +00:00
Matias Bordese
e4fd392322
Merge pull request #4417 from grafana/dev
v1.5.3
2024-05-28 16:50:31 -03:00
Matias Bordese
8160482b5e
Fix team uniqueness db migration (#4416) 2024-05-28 19:41:42 +00:00
Matias Bordese
4f05568007
Merge pull request #4414 from grafana/dev
v1.5.2
2024-05-28 15:54:28 -03:00
Vadim Stepanov
ef47e54f24
fix bad redirects (#4413) 2024-05-28 18:24:57 +00:00
Matias Bordese
6acbb71fad
Do not retry on SlackAPICantUpdateMessageError errors (#4405)
Related to https://github.com/grafana/oncall/pull/4329
2024-05-28 17:46:15 +00:00
Rares Mardare
80ecde6fbb
Fix reported errors by Faro (#4408)
# What this PR does

Fixes the following reported errors by Faro
- Cannot read properties of undefined (reading 'error_code') - found in
Page Error Handling wrapper
- Cannot read properties of undefined (reading 'slack_team_identity') -
Found in DefaultPageLayout helpers
- Cannot read properties of undefined (reading 'reduce') - undefined
passed labels in labels helpers
- Cannot read properties of undefined (reading 'controlled_fields') -
webhooks
- Cannot read properties of undefined (reading 'data')

The following needs to be further investigated to see if the response
misses whole body
- Cannot read properties of undefined (reading 'config') - happening in
Faro. I assume it's when an exception is thrown and the ex doesn't have
the `config` field

## Which issue(s) this PR closes

Closes #4403
2024-05-28 14:11:34 +00:00
Matias Bordese
7e3008ba0f
Setup team uniqueness at DB level (#4396)
Avoid potential duplicated teams. Also it should help ensuring
`sync_organization` idempotency.
2024-05-27 17:41:20 +00:00
Joey Orlando
2881bc8fec
update install-frontend-dependencies composable github action (again) (#4404) 2024-05-27 09:47:34 -04:00
Rares Mardare
f7beced64e
More emotionjs migration changes (#4362)
# What this PR does

- Get rid of some of the hardcoded css variables defined in `vars.css`,
specifically tags-related, but not only
- Migrated a few more components to emotion
2024-05-27 13:28:56 +00:00
Joey Orlando
d52e821c33
update install-frontend-dependencies github action (#4402) 2024-05-27 09:18:33 -04:00
Rares Mardare
997cb64a57
Fixed UserGroup selectors not showing the set value (#4394)
# What this PR does

Fix for https://github.com/grafana/oncall/issues/4371

- Fixed UserGroups' selectors not showing up the stored value - this
behavior was found in Schedule Form and Escalation Chains

## Which issue(s) this PR closes

Closes https://github.com/grafana/oncall/issues/4371
2024-05-27 07:51:01 +00:00
Michael Derynck
357857faca
Add endpoint to get a single user group (#4395)
# What this PR does
Add endpoint to return slack user group from public primary key

## Which issue(s) this PR closes

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-05-24 20:26:28 +00:00
Joey Orlando
a92203e71c
remove unnecessary CI step bash command (#4397)
# What this PR does

This command is no longer necessary. Currently it doesn't seem to be
working (see screenshot 👇). Presumably `netcat-traditional` is installed
on the `ubuntu-latest-8-cores` runner.

![Screenshot 2024-05-24 at 14 42
23](https://github.com/grafana/oncall/assets/9406895/dcb80711-6168-4885-a7b8-a05e323c03bf)
2024-05-24 15:13:38 -04:00
Joey Orlando
96a4b36f1e
update drone.yml signature 2024-05-24 14:24:02 -04:00
Joey Orlando
93ab3407ff
rename settings/ci-test.py to settings/ci_test.py (#4391)
# What this PR does

Related to Drone -> GitHub Actions migration
2024-05-24 13:55:08 +00:00
Rares Mardare
dfea60e736
Allow custom silence period for alert groups + display how much left is for a silenced AG (#4375)
# What this PR does

https://github.com/grafana/oncall/issues/2333

- Allow custom input for silence period (either by duration or by
setting a future date in the calendar, both inputs are syncedd/editable)
- Show how much time is left for a silenced alert group

## Which issue(s) this PR closes

Closes https://github.com/grafana/oncall/issues/2333
2024-05-24 08:32:19 +00:00
Dominik Broj
f061d26a7d
hide datasource dropdown on cloud (#4386)
# What this PR does
hide datasource dropdown on cloud

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-05-23 18:22:56 +00:00
Joey Orlando
9867cca5e8
Drone -> GitHub Actions migration (#4389)
# What this PR does

Related to https://github.com/grafana/oncall-private/issues/2692

This PR simply deduplicates a lot of steps in our
`linting-and-tests.yml` GitHub Actions workflow. This will make it much
easier in `grafana/oncall-private` to be able to reuse some of these
composable building blocks.
2024-05-23 14:26:07 -04:00
Michael Derynck
a1207eb0a4
Fix missing filtering term type 1 when editing jinja route template (#4357)
# What this PR does
When editing a jinja route template the filtering_term_type was not
being provided so it was being validated as regex instead. This adds the
missing flag so that the route will use the correct validation. The
reason this was not being hit in the past is most jinja templates were
still passing regex validation.

## Which issue(s) this PR closes

Closes #4259 

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-05-23 16:35:13 +00:00
Matias Bordese
d316c9121e
Fix order filtering when executing notify all/group steps from snapshot (#4381)
Fixes https://github.com/grafana/oncall-private/issues/2708
2024-05-23 12:36:28 +00:00
Vadim Stepanov
f9f5ae9042
fix silence_options schema (#4384) 2024-05-23 11:06:00 +00:00
Dominik Broj
764606089d
show datasource dropdown on cloud (#4382)
# What this PR does

- show data source filter also on cloud
- use custom All option value to prevent invalid queries when there are
too many values

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-05-23 05:53:11 +00:00
Dominik Broj
375f6baf50
Add service_name to Insights filters (#4133)
# What this PR does

## Which issue(s) this PR closes

Closes https://github.com/grafana/oncall-private/issues/2610 

Milestone: https://github.com/grafana/oncall-private/issues/2552

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-05-23 03:45:25 +00:00
Michael Derynck
f3b2d8e927
Add details to escalation step description (#4334)
Attempt to clarify how `Notify whole slack channel` and `Notify Slack
User Group` work
2024-05-22 18:31:18 +00:00