Commit graph

1586 commits

Author SHA1 Message Date
TÂCHES
cc2c887948 Refactor GSD command and bootstrap modules (#1634)
* Refactor GSD command/bootstrap modules

* fix: resolve TypeScript build errors in refactored db-tools and catalog

- db-tools.ts: add missing execute callback params (signal, onUpdate, ctx),
  remove isError from return objects (not in AgentToolResult type), cast
  details as any to avoid union type mismatch across error/success paths
- catalog.ts: use Object.entries() on TemplateRegistry.templates Record
  instead of treating it as an array, use Record key as template id

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: update source-contract tests to reference refactored file locations

The god-file refactor moved code from index.ts and commands.ts into
bootstrap/agent-end-recovery.ts, bootstrap/register-hooks.ts, and
commands/handlers/core.ts. Update three test files to read from the
correct paths and adjust pattern assertions to match the new code
structure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 15:19:16 -06:00
TÂCHES
39f9faffa8 fix: default UAT type to artifact-driven to prevent unnecessary auto-mode pauses (#1651)
When a UAT file has no `## UAT Type` section, `extractUatType()` returns
`undefined`. The fallback was `"human-experience"`, causing `pauseAfterDispatch:
true` in the auto-dispatch rule. Since doctor-generated UAT placeholders never
include a UAT Type section and LLM-executed UATs are always artifact-driven,
the correct default is `"artifact-driven"`.

Closes #1649

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 15:11:55 -06:00
TÂCHES
b124b79a12 fix: cancel trailing async jobs on session switch to prevent wasted LLM turns (#1643)
When a unit spawns background jobs via async_bash, job completion callbacks
fire follow-up messages after agent_end has resolved. The auto-loop has
moved on but the previous session's LLM processes these follow-ups, adding
12-45s of wasted time and ~14 unnecessary turns per unit.

Two complementary fixes:
1. Cancel all running background jobs on session_before_switch so
   completion callbacks never fire for the old session.
2. Clear the follow-up queue after runUnit() completes as defense-in-depth,
   discarding any already-queued notifications before the next session starts.

Closes #1642

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 14:29:38 -06:00
github-actions[bot]
2d08391649 release: v2.39.0 2026-03-20 19:41:22 +00:00
Jeremy McSpadden
c0342c0883 fix: recover + prevent #1364 .gsd/ data-loss (v2.30.0–v2.38.0) (#1635)
* fix: add recovery script for #1364 .gsd/ data-loss regression

Adds scripts/recover-gsd-1364.sh to help users whose .gsd/ files were
deleted by the ensureGitignore bug in v2.33.x–v2.35.x.

The script handles both damage scenarios:
- Scenario A: .gsd files deleted in working tree but not yet committed
- Scenario B: git rm --cached .gsd/ was committed (files gone from HEAD)

Steps performed:
1. Detects whether the repo is affected (symlink check, .gitignore scan,
   git history scan)
2. Finds the last clean commit before ".gsd" was added to .gitignore
3. Restores all deleted .gsd/ files via git checkout <clean-commit> -- .gsd/
4. Removes the bare ".gsd" line from .gitignore
5. Stages both changes and prints the ready-to-commit command

Supports --dry-run to preview without making changes.
Safe to run on unaffected repos — exits early with no modifications.

Closes #1364

* fix: add Windows PowerShell recovery script for #1364

Adds scripts/recover-gsd-1364.ps1, a PowerShell equivalent of the bash
recovery script for users on Windows.

Windows-specific differences handled:
- Junction detection: GSD's migrateToExternalState() uses symlinkSync()
  with type "junction" on Windows instead of a POSIX symlink. The script
  checks Get-Item.LinkType for both "SymbolicLink" and "Junction" so
  migrated repos exit cleanly on step 1.
- .gitignore rewrite uses [System.IO.File]::WriteAllLines() with UTF-8
  no-BOM encoding to match git's expectations on Windows, rather than
  shell redirection which can introduce BOM or CRLF issues.
- All git invocations use execFileSync-style array args via Invoke-Git
  helper — no shell string eval, no quoting edge cases.
- Colour output uses Write-Host -ForegroundColor instead of ANSI escapes.
- -DryRun is a proper PowerShell switch parameter.

Also updates recover-gsd-1364.sh header to:
- Clarify it is Linux/macOS only
- Point Windows users to the .ps1
- Correct the affected version range to v2.30.0-v2.35.x (was 2.33.x)
- Reference the three residual vectors on v2.36.0-v2.38.0 (PR #1635)

Usage on Windows:
  powershell -ExecutionPolicy Bypass -File scripts\recover-gsd-1364.ps1
  powershell -ExecutionPolicy Bypass -File scripts\recover-gsd-1364.ps1 -DryRun

* fix(gsd): close residual #1364 data-loss vectors on v2.36.0+

Two targeted fixes that close the three remaining paths where .gsd/
tracked files can still be silently deleted after the v2.36.0 fix.

--- Path 1: hasGitTrackedGsdFiles fails open on git error (gitignore.ts)

nativeLsFiles() swallows git failures via allowFailure=true and returns
[], making hasGitTrackedGsdFiles() indistinguishable between "nothing
tracked" and "git failed". On any transient git failure (locked index,
binary not on PATH, corrupted .git/index), the function returned false
and .gsd was added to .gitignore, deleting all tracked state.

Fix: after nativeLsFiles returns [], verify git is reachable with a
cheap rev-parse call. If git is unavailable, return true (fail safe —
assume tracked). The outer catch also returns true instead of false.

--- Path 2: migration never cleans git index (migrate-external.ts)

migrateToExternalState() correctly creates the .gsd symlink/junction but
never ran `git rm -r --cached .gsd/`. All previously tracked .gsd/* files
remained in the git index pointing through the new symlink, which git
cannot follow — causing PROJECT.md, milestones/, REQUIREMENTS.md etc. to
appear as deleted in git status immediately after every migration.

Fix: after the symlink is verified, run:
  git rm -r --cached --ignore-unmatch .gsd
--ignore-unmatch makes this a no-op on fresh/untracked projects.

--- Path 3: race between migration and ensureGitignore

Resolved by Path 2. If migration always cleans the index, the race
window (another process converting .gsd/ to a symlink between the
migrateToExternalState() and ensureGitignore() calls) is harmless —
the index is already clean and there is nothing to lose.

--- Tests added (gitignore-tracked-gsd.test.ts)

- hasGitTrackedGsdFiles returns true (fail-safe) when git is unavailable
  (simulated via .git/index.lock to force git ls-files failure)
- migrateToExternalState cleans git index so tracked files don't show
  as deleted after successful migration

Fixes residual vectors from #1364 (original fix: #1367, v2.36.0)

* fix(recovery): add Scenario C support to recover-gsd-1364 scripts

Scenario C: .gsd/ is already a symlink/junction (migration succeeded on
the filesystem) but `git rm -r --cached .gsd/` was never run, leaving
tracked .gsd/* files appearing as deleted in git status.

Both bash and PowerShell scripts previously exited early at Step 1 when
they detected a symlink. Now they continue with a dedicated Scenario C
path through all steps:

- Step 1: sets GSD_IS_SYMLINK flag, continues instead of exiting
- Step 2: inverted .gitignore check — warns if .gsd is MISSING (should
  be present for external-state layout) rather than if it's present
- Step 3: skips commit-history scan (index issue only, no file restore
  needed); exits clean if no stale entries found
- Step 4: skips damage-commit search (nothing to restore from history)
- Step 5: runs `git rm -r --cached --ignore-unmatch .gsd` to clean the
  stale index entries instead of restoring files from a prior commit
- Step 6: appends .gsd to .gitignore instead of removing it
- Step 7: stages only .gitignore (not .gsd/) to avoid the "gitignored
  path" error; the index cleanup from Step 5 is already staged
- Summary: uses a distinct commit message for Scenario C

Smoke-tested against a synthetic repo that replicates the exact Scenario
C failure mode (symlink in place, git rm --cached never run).
2026-03-20 13:26:09 -06:00
Tom Boucher
ea4d7d639e docs: update documentation for v2.38.0 release (#1636)
Update README "What's New" section to v2.38 with reactive task
execution (ADR-004), Anthropic Vertex AI provider, CI optimization,
and batch verification. Collapse v2.34–v2.37 into previous highlights.

Add reactive task execution section to auto-mode guide with
configuration and implementation details. Add AI triage workflow and
CI optimization note to CI/CD pipeline guide. Add ADR-003 to docs
index. Add 3 troubleshooting entries: session lock theft, worktree
commits on wrong branch, and extension subpath export errors.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-20 13:20:44 -06:00
Derek Pearson
90d6d71e38 feat(gsd): activate matching skills in dispatched prompts (#1630)
* fix(gsd extension): detect initialized projects in health widget

Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.

* fix(gsd extension): detect initialized projects in health widget

Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.

* feat(gsd): activate matching skills in dispatched prompts

Inject skill activations from installed skills, preferences, and task-plan handoff so GSD agents load the right skills automatically instead of relying on generic guidance. Align prompt templates and tests with the activation flow and current resource sync behavior.

* fix(gsd extension): detect initialized projects in health widget

Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.

* fix(gsd extension): restore health widget build paths

* test(resource-loader): fix sibling cleanup assertion
2026-03-20 13:20:06 -06:00
Brett Kellgren
0ec2ae020f fix: treat summary as terminal artifact even when roadmap slices are unchecked (#1632)
When a milestone has a roadmap with unchecked slice checkboxes AND a
summary file, deriveState() incorrectly treated it as incomplete. The
summary check only ran inside the `if (isMilestoneComplete(roadmap))`
branch, so it was never reached when checkboxes weren't ticked.

This caused auto-mode to pick an already-completed milestone as active,
ignoring the actual current milestone entirely.

The fix adds summary-existence checks to all three resolution paths:

1. `getActiveMilestoneId()` — now checks for summary before returning
   a milestone as incomplete
2. Phase 1 pre-scan in `deriveState()` — now adds milestones with
   unchecked roadmaps + summaries to `completeMilestoneIds`
3. Phase 2 registry builder — now checks for summary before falling
   through to the active/pending logic

This is consistent with the existing principle that the summary is the
terminal artifact (#864), which was already stated in a comment but not
enforced for the unchecked-roadmap case.

Adds two tests:
- Unchecked roadmap + summary → status is 'complete', next milestone
  is active
- Unchecked roadmap + summary satisfies depends_on for downstream
  milestones
2026-03-20 13:19:56 -06:00
Jeremy McSpadden
6f15ddcbf7 fix(gsd): close residual #1364 data-loss vectors on v2.36.0+ (#1637)
Two targeted fixes that close the three remaining paths where .gsd/
tracked files can still be silently deleted after the v2.36.0 fix.

--- Path 1: hasGitTrackedGsdFiles fails open on git error (gitignore.ts)

nativeLsFiles() swallows git failures via allowFailure=true and returns
[], making hasGitTrackedGsdFiles() indistinguishable between "nothing
tracked" and "git failed". On any transient git failure (locked index,
binary not on PATH, corrupted .git/index), the function returned false
and .gsd was added to .gitignore, deleting all tracked state.

Fix: after nativeLsFiles returns [], verify git is reachable with a
cheap rev-parse call. If git is unavailable, return true (fail safe —
assume tracked). The outer catch also returns true instead of false.

--- Path 2: migration never cleans git index (migrate-external.ts)

migrateToExternalState() correctly creates the .gsd symlink/junction but
never ran `git rm -r --cached .gsd/`. All previously tracked .gsd/* files
remained in the git index pointing through the new symlink, which git
cannot follow — causing PROJECT.md, milestones/, REQUIREMENTS.md etc. to
appear as deleted in git status immediately after every migration.

Fix: after the symlink is verified, run:
  git rm -r --cached --ignore-unmatch .gsd
--ignore-unmatch makes this a no-op on fresh/untracked projects.

--- Path 3: race between migration and ensureGitignore

Resolved by Path 2. If migration always cleans the index, the race
window (another process converting .gsd/ to a symlink between the
migrateToExternalState() and ensureGitignore() calls) is harmless —
the index is already clean and there is nothing to lose.

--- Tests added (gitignore-tracked-gsd.test.ts)

- hasGitTrackedGsdFiles returns true (fail-safe) when git is unavailable
  (simulated via .git/index.lock to force git ls-files failure)
- migrateToExternalState cleans git index so tracked files don't show
  as deleted after successful migration

Fixes residual vectors from #1364 (original fix: #1367, v2.36.0)
2026-03-20 13:15:11 -06:00
TÂCHES
8e2d403179 feat(gsd): add .gsd/RUNTIME.md template for declared runtime context (#1626)
Template for projects to declare stack, build, test, and environment
details. Inlined into execute-task prompts when present.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 12:51:51 -06:00
TÂCHES
1d3e3ee46b feat(gsd): create draft PR on milestone completion when git.auto_pr enabled (#1627)
Adds createDraftPR() to git-service.ts and hooks it into the milestone
transition block in auto-loop.ts. Best-effort, non-fatal on failure.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 11:48:13 -06:00
TÂCHES
70cf14f72d refactor(gsd): unify sidecar mini-loop into main dispatch path (#1617)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:59:26 -06:00
TÂCHES
7564901868 fix: auto-resolve npm subpath exports in extension loader (#1624)
Extensions importing unlisted subpaths from bundled packages (e.g.
@modelcontextprotocol/sdk/server) fail because jiti's CJS fallback
double-resolves paths. This adds auto-discovery of subpath exports from
bundled packages' package.json exports fields, generating alias entries
for all explicit and wildcard subpaths so extensions can import any
standard Node.js subpath export.

Closes #1604

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:53:10 -06:00
TÂCHES
8f39eefb4b fix: create node_modules symlink for dynamic import resolution in extensions (#1623)
Native ESM import() ignores NODE_PATH and resolves packages by walking up
the directory tree. Extension files synced to ~/.gsd/agent/extensions/ have
no ancestor node_modules, so imports of @gsd/* packages fail with "Cannot
find package" errors during report generation and other dynamic-import paths.

Create a symlink ~/.gsd/agent/node_modules -> GSD's node_modules after
resource sync so Node's standard resolution finds @gsd/* packages. Also
migrate the most critical dynamic imports in auto-loop, exit-command, and
commands to use importExtensionModule (jiti-based) as a belt-and-suspenders
fix.

Closes #1594

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:48:17 -06:00
TÂCHES
fb7b484d10 fix: filter cross-milestone errors from health tracker escalation (#1621)
Two bugs fixed:
1. recordHealthSnapshot counted ALL doctor issues including cross-milestone
   stale errors, inflating consecutiveErrorUnits past the escalation threshold
   from unfixable errors in other milestones. Now filters report.issues to
   only the current milestone before summarizing for health tracking.

2. matchesScope used unitId.startsWith(scope) without a delimiter, so scope
   "M004/S01" would false-match "M004/S010". Removed the redundant
   delimiter-less startsWith branch — exact match and slash-delimited
   startsWith are sufficient.

Closes #1579

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:47:49 -06:00
Iouri Goussev
ce5f7b73b6 refactor(auto-loop): initial cleanup — hoist constant, cache prefs per iteration (#1616)
* refactor(auto-loop): hoist MAX_RECOVERY_CHARS to module level

Constant was defined inside the while loop body on every iteration.
Moved to module level next to MAX_LOOP_ITERATIONS.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* refactor(auto-loop): cache loadEffectiveGSDPreferences() once per iteration

Was called 9 times per loop iteration. Now called once at the top of the
try block and stored in `prefs`, used throughout the iteration.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-20 10:42:54 -06:00
TÂCHES
29bdd929ce feat(gsd): add browser-executable and runtime-executable UAT types (#1620)
New UAT types skip human pause, enabling automated browser and script
verification by the engine.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:41:57 -06:00
TÂCHES
d500576191 refactor(gsd): add 30K char hard cap on prompt preamble (#1619)
capPreamble() enforces MAX_PREAMBLE_CHARS via truncateAtSectionBoundary,
applied to all inlinedContext assembly points. Replaces deleted compression
subsystem with a simple deterministic cap.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:41:49 -06:00
TÂCHES
da0a8f31f7 refactor(gsd): replace stuck counter with sliding-window detection (#1618)
Replace the crude sameUnitCount counter with a sliding window (size 6)
that detects three stuck patterns:

1. Same error repeated twice in a row → stuck immediately
2. Same unit derived 3 consecutive times → stuck (was 5, now faster)
3. Oscillation pattern A→B→A→B → stuck (previously undetected)

Graduated recovery preserved: first detection triggers cache invalidation
+ retry, second detection triggers hard stop.

Exported detectStuck() function with 8 unit tests covering all rules
plus edge cases (truncation, priority, non-triggers).

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:41:35 -06:00
TÂCHES
5dbfc86882 feat: apply model preferences in guided flow for milestone planning (#1614)
dispatchWorkflow now resolves per-phase model preferences (e.g.,
models.planning, models.execution) via resolveModelWithFallbacksForUnit
and applies them with pi.setModel before dispatching the workflow message.
All 22 call sites pass the appropriate unit type context so planning,
research, execution, and completion phases each use the configured model.

Closes #1582

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:46 -06:00
TÂCHES
dbf24145ab fix: move unit closeout to run immediately after completion (#1612)
closeoutUnit() ran at the start of the next loop iteration, creating a
window where a crash between runUnit() returning and the next iteration
would lose all telemetry (metrics, activity log, memory extraction).
completed-units.json was also never flushed to disk, causing severe
staleness (3 entries for 322 completed units in production).

Closes #1590

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:40 -06:00
TÂCHES
426e0e839c fix: use pathspec exclusions in smartStage to prevent hanging on large repos (#1613)
smartStage() ran `git add -A` on the entire repo then unstaged exclusions,
causing indefinite hangs on repos with large untracked artifact trees (57GB+).
autoCommitDirtyState() bypassed smartStage() entirely via direct nativeAddAll().

Add nativeAddAllWithExclusions() using `git add -A -- ':!pattern'` syntax so
excluded paths are never hashed. Route autoCommitDirtyState() through it with
RUNTIME_EXCLUSION_PATHS.

Closes #1605

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:34 -06:00
TÂCHES
2f5323ee97 fix: add auto-fix for premature slice completion deadlock in doctor (#1611)
When a slice is marked [x] in ROADMAP but tasks are incomplete and no
summary exists, doctor detects slice_checked_missing_summary (declared
fixable) but had no shouldFix handler — creating an unrecoverable
deadlock. Add handler that unchecks the slice when tasks are incomplete,
and add markSliceUndoneInRoadmap to both doctor.ts and
roadmap-mutations.ts.

Closes #1591

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:24 -06:00
TÂCHES
ec55fe64f1 fix: resolve ${VAR} env references in MCP client .mcp.json configs (#1609)
The MCP client passed raw "${VAR}" strings to child processes instead of
resolving them against process.env, breaking MCP servers that expect
resolved environment variable values.

Adds a resolveEnv() helper that interpolates ${VAR} patterns in env
config values before passing them to StdioClientTransport.

Closes #1599

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:15 -06:00
TÂCHES
fc4cb836fe fix: return "dispatched" after doctor heal to prevent session race (#1580) (#1610)
After dispatchDoctorHeal fires pi.sendMessage({ triggerTurn: true }),
the function fell through to return "continue". The auto-loop treated
"continue" as "proceed to next unit", called newSession() while the
session manager was still processing the heal turn, and the 30s timeout
killed auto-mode.

Returning "dispatched" causes the auto-loop to break, letting the heal
turn complete and trigger its own handleAgentEnd to resume the loop.

Closes #1580

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:27:34 -06:00
TÂCHES
43d8dbc9d3 fix: update Anthropic OAuth endpoints to platform.claude.com (#1608)
Anthropic migrated their OAuth infrastructure from console.anthropic.com
to platform.claude.com. The old URLs are decommissioned, breaking all
OAuth login flows.

Closes #1587

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:27:20 -06:00
Marek Hovadík
f2bcd049ae fix: lazy-open GSD database on first tool call in manual sessions (#1606)
In manual sessions (no auto-mode), bootstrapAutoSession never runs, so the
GSD database is never opened. This causes gsd_save_decision,
gsd_update_requirement, and gsd_save_summary tools to always fail with
'GSD database is not available'.

Add ensureDbOpen() helper that checks isDbAvailable() first, then tries to
open the DB from the expected .gsd/gsd.db path if it exists. All three tool
handlers now use this helper instead of the check-only pattern.

The fix is backward-compatible: in auto-mode the DB is already open, so
ensureDbOpen() returns true immediately on the isDbAvailable() check.
2026-03-20 10:27:04 -06:00
TÂCHES
7c25036ed9 feat(gsd): GitHub sync extension — auto-sync to Issues, PRs, Milestones (#1603)
* feat(gsd): GitHub sync extension — auto-sync lifecycle events to Issues, PRs, Milestones

Standalone opt-in extension at src/resources/extensions/github-sync/ that
syncs GSD lifecycle events to GitHub as a presentation layer. Local .gsd/
files remain source of truth; GitHub is fire-and-forget.

Lifecycle mapping:
- plan-milestone → GH Milestone + tracking Issue (roadmap body)
- plan-slice → slice branch + draft PR + task sub-issues
- execute-task → summary comment + close task issue + Resolves #N commit
- complete-slice → mark PR ready + squash-merge into milestone branch
- complete-milestone → close GH Milestone + tracking issue

GSD core changes (minimal):
- preferences: add `github` config key with validation and merge logic
- auto-post-unit: single dynamic import integration point after auto-commit
- git-service: `issueNumber` field on TaskCommitContext for Resolves #N trailer

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: strict TS casts for SummaryFrontmatter and GitHubSyncConfig

CI tsconfig requires double-cast through unknown for interfaces
without index signatures.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:10:37 -06:00
Iouri Goussev
485003777f refactor(auto-loop): 5 code smell fixes (#1602)
- Extract closeoutAndStop helper, replace 4 duplicated patterns
- Fix isRetry variable shadowing → isRetryForOutcome
- Replace budget alert if/else cascade with BUDGET_THRESHOLDS table
- Extract generateMilestoneReport, deduplicate basename import
- Remove unused _prefs param from runUnit and all call sites
2026-03-20 10:02:24 -06:00
TÂCHES
65dca68242 refactor(gsd): replace session-scoped promise bridge with per-unit one-shot (#1595)
Move `pendingResolve` and `sessionSwitchInFlight` from AutoSession to
module-level variables in auto-loop.ts (`_currentResolve`,
`_sessionSwitchInFlight`). Remove `pendingAgentEndQueue` entirely —
agent_end events arriving with no pending resolver are now dropped
(with a debug warning) instead of queued.

This eliminates the `_activeSession` singleton, the queue drain logic
in `runUnit`, and three properties from `AutoSession.reset()`.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 09:56:43 -06:00
TÂCHES
900d2fbd7c fix(gsd): detect anthropic-vertex in provider doctor (#1598)
* fix(gsd): detect anthropic-vertex in provider doctor

* test(gsd): avoid secret-scan false positives
2026-03-20 09:56:29 -06:00
Glen
0bceb689a7 feat: add GSD_PROJECT_ID env var to override project hash (#1600)
Extract validateProjectId() and validate at startup in
bootstrapAutoSession() so users get immediate feedback on invalid
values. repoIdentity() returns the custom ID directly when set.
2026-03-20 09:56:19 -06:00
TÂCHES
912dab1d81 refactor(gsd): remove prompt compression subsystem (~4,100 lines) (#1597)
Delete prompt-compressor, summary-distiller, and semantic-chunker modules
plus all associated tests. Replace all compression/distillation/chunking
call sites with section-boundary truncation via truncateAtSectionBoundary.
Remove compression_strategy preference, validation, and documentation.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 09:55:07 -06:00
TÂCHES
e14eee14fe refactor(gsd): crashproof stopAuto with independent try/catch per cleanup step (#1596)
Each cleanup group in stopAuto is wrapped in its own try/catch so a
failure in one step (e.g., worktree exit, DB close, model restore)
cannot abort remaining cleanup. Critical invariants (s.active=false,
s.paused=false, UI reset, pendingResolve=null) are moved into a
finally block that executes unconditionally.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 09:54:55 -06:00
TÂCHES
2fa8728740 fix(gsd): tighten prompt automation contracts (#1556)
* fix(gsd): tighten prompt automation contracts

* fix(gsd): restore confirmation gates for reflection/requirements/roadmap, scope workflow autonomy by complexity

Amends PR #1556 to address two behavioral risks:

1. discuss.md: Remove "treat continuation as confirmation" fallthrough —
   elaboration is not confirmation. Restore explicit confirmation gates
   for requirements and roadmap preview.

2. workflow-start.md: Gate autonomy on {{complexity}} — low/medium
   workflows keep moving by default, high complexity workflows confirm
   at phase transitions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 09:33:38 -06:00
TÂCHES
f421157056 fix(gsd): harden auto-mode agent loop — session teardown, unit correlation, sidecar perf (#1592)
Address six convergent audit findings in the auto-mode agent loop:

1. Move rewriteAttemptCount to AutoSession — eliminates module-level state
   that leaked across stop/start cycles in auto-dispatch.ts
2. Add unit correlation to agent_end queue — tag events with unitId so late
   completions from unit A cannot falsely resolve unit B
3. Split post-unit into heavy/light paths — sidecars skip settle delay,
   doctor, state rebuild, and worktree sync; reduce sleep 500ms→100ms
4. Data-driven budget thresholds — consolidate 75/80/90% copy-pasted
   notification blocks into BUDGET_THRESHOLDS array lookup
5. Fix session teardown — stopAuto() restores model first then calls
   s.reset() replacing 36 lines of manual field clearing
6. Add debugLog to 12 silent catch blocks in auto-post-unit.ts

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 09:13:23 -06:00
Glen
869e037202 feat: add GSD_HOME env var to override global ~/.gsd directory (#1566)
Centralise all ~/.gsd path construction through app-paths.ts (compiled
code) or a module-level `gsdHome` const (runtime extensions that cannot
import app-paths). When GSD_HOME is set, every path that previously
resolved under ~/.gsd now resolves under the override.

Existing overrides (GSD_STATE_DIR, GSD_CODING_AGENT_DIR) continue to
take precedence when set.
2026-03-20 08:29:01 -06:00
Jeremy McSpadden
21a9ab2bcf fix: break remaining shared/mod.js barrel imports in report generation chain (#1588)
PR #1527 fixed metrics.ts but missed several other paths that still
reach shared/mod.js → ui.js → @gsd/pi-tui during report generation
via native dynamic import() (which bypasses jiti alias resolution).

Remaining chains fixed:
- preferences.ts, preferences-validation.ts, export.ts, forensics.ts,
  migrate/parsers.ts: import from shared/format-utils.js directly
- state.ts, visualizer-data.ts, files.ts: import from milestone-ids.js
  instead of guided-flow.js (which pulls in shared/mod.js)
- files.ts: import checkExistingEnvKeys from new env-utils.ts instead
  of get-secrets-from-user.ts (which imports @gsd/pi-tui)

New file: env-utils.ts extracts the pure checkExistingEnvKeys function.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 08:28:53 -06:00
Jeremy McSpadden
e35ad9d194 feat(gsd): add 13 enhancements to /gsd doctor (#1583)
New detections:
- Circular dependency detection (DFS cycle check on slice depends:[])
- Orphaned slice directories (dirs not in roadmap)
- Duplicate task IDs in plan files
- Task summary files on disk not in plan (info)
- Stale REPLAN.md when all tasks are done (info)
- Metrics ledger corruption (version != 1 or units not array)
- Large planning files >100KB (warning)
- Future completed_at timestamps >24h ahead (warning)

New modes and output:
- --dry-run flag: reports [dry-run] would fix entries without writing
- --json flag: formatDoctorReportJson() for CI/tooling integration
- --build / --test flags: opt-in slow checkBuildHealth/checkTestHealth
- Per-check timing: timing.{git,runtime,environment,gsdState} on DoctorReport
- Doctor history: appends compact JSONL entry to .gsd/doctor-history.jsonl;
  exports readDoctorHistory() for programmatic access

Tests: 27 new test scenarios in doctor-enhancements.test.ts covering all features
2026-03-20 08:12:09 -06:00
Jeremy McSpadden
b580f64144 fix: apply pi manifest opt-out to extension-discovery.ts (#1545)
* fix: apply pi manifest opt-out to extension-discovery.ts (#1537 follow-up)

The cmux fix in #1537 patched resolveExtensionEntries() in
packages/pi-coding-agent/src/core/extensions/loader.ts to honor
"pi": {} as an opt-out from auto-discovery. However, there is a
second copy of resolveExtensionEntries() in src/extension-discovery.ts
that was not updated. This is the version actually used at startup
by loader.js via discoverExtensionEntryPaths().

As a result, cmux/index.js is still discovered and loaded as an
extension on startup, producing:
  Extension does not export a valid factory function: .../cmux/index.js

Fix: Apply the same authoritative-manifest logic to the
extension-discovery.ts copy. When a package.json has a "pi" field,
treat it as authoritative and return early — either with declared
extension paths or an empty array for library opt-out.

Tests: 7 new tests covering resolveExtensionEntries and
discoverExtensionEntryPaths behavior for opt-out, declared
extensions, and fallback discovery.

* fix: apply pi manifest opt-out to package-manager.ts (third copy)

There are THREE copies of resolveExtensionEntries():
1. packages/pi-coding-agent/src/core/extensions/loader.ts (fixed in #1537)
2. src/extension-discovery.ts (fixed in previous commit)
3. packages/pi-coding-agent/src/core/package-manager.ts (THIS commit)

Copy #3 is used by collectAutoExtensionEntries() which is called from
addAutoDiscoveredResources() during DefaultPackageManager.resolve().
This is the actual code path that discovers ~/.gsd/agent/extensions/cmux
and passes it to loadExtensions(), producing the factory function error.

* fix: rewrite pi.extensions .ts paths to .js during resource copy

copy-resources.cjs compiles .ts → .js via tsc but copies package.json
files verbatim. Extensions with pi.extensions: ["./index.ts"] end up
in dist/ pointing to a .ts file that doesn't exist (only .js does).

This causes resolveExtensionEntries() to find no valid entry points,
silently skipping the extension. Affected: gsd, browser-tools, context7,
google-search, universal-config — all extensions with pi manifests.

Fix: When copying package.json files, rewrite .ts/.tsx extensions in
pi.extensions arrays to .js so they match the compiled output.

* fix: add missing commands to /gsd description and rate sub-completions

- Add 9 missing commands to the description string: widget, rate, park,
  unpark, init, setup, logs, inspect, extensions
- Add sub-completions for /gsd rate (over/ok/under)

* feat: grid layout for parallel cmux splits and completion trailing-space fix

CmuxClient.createGridLayout(count) pre-creates a tiled grid of surfaces
before launching parallel agents, instead of the previous approach of
creating splits per-agent with alternating right/down directions.

Grid layout strategy:
  1 agent:  [gsd | A]
  2 agents: [gsd | A]    (A split down)
            [    | B]
  3 agents: [gsd | A]    (2x2 grid)
            [ C  | B]
  4 agents: [gsd | A]    (additional splits from bottom-right)
            [ C  | B]
            [    | D]

Changes:
- Add CmuxClient.createSplitFrom(sourceSurfaceId, direction) to split
  from a specific surface rather than always the gsd surface
- Add CmuxClient.createGridLayout(count) that builds the grid and
  returns surface IDs in order
- Update runSingleAgentInCmuxSplit to accept a pre-created surface ID
  (string) or a direction for backward compatibility
- Parallel dispatch pre-creates grid, assigns each agent a surface
- Fix getArgumentCompletions trailing-space handling so sub-completions
  work (e.g., /gsd cmux <tab> now shows status/on/off/etc.)
- 5 new tests for grid layout logic
2026-03-20 08:11:51 -06:00
Jeremy McSpadden
1b6b16f2d5 feat: feat(ui): minimal GSD welcome screen on startup (#1584)
* feat(ui): add GSD welcome screen on interactive startup

Renders a two-panel boxed welcome screen to stderr before the TUI
takes over, mirroring the style of the Claude Code welcome screen.

Left panel  — personalized greeting, GSD ASCII logo, active model + cwd
Right panel — getting-started tips, recent session activity

The screen is printed to stderr immediately before InteractiveMode.run(),
so it appears on launch and reappears when the TUI exits (alternate-screen
buffer swap). It silently skips when not a TTY or terminal < 60 cols.

Files:
  src/welcome-screen.ts          — printWelcomeScreen() implementation
  src/cli.ts                     — call site before interactiveMode.run()
  src/tests/welcome-screen.test.ts — 11 unit tests (all passing)

* refactor(ui): minimal welcome screen — logo + metadata, no box

Replace two-panel boxed layout with a minimal design:
logo block with version/model/cwd alongside it, dim hint below.
No box borders, no tips panel. Clean and fast.

* feat(ui): show tool status line (Brave/Jina/Tavily) when keys are configured
2026-03-20 08:11:06 -06:00
Juan Francisco Lebrero
f1a27b02b8 fix: detect worktree paths resolved through .gsd symlinks (#1585)
When .gsd is a symlink (e.g., openclip/.gsd -> ~/.gsd/projects/<hash>),
worktrees resolve to ~/.gsd/projects/<hash>/worktrees/<name> instead of
the expected <repo>/.gsd/worktrees/<name>. All worktree detection
functions used the marker /.gsd/worktrees/ which did not match the
resolved path /.gsd/projects/<hash>/worktrees/.

This caused three cascading failures:
1. escapeStaleWorktree failed to detect stale worktree CWD
2. isUnderGsdWorktrees returned false, causing nested worktrees
3. Empty registry was conflated with "all milestones complete"

Changes:
- Add findWorktreeSegment helper matching both direct and symlink layouts
- Refactor detectWorktreeName and resolveProjectRoot to use the helper
- Fix escapeStaleWorktree in auto-worktree-sync.ts for symlink paths
- Fix isUnderGsdWorktrees in auto-start.ts for symlink paths
- Fix resolveCapturesPath in captures.ts for symlink paths
- Distinguish empty registry from all-complete in auto-loop.ts
- Add tests for symlink-resolved path detection
2026-03-20 08:10:45 -06:00
github-actions[bot]
1b2ff19615 release: v2.38.0 2026-03-20 07:07:25 +00:00
TÂCHES
ebd2408ffc fix(ci): reduce GitHub Actions minutes ~60-70% (~10k → ~3-4k/month) (#1552)
- Remove feat/** push trigger (PRs already cover feature branches)
- Add concurrency groups with cancel-in-progress to kill stale runs
- Add paths-ignore for docs/markdown/license/unrelated workflow changes
- Consolidate secret-scan, no-gsd-dir, skill-references into single lint job
- Restrict Windows runner (2x minute multiplier) to main push only

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 00:31:49 -06:00
TÂCHES
1bd53a4c87 fix(gsd): reactive batch verification + dependency-based carry-forward (#1549)
* fix(gsd): batch-specific artifact verification for reactive-execute

The reactive-execute artifact verifier previously checked only that
'at least one task summary exists' in the slice. This meant the unit
could report success even when none of the dispatched tasks actually
completed — a pre-existing T01 summary would satisfy the check.

Fix:
- Encode dispatched task IDs in the unitId: M001/S01/reactive+T02,T03
- Persist dispatched batch in ReactiveExecutionState before dispatch
- Verify each dispatched task's summary file exists individually
- Legacy unitId format (no +batch suffix) falls back to old behavior

The verifier now answers 'did the tasks we dispatched actually finish?'
instead of 'does any summary exist?'

Added ReactiveExecutionState.dispatched field to track the batch.
5 new tests covering: all-pass, partial-fail, pre-existing-irrelevant,
legacy fallback, and unitId round-trip encoding.

* fix(gsd): dependency-based carry-forward for reactive task execution

In reactive mode, each subagent task was getting order-based carry-forward
(all prior task summaries by number), not dependency-based. T05 depending
only on T02 would still receive T01, T03, T04 summaries — noise context
that wastes tokens and could confuse execution.

Fix:
- Add getDependencyTaskSummaryPaths() — returns only summaries for tasks
  in the derived dependsOn set, falling back to order-based for root tasks
  with no dependencies (preserves continuity)
- Add ExecuteTaskPromptOptions with carryForwardPaths override
- buildExecuteTaskPrompt accepts optional override, sequential callers
  unchanged (no options = order-based, backward compatible)
- buildReactiveExecutePrompt now passes dependency-scoped paths per task

Sequential execute-task dispatch is completely unchanged — the new code
path only activates when carryForwardPaths is explicitly provided.

3 new tests: dependency-only filtering, root task fallback, missing
dependency summary handling.
2026-03-19 23:59:03 -06:00
Copilot
596b941475 Fix health widget false 'Anthropic key missing' when authenticated via GitHub Copilot (#1522)
* Initial plan

* Fix health widget false 'Anthropic key missing' when authenticated via GitHub Copilot

- Use getEnvApiKey() from @gsd/pi-ai for authoritative env var resolution
  (checks ANTHROPIC_OAUTH_TOKEN, COPILOT_GITHUB_TOKEN, GH_TOKEN, etc.)
- Add cross-provider routing: GitHub Copilot auth satisfies Anthropic/OpenAI requirements
- Add github-copilot to modelToProviderId prefix map
- Keep PROVIDER_REGISTRY env var fallback for non-LLM providers (search/tools)
- Add tests for cross-provider routing and multi-env-var detection

Co-authored-by: glittercowboy <186001655+glittercowboy@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: glittercowboy <186001655+glittercowboy@users.noreply.github.com>
2026-03-19 23:33:05 -06:00
TÂCHES
e4cd141503 fix(gsd): enforce backtick file paths in task plan IO sections (#1548)
* fix(gsd): enforce backtick file paths in task plan IO sections

The reactive task graph (ADR-004) derives dependencies from backtick-wrapped
file paths in ## Inputs and ## Expected Output sections. Without concrete
paths, the graph is ambiguous and falls back to sequential execution.

Changes:
- task-plan.md template: add comments explaining paths are machine-parsed
- plan-slice.md prompt: explicitly instruct planner to write backtick file
  paths in IO sections, add self-audit check for path presence
- observability-validator.ts: new validation rules missing_output_file_paths
  (warning) and missing_input_file_paths (info) catch plans without paths
- plan-quality-validator.test.ts: 4 new test cases for IO path validation

* fix(ci): increase max_tokens and add JSON parse error handling in ai-triage

max_tokens: 300 was too low, causing truncated JSON responses from Claude
that failed to parse. Bumped to 1024 and added try/catch with raw text
logging for easier debugging.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 23:28:44 -06:00
TÂCHES
567751471a feat(gsd): ADR-004 — derived-graph reactive task execution (#1546)
Add reactive (graph-derived parallel) task execution within slices.
When enabled via preferences, the dispatch table derives a task dependency
graph from IO annotations in task plans and dispatches multiple ready,
non-conflicting tasks in parallel via subagent.

Architecture:
- Graph derivation happens at dispatch time (auto-dispatch.ts)
- A new reactive-execute prompt instructs the agent to use subagent
  parallel mode to dispatch all currently-ready tasks
- The auto-loop treats reactive-execute as a single unit type
- After agent_end, the orchestrator checks which tasks completed and loops

New files:
- reactive-graph.ts: pure graph derivation, ready-set resolution,
  conflict detection, deadlock detection, IO loader, state persistence
- prompts/reactive-execute.md: prompt template for parallel dispatch
- tests/reactive-graph.test.ts: 22 unit tests for graph functions
- tests/reactive-executor.test.ts: 11 integration tests for dispatch
  rules, preferences validation, state persistence, re-entry

Modified files:
- types.ts: TaskIO, DerivedTaskNode, ReactiveExecutionConfig,
  ReactiveExecutionState interfaces
- files.ts: parseTaskPlanIO() extracts IO from task plan sections
- preferences-types.ts: reactive_execution config + known keys
- preferences-validation.ts: validation with range checks
- auto-dispatch.ts: new reactive-execute dispatch rule
- auto-prompts.ts: buildReactiveExecutePrompt()
- auto-recovery.ts: artifact verification for reactive-execute
- auto-post-unit.ts: reactive state cleanup on slice completion

Backward compatible: disabled by default, falls through to sequential
execution when disabled, ambiguous, or only 1 task is ready.
2026-03-19 23:19:46 -06:00
Nathan Roe
39cd932abb feat: add anthropic-vertex provider for Claude on Vertex AI (#1533)
* feat: add anthropic-vertex provider for Claude models on Google Vertex AI

Add a new anthropic-vertex provider that enables using Claude models
(Opus 4.6, Sonnet 4.6, Haiku 4.5) through Google Vertex AI using the
@anthropic-ai/vertex-sdk package. Follows the same pattern as the
existing google/google-vertex provider split.

Detection uses ANTHROPIC_VERTEX_PROJECT_ID (same env var as Claude Code)
with CLOUD_ML_REGION for region selection, falling back to us-central1.

Extracts shared Anthropic utilities into anthropic-shared.ts (message
conversion, tool conversion, param building, stream processing) to
avoid duplication between anthropic.ts and anthropic-vertex.ts.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: add full Claude model set for anthropic-vertex provider

Add 200K context window variants for Opus 4.6 and Sonnet 4.6, plus
older models (Sonnet 4.5, Sonnet 4, Opus 4.5, Opus 4.1, Opus 4, Haiku 4.5).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: add @anthropic-ai/vertex-sdk to root dependencies

Required for the published package to resolve the vertex SDK at runtime.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: remove unnecessary comments to match codebase style

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: remove duplicate stream functions after rebase

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Nathan Roe <nathan.roe@carvana.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 23:14:13 -06:00
Jeremy McSpadden
111537f460 docs: fix stale references across documentation (#1543)
* docs: update README for v2.37 — changelog, extensions, stale refs

- Update "What's New" section from v2.33 to v2.37
- Update extensions table: add Async Jobs and GitHub, remove LSP (Pi SDK core)
- Fix extension count in architecture section (12 → 18)
- Remove stale v2.17 version tags from Token Optimization section

* docs: fix stale references across documentation

- commands.md: update version example from v2.28 to v2.37
- troubleshooting.md: fix Node.js requirement from ≥20.6.0 to ≥22.0.0
- skills.md: fix project-local skills path from .pi/ to .gsd/
- CONTRIBUTING.md: fix scope area paths to include packages/ prefix,
  remove incorrect PR #1232 supply chain attack reference
- vscode-extension: fix Node.js requirement, remove hardcoded RPC
  command count (changes over time)

* docs: add troubleshooting for command not found after install

Addresses #1542 — npm global bin directory not in PATH is a common
issue on macOS, especially with Homebrew Node, version managers, or
oh-my-zsh git aliases.

- Add "command not found: gsd" section to troubleshooting.md
- Add callout to getting-started.md install section
2026-03-19 22:14:03 -06:00