Commit graph

1614 commits

Author SHA1 Message Date
Derek Pearson
bd4da09510 Merge remote-tracking branch 'origin/main' into fix/stale-interrupted-session-resume 2026-03-21 22:04:19 -04:00
Derek Pearson
3b9b109a4e fix(gsd): address QA round 4
- Add unitType/unitId round-trip test for paused-session metadata.
- Add backward-compatibility test for legacy metadata without
  unitType/unitId fields.
2026-03-21 21:45:44 -04:00
Derek Pearson
690bcbd79c fix(gsd): address QA round 3
- Set resourceVersionOnStart on paused-session resume so resource
  staleness detection works for resumed sessions.
- Re-register setLevelChangeCallback on resume so health-level
  transition notifications fire after process restart.
- Persist unitType/unitId in paused-session metadata and restore them
  on resume so recovery synthesis framing text shows the actual unit
  instead of "unknown"/"unknown".
- Check worktreePath existence before showing "(worktree)" in resume
  notification to avoid misleading the user when the worktree was
  already torn down.
- Fix showDiscuss skip_milestone to use step:false (matching
  discuss_draft and discuss_fresh) instead of hardcoded step:true.
2026-03-21 21:27:44 -04:00
Derek Pearson
364cc7dcbc fix(gsd): address QA round 2
- Initialize autoStartTime, originalModelId, originalModelProvider, and
  autoModeStartModel on file-based paused-session resume path so
  dashboard elapsed time, model restore on stop, and error-recovery
  model fallback all work correctly.
- Validate worktreePath existence before using it as assessment base;
  fall back to project root when the worktree has been torn down.
- Add tests for paused-session-only (no lock) with resumable disk state
  and for worktreePath fallback when the directory no longer exists.
2026-03-21 21:11:11 -04:00
Derek Pearson
9e357f8a85 fix(gsd): address QA round 1
- Re-derive state from project root after stale/recoverable cleanup in
  guided flow; the assessment may have derived state from a worktree
  path that was cleaned up, leading to stale state being used downstream.
- Add test for the "none" classification path (clean startup with no
  lock and no paused session) to close coverage gap.
2026-03-21 20:57:21 -04:00
Derek Pearson
d3db0cb411 fix(gsd): address review feedback from trek-e
- Remove redundant `void verboseMode` suppression (parameter is used at line 364)
- Simplify hasStrongRecoverySignal: `hasResumableDiskState || recoveryToolCallCount > 0`
  (the previous expression had a redundant third disjunct)
- Remove extra blank line in auto.ts between stepMode assignment and lock-clear block
2026-03-21 20:48:12 -04:00
Derek Pearson
71f14269a5 fix(gsd): assess recovery from paused worktree state
Use paused-session worktree metadata when deriving interrupted-session state so
worktree isolation decisions follow the authoritative disk state without
changing /gsd discuss auto handoff semantics.
2026-03-21 20:36:03 -04:00
Derek Pearson
3bb3ca8020 fix(gsd): satisfy extension typecheck for interrupted recovery
Remove a dead running-state comparison after the early return in startAuto so
extension typechecking passes alongside the interrupted-session regressions.
2026-03-21 20:08:05 -04:00
Derek Pearson
11e126a1a6 fix(gsd): restore hook dispatch export and guided flow imports
Remove a duplicate guided-flow import that broke module loading and restore the
public dispatchHookUnit export so /gsd run-hook continues to work.
2026-03-21 19:52:22 -04:00
Derek Pearson
7a384a45d1 fix(gsd): clear stale paused metadata in guided flow
Remove stale paused-session state when guided entry suppresses interrupted
resume prompts and keep discuss-triggered auto resumes in step mode.
2026-03-21 19:32:59 -04:00
Derek Pearson
9992d24649 fix(gsd): preserve interrupted-session resume mode
Discard stale paused-session metadata on direct auto starts and pass paused
step-mode through guided resume so the selected interrupted-session action
matches the actual resumed mode.
2026-03-21 14:03:18 -04:00
Derek Pearson
2b4e78d9ab fix: preserve explicit interrupted-session resume mode
Pass paused step-mode metadata through guided resume actions and tighten source
coverage around stale paused-session handling so the interrupted-session flow
matches the selected resume mode.
2026-03-21 13:41:22 -04:00
Derek Pearson
33564894cf fix: preserve step-mode and suppress stale paused resumes
Remove the duplicated auto bootstrap block, keep paused step-mode sessions on
/gsd next, and treat stale paused-session metadata as non-resumable when disk
state shows no unfinished work.
2026-03-21 13:20:21 -04:00
Derek Pearson
d82c323be2 fix: suppress stale interrupted-session resume prompts
Treat interrupted sessions as resumable only when paused metadata, crash trace,
or unfinished derived state indicate real work remains. This clears dead locks
for completed/no-op repos and keeps guided flow plus /gsd auto consistent.
2026-03-20 22:34:30 -04:00
github-actions[bot]
c4286f4c57 release: v2.40.0 2026-03-20 21:54:27 +00:00
Derek Pearson
33c4203412 Merge branch 'main' of https://github.com/gsd-build/gsd-2 2026-03-20 17:46:07 -04:00
Jeremy McSpadden
b8d08f3667 fix: prune stale env-utils.js from extensions root, preventing startup load error (#1655)
* fix: prune stale env-utils.js from extensions root, preventing startup load error

- Move env-utils.ts from extensions/ root into gsd/ subdirectory
- Update all import paths to reflect new location
- Add manifest-based tracking in resource-loader to record which root-level
  extension files are installed, so future upgrades can detect and prune files
  that get removed or relocated (preventing recurrence)
- Add known-stale fallback for pre-manifest upgrades (explicitly removes
  env-utils.js which was moved into gsd/ in this release)
- Remove re-export block from auto.ts that referenced relocated symbols
- Clean up session_start handler in native-search.ts (remove provider diagnostics
  that were duplicating info already shown by model_select)
- Update welcome-screen layout to two-panel bar design for visual consistency

* fix: resolve PR1655 extension load and compile regressions

* fix: remove duplicate _clearGsdRootCache export

* fix: restore native-search session_start diagnostics
2026-03-20 15:43:06 -06:00
Derek Pearson
83bacfcc94 feat(pi): add Skill tool resolution (#1661)
* fix(gsd extension): detect initialized projects in health widget

Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.

* fix(gsd extension): detect initialized projects in health widget

Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.

* feat: add Skill tool resolution for Pi agent

Expose a built-in Skill tool so dispatched prompts can resolve skill names without guessing file paths. This aligns runtime behavior with skill activation prompts and adds coverage for exact activation and unknown-skill handling.
2026-03-20 15:42:28 -06:00
Jeremy McSpadden
bb91b05137 fix(splash): replace box corners with full-width bars for visual unity with auto-mode widget (#1654)
Replaces the rounded box-corner two-panel layout (╭╮╰╯) with full-width
cyan ─ bars at top and bottom, matching the auto-mode progress widget's
ui.bar() style exactly. The inner │ divider and ├─ section separators are
kept (dimmed) so the two-panel logo/info layout is preserved.

Changes:
- Top/bottom borders: chalk.cyan('─'.repeat(termWidth)) — same as widget ui.bar()
- Outer vertical box borders removed; inner │ divider kept as dim separator
- Section dividers changed to dim ├──── style
- Trailing spaces removed from hint/version strings (no closing │ to pad against)
- Panel width formula updated: 1 + LEFT_INNER + 1 + RIGHT_INNER = termWidth
2026-03-20 15:42:18 -06:00
Jeremy McSpadden
94fe53b527 feat: health check phase 2 — real-time doctor issue visibility across widget, visualizer, and HTML reports (#1644)
* feat: surface real doctor issue details in progress score widget

Previously the progress score traffic light (green/yellow/red) only
showed generic labels like "2 consecutive error units" or "Health
trend declining". The actual doctor issue descriptions were computed
in auto-post-unit but discarded before reaching the widget — only
aggregate counts were stored in HealthSnapshot.

Now the full data flows through:

- HealthSnapshot stores issue details (code, message, severity,
  unitId) and fix descriptions alongside the counts
- recordHealthSnapshot() accepts optional issue/fix arrays
  (backwards compatible — existing callers unchanged)
- getLatestHealthIssues() and getLatestHealthFixes() retrieve the
  most recent details for display
- computeProgressScore() surfaces up to 5 real issue messages
  (errors first) and up to 3 recent fixes as ProgressSignals
  when the level is yellow or red
- Dashboard overlay renders signal details with ✓/✗/· icons
  below the traffic light when degraded

This gives real-time visibility into what the auto-doctor is
detecting and fixing, without requiring manual /gsd doctor runs
or opening the full dashboard to investigate.

* feat: integrate doctor health data into visualizer and HTML reports

Phase 2b: close visibility gaps across visualizer and export surfaces.

Persistence (doctor.ts):
- Enrich DoctorHistoryEntry with issue details (severity, code,
  message, unitId) and fix descriptions
- appendDoctorHistory now persists up to 10 issues per entry and
  all fix descriptions to doctor-history.jsonl
- Export DoctorHistoryEntry type for consumers

Data layer (visualizer-data.ts):
- Add VisualizerDoctorEntry and VisualizerProgressScore types
- Extend HealthInfo with doctorHistory (last 20 persisted entries)
  and progressScore (current in-memory traffic light)
- loadHealth reads doctor-history.jsonl synchronously and snapshots
  current progress score when health data exists

TUI visualizer (visualizer-views.ts):
- Health tab now shows "Progress Score" section with traffic light
  icon, summary, and all signal details (✓/✗/· prefixed)
- Health tab now shows "Doctor History" section with timestamped
  entries, issue messages, and applied fixes

HTML export (export-html.ts):
- Health section includes progress score with colored indicator
  and signal breakdown
- Health section includes "Doctor Run History" table with
  timestamps, error/warning/fix counts, issue codes, expandable
  issue messages, and fix descriptions

* feat: fill remaining health gaps — scope tagging, level notifications, human-readable logs

Gap fills:

Per-milestone/slice scope tagging:
- HealthSnapshot now stores scope (e.g. "M001/S02") from the
  doctor run's unit context
- DoctorHistoryEntry persists scope to doctor-history.jsonl
- Visualizer and HTML reports display scope tags per entry

State transition notifications:
- setLevelChangeCallback() registers a handler for progress level
  changes (green→yellow, yellow→red, red→green, etc.)
- auto-start.ts wires the callback to ctx.ui.notify on start
- auto.ts clears it on stop
- Notifications include the triggering issue message

Human-readable formatting throughout:
- formatHealthSummary() uses full words: "2 errors, 3 warnings ·
  trend degrading · 1 fix applied · 1 of 5 consecutive errors
  before escalation · latest: Missing PLAN.md for S03"
- DoctorHistoryEntry stores a human-readable summary field
  built from error counts, fix counts, and top issue message
- Visualizer doctor history shows summary instead of "2E 1W 0F"
- HTML export doctor table uses summary column with scope tags
- Post-unit notification says what was fixed ("Doctor: rebuilt
  STATE.md; cleared stale lock") instead of "applied 2 fix(es)"

Test updates:
- formatHealthSummary assertions updated for new readable format

* fix: default UAT type to artifact-driven to prevent unnecessary auto-mode pauses (#1651)

When a UAT file has no `## UAT Type` section, `extractUatType()` returns
`undefined`. The fallback was `"human-experience"`, causing `pauseAfterDispatch:
true` in the auto-dispatch rule. Since doctor-generated UAT placeholders never
include a UAT Type section and LLM-executed UATs are always artifact-driven,
the correct default is `"artifact-driven"`.

Closes #1649

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove duplicate doctorScope declaration (CI build fix)

* fix: resolve PR1644 regressions in health views and post-unit hook

---------

Co-authored-by: TÂCHES <afromanguy@me.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 15:33:40 -06:00
Iouri Goussev
93e51b04ad refactor: decompose autoLoop into pipeline phases (#1615) (#1659)
* refactor: add PhaseResult/IterationContext/LoopState types to auto-loop

No behavioral changes. Pure type additions for upcoming phase extraction.

* refactor: extract runFinalize() from autoLoop body

No behavioral changes. Pure structural extraction.

* refactor: extract runUnitPhase() from autoLoop body

No behavioral changes. Pure structural extraction.

* refactor: extract runGuards() from autoLoop body

No behavioral changes. Pure structural extraction.

* refactor: extract runDispatch() from autoLoop body

No behavioral changes. Pure structural extraction.

* refactor: extract runPreDispatch() from autoLoop body

No behavioral changes. Pure structural extraction.
Completes autoLoop pipeline phase decomposition:
  runPreDispatch → runGuards → runDispatch → runUnitPhase → runFinalize

* refactor: hoist loopState before autoLoop loop, drop sync-back hacks

loopState was created inside the loop each iteration, requiring 3 manual
sync-backs for stuckRecoveryAttempts (number copy-by-value). Hoist it
before the loop so it's a true persistent mutable struct across iterations.
2026-03-20 15:33:28 -06:00
TÂCHES
7356bd4ba9 feat: upgrade forensics prompt to full-access GSD debugger (#1660)
The forensics prompt listed only 5 source files and told the agent to
"analyze the report." This led to shallow analysis and hallucinated
paths because the agent had no knowledge of the source layout, runtime
paths, activity log format, or crash lock structure.

The rewritten prompt gives the forensics agent a complete source map
organized by domain, the full .gsd/ directory structure, data format
references for activity logs / crash locks / metrics, and a step-by-step
investigation protocol that requires tracing from symptom to specific
file:line in GSD source before filing an issue.

Closes #1656

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 15:32:50 -06:00
TÂCHES
53cee0e74c fix: add runtime paths to forensics prompt to prevent path hallucination (#1657)
The forensics prompt references "activity logs" in natural language but
never provides the actual filesystem paths. This causes the LLM agent to
hallucinate paths like `activity-logs/` when it needs to inspect raw JSONL
logs beyond the pre-parsed forensic data.

Adds a "Key Runtime Paths" section with concrete `.gsd/` paths for
activity logs, debug logs, runtime state, crash lock, completed units,
and forensics reports.

Closes #1652

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 15:31:37 -06:00
TÂCHES
dfe7715245 fix: guard TUI render during session transitions to prevent freeze (#1658)
The progress widget's render() synchronously accesses sessionManager
state via cmdCtx. When newSession() is in-flight, this can block the
TUI input loop, freezing the terminal. Guard render() to return the
last cached frame while a session switch is in progress.

Closes #1653

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 15:29:34 -06:00
TÂCHES
cc2c887948 Refactor GSD command and bootstrap modules (#1634)
* Refactor GSD command/bootstrap modules

* fix: resolve TypeScript build errors in refactored db-tools and catalog

- db-tools.ts: add missing execute callback params (signal, onUpdate, ctx),
  remove isError from return objects (not in AgentToolResult type), cast
  details as any to avoid union type mismatch across error/success paths
- catalog.ts: use Object.entries() on TemplateRegistry.templates Record
  instead of treating it as an array, use Record key as template id

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: update source-contract tests to reference refactored file locations

The god-file refactor moved code from index.ts and commands.ts into
bootstrap/agent-end-recovery.ts, bootstrap/register-hooks.ts, and
commands/handlers/core.ts. Update three test files to read from the
correct paths and adjust pattern assertions to match the new code
structure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 15:19:16 -06:00
TÂCHES
39f9faffa8 fix: default UAT type to artifact-driven to prevent unnecessary auto-mode pauses (#1651)
When a UAT file has no `## UAT Type` section, `extractUatType()` returns
`undefined`. The fallback was `"human-experience"`, causing `pauseAfterDispatch:
true` in the auto-dispatch rule. Since doctor-generated UAT placeholders never
include a UAT Type section and LLM-executed UATs are always artifact-driven,
the correct default is `"artifact-driven"`.

Closes #1649

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 15:11:55 -06:00
Derek Pearson
e7b18f9e08 Merge branch 'main' of https://github.com/gsd-build/gsd-2 2026-03-20 16:41:32 -04:00
TÂCHES
b124b79a12 fix: cancel trailing async jobs on session switch to prevent wasted LLM turns (#1643)
When a unit spawns background jobs via async_bash, job completion callbacks
fire follow-up messages after agent_end has resolved. The auto-loop has
moved on but the previous session's LLM processes these follow-ups, adding
12-45s of wasted time and ~14 unnecessary turns per unit.

Two complementary fixes:
1. Cancel all running background jobs on session_before_switch so
   completion callbacks never fire for the old session.
2. Clear the follow-up queue after runUnit() completes as defense-in-depth,
   discarding any already-queued notifications before the next session starts.

Closes #1642

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 14:29:38 -06:00
github-actions[bot]
2d08391649 release: v2.39.0 2026-03-20 19:41:22 +00:00
Jeremy McSpadden
c0342c0883 fix: recover + prevent #1364 .gsd/ data-loss (v2.30.0–v2.38.0) (#1635)
* fix: add recovery script for #1364 .gsd/ data-loss regression

Adds scripts/recover-gsd-1364.sh to help users whose .gsd/ files were
deleted by the ensureGitignore bug in v2.33.x–v2.35.x.

The script handles both damage scenarios:
- Scenario A: .gsd files deleted in working tree but not yet committed
- Scenario B: git rm --cached .gsd/ was committed (files gone from HEAD)

Steps performed:
1. Detects whether the repo is affected (symlink check, .gitignore scan,
   git history scan)
2. Finds the last clean commit before ".gsd" was added to .gitignore
3. Restores all deleted .gsd/ files via git checkout <clean-commit> -- .gsd/
4. Removes the bare ".gsd" line from .gitignore
5. Stages both changes and prints the ready-to-commit command

Supports --dry-run to preview without making changes.
Safe to run on unaffected repos — exits early with no modifications.

Closes #1364

* fix: add Windows PowerShell recovery script for #1364

Adds scripts/recover-gsd-1364.ps1, a PowerShell equivalent of the bash
recovery script for users on Windows.

Windows-specific differences handled:
- Junction detection: GSD's migrateToExternalState() uses symlinkSync()
  with type "junction" on Windows instead of a POSIX symlink. The script
  checks Get-Item.LinkType for both "SymbolicLink" and "Junction" so
  migrated repos exit cleanly on step 1.
- .gitignore rewrite uses [System.IO.File]::WriteAllLines() with UTF-8
  no-BOM encoding to match git's expectations on Windows, rather than
  shell redirection which can introduce BOM or CRLF issues.
- All git invocations use execFileSync-style array args via Invoke-Git
  helper — no shell string eval, no quoting edge cases.
- Colour output uses Write-Host -ForegroundColor instead of ANSI escapes.
- -DryRun is a proper PowerShell switch parameter.

Also updates recover-gsd-1364.sh header to:
- Clarify it is Linux/macOS only
- Point Windows users to the .ps1
- Correct the affected version range to v2.30.0-v2.35.x (was 2.33.x)
- Reference the three residual vectors on v2.36.0-v2.38.0 (PR #1635)

Usage on Windows:
  powershell -ExecutionPolicy Bypass -File scripts\recover-gsd-1364.ps1
  powershell -ExecutionPolicy Bypass -File scripts\recover-gsd-1364.ps1 -DryRun

* fix(gsd): close residual #1364 data-loss vectors on v2.36.0+

Two targeted fixes that close the three remaining paths where .gsd/
tracked files can still be silently deleted after the v2.36.0 fix.

--- Path 1: hasGitTrackedGsdFiles fails open on git error (gitignore.ts)

nativeLsFiles() swallows git failures via allowFailure=true and returns
[], making hasGitTrackedGsdFiles() indistinguishable between "nothing
tracked" and "git failed". On any transient git failure (locked index,
binary not on PATH, corrupted .git/index), the function returned false
and .gsd was added to .gitignore, deleting all tracked state.

Fix: after nativeLsFiles returns [], verify git is reachable with a
cheap rev-parse call. If git is unavailable, return true (fail safe —
assume tracked). The outer catch also returns true instead of false.

--- Path 2: migration never cleans git index (migrate-external.ts)

migrateToExternalState() correctly creates the .gsd symlink/junction but
never ran `git rm -r --cached .gsd/`. All previously tracked .gsd/* files
remained in the git index pointing through the new symlink, which git
cannot follow — causing PROJECT.md, milestones/, REQUIREMENTS.md etc. to
appear as deleted in git status immediately after every migration.

Fix: after the symlink is verified, run:
  git rm -r --cached --ignore-unmatch .gsd
--ignore-unmatch makes this a no-op on fresh/untracked projects.

--- Path 3: race between migration and ensureGitignore

Resolved by Path 2. If migration always cleans the index, the race
window (another process converting .gsd/ to a symlink between the
migrateToExternalState() and ensureGitignore() calls) is harmless —
the index is already clean and there is nothing to lose.

--- Tests added (gitignore-tracked-gsd.test.ts)

- hasGitTrackedGsdFiles returns true (fail-safe) when git is unavailable
  (simulated via .git/index.lock to force git ls-files failure)
- migrateToExternalState cleans git index so tracked files don't show
  as deleted after successful migration

Fixes residual vectors from #1364 (original fix: #1367, v2.36.0)

* fix(recovery): add Scenario C support to recover-gsd-1364 scripts

Scenario C: .gsd/ is already a symlink/junction (migration succeeded on
the filesystem) but `git rm -r --cached .gsd/` was never run, leaving
tracked .gsd/* files appearing as deleted in git status.

Both bash and PowerShell scripts previously exited early at Step 1 when
they detected a symlink. Now they continue with a dedicated Scenario C
path through all steps:

- Step 1: sets GSD_IS_SYMLINK flag, continues instead of exiting
- Step 2: inverted .gitignore check — warns if .gsd is MISSING (should
  be present for external-state layout) rather than if it's present
- Step 3: skips commit-history scan (index issue only, no file restore
  needed); exits clean if no stale entries found
- Step 4: skips damage-commit search (nothing to restore from history)
- Step 5: runs `git rm -r --cached --ignore-unmatch .gsd` to clean the
  stale index entries instead of restoring files from a prior commit
- Step 6: appends .gsd to .gitignore instead of removing it
- Step 7: stages only .gitignore (not .gsd/) to avoid the "gitignored
  path" error; the index cleanup from Step 5 is already staged
- Summary: uses a distinct commit message for Scenario C

Smoke-tested against a synthetic repo that replicates the exact Scenario
C failure mode (symlink in place, git rm --cached never run).
2026-03-20 13:26:09 -06:00
Tom Boucher
ea4d7d639e docs: update documentation for v2.38.0 release (#1636)
Update README "What's New" section to v2.38 with reactive task
execution (ADR-004), Anthropic Vertex AI provider, CI optimization,
and batch verification. Collapse v2.34–v2.37 into previous highlights.

Add reactive task execution section to auto-mode guide with
configuration and implementation details. Add AI triage workflow and
CI optimization note to CI/CD pipeline guide. Add ADR-003 to docs
index. Add 3 troubleshooting entries: session lock theft, worktree
commits on wrong branch, and extension subpath export errors.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-20 13:20:44 -06:00
Derek Pearson
90d6d71e38 feat(gsd): activate matching skills in dispatched prompts (#1630)
* fix(gsd extension): detect initialized projects in health widget

Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.

* fix(gsd extension): detect initialized projects in health widget

Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.

* feat(gsd): activate matching skills in dispatched prompts

Inject skill activations from installed skills, preferences, and task-plan handoff so GSD agents load the right skills automatically instead of relying on generic guidance. Align prompt templates and tests with the activation flow and current resource sync behavior.

* fix(gsd extension): detect initialized projects in health widget

Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.

* fix(gsd extension): restore health widget build paths

* test(resource-loader): fix sibling cleanup assertion
2026-03-20 13:20:06 -06:00
Brett Kellgren
0ec2ae020f fix: treat summary as terminal artifact even when roadmap slices are unchecked (#1632)
When a milestone has a roadmap with unchecked slice checkboxes AND a
summary file, deriveState() incorrectly treated it as incomplete. The
summary check only ran inside the `if (isMilestoneComplete(roadmap))`
branch, so it was never reached when checkboxes weren't ticked.

This caused auto-mode to pick an already-completed milestone as active,
ignoring the actual current milestone entirely.

The fix adds summary-existence checks to all three resolution paths:

1. `getActiveMilestoneId()` — now checks for summary before returning
   a milestone as incomplete
2. Phase 1 pre-scan in `deriveState()` — now adds milestones with
   unchecked roadmaps + summaries to `completeMilestoneIds`
3. Phase 2 registry builder — now checks for summary before falling
   through to the active/pending logic

This is consistent with the existing principle that the summary is the
terminal artifact (#864), which was already stated in a comment but not
enforced for the unchecked-roadmap case.

Adds two tests:
- Unchecked roadmap + summary → status is 'complete', next milestone
  is active
- Unchecked roadmap + summary satisfies depends_on for downstream
  milestones
2026-03-20 13:19:56 -06:00
Jeremy McSpadden
6f15ddcbf7 fix(gsd): close residual #1364 data-loss vectors on v2.36.0+ (#1637)
Two targeted fixes that close the three remaining paths where .gsd/
tracked files can still be silently deleted after the v2.36.0 fix.

--- Path 1: hasGitTrackedGsdFiles fails open on git error (gitignore.ts)

nativeLsFiles() swallows git failures via allowFailure=true and returns
[], making hasGitTrackedGsdFiles() indistinguishable between "nothing
tracked" and "git failed". On any transient git failure (locked index,
binary not on PATH, corrupted .git/index), the function returned false
and .gsd was added to .gitignore, deleting all tracked state.

Fix: after nativeLsFiles returns [], verify git is reachable with a
cheap rev-parse call. If git is unavailable, return true (fail safe —
assume tracked). The outer catch also returns true instead of false.

--- Path 2: migration never cleans git index (migrate-external.ts)

migrateToExternalState() correctly creates the .gsd symlink/junction but
never ran `git rm -r --cached .gsd/`. All previously tracked .gsd/* files
remained in the git index pointing through the new symlink, which git
cannot follow — causing PROJECT.md, milestones/, REQUIREMENTS.md etc. to
appear as deleted in git status immediately after every migration.

Fix: after the symlink is verified, run:
  git rm -r --cached --ignore-unmatch .gsd
--ignore-unmatch makes this a no-op on fresh/untracked projects.

--- Path 3: race between migration and ensureGitignore

Resolved by Path 2. If migration always cleans the index, the race
window (another process converting .gsd/ to a symlink between the
migrateToExternalState() and ensureGitignore() calls) is harmless —
the index is already clean and there is nothing to lose.

--- Tests added (gitignore-tracked-gsd.test.ts)

- hasGitTrackedGsdFiles returns true (fail-safe) when git is unavailable
  (simulated via .git/index.lock to force git ls-files failure)
- migrateToExternalState cleans git index so tracked files don't show
  as deleted after successful migration

Fixes residual vectors from #1364 (original fix: #1367, v2.36.0)
2026-03-20 13:15:11 -06:00
TÂCHES
8e2d403179 feat(gsd): add .gsd/RUNTIME.md template for declared runtime context (#1626)
Template for projects to declare stack, build, test, and environment
details. Inlined into execute-task prompts when present.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 12:51:51 -06:00
TÂCHES
1d3e3ee46b feat(gsd): create draft PR on milestone completion when git.auto_pr enabled (#1627)
Adds createDraftPR() to git-service.ts and hooks it into the milestone
transition block in auto-loop.ts. Best-effort, non-fatal on failure.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 11:48:13 -06:00
TÂCHES
70cf14f72d refactor(gsd): unify sidecar mini-loop into main dispatch path (#1617)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:59:26 -06:00
TÂCHES
7564901868 fix: auto-resolve npm subpath exports in extension loader (#1624)
Extensions importing unlisted subpaths from bundled packages (e.g.
@modelcontextprotocol/sdk/server) fail because jiti's CJS fallback
double-resolves paths. This adds auto-discovery of subpath exports from
bundled packages' package.json exports fields, generating alias entries
for all explicit and wildcard subpaths so extensions can import any
standard Node.js subpath export.

Closes #1604

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:53:10 -06:00
TÂCHES
8f39eefb4b fix: create node_modules symlink for dynamic import resolution in extensions (#1623)
Native ESM import() ignores NODE_PATH and resolves packages by walking up
the directory tree. Extension files synced to ~/.gsd/agent/extensions/ have
no ancestor node_modules, so imports of @gsd/* packages fail with "Cannot
find package" errors during report generation and other dynamic-import paths.

Create a symlink ~/.gsd/agent/node_modules -> GSD's node_modules after
resource sync so Node's standard resolution finds @gsd/* packages. Also
migrate the most critical dynamic imports in auto-loop, exit-command, and
commands to use importExtensionModule (jiti-based) as a belt-and-suspenders
fix.

Closes #1594

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:48:17 -06:00
TÂCHES
fb7b484d10 fix: filter cross-milestone errors from health tracker escalation (#1621)
Two bugs fixed:
1. recordHealthSnapshot counted ALL doctor issues including cross-milestone
   stale errors, inflating consecutiveErrorUnits past the escalation threshold
   from unfixable errors in other milestones. Now filters report.issues to
   only the current milestone before summarizing for health tracking.

2. matchesScope used unitId.startsWith(scope) without a delimiter, so scope
   "M004/S01" would false-match "M004/S010". Removed the redundant
   delimiter-less startsWith branch — exact match and slash-delimited
   startsWith are sufficient.

Closes #1579

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:47:49 -06:00
Derek Pearson
0092201d2c Merge branch 'main' of https://github.com/dpearson2699/gsd-2 2026-03-20 12:45:51 -04:00
Derek Pearson
e04e3ac55c fix(gsd extension): detect initialized projects in health widget
Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.
2026-03-20 12:44:40 -04:00
Iouri Goussev
ce5f7b73b6 refactor(auto-loop): initial cleanup — hoist constant, cache prefs per iteration (#1616)
* refactor(auto-loop): hoist MAX_RECOVERY_CHARS to module level

Constant was defined inside the while loop body on every iteration.
Moved to module level next to MAX_LOOP_ITERATIONS.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* refactor(auto-loop): cache loadEffectiveGSDPreferences() once per iteration

Was called 9 times per loop iteration. Now called once at the top of the
try block and stored in `prefs`, used throughout the iteration.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-20 10:42:54 -06:00
TÂCHES
29bdd929ce feat(gsd): add browser-executable and runtime-executable UAT types (#1620)
New UAT types skip human pause, enabling automated browser and script
verification by the engine.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:41:57 -06:00
TÂCHES
d500576191 refactor(gsd): add 30K char hard cap on prompt preamble (#1619)
capPreamble() enforces MAX_PREAMBLE_CHARS via truncateAtSectionBoundary,
applied to all inlinedContext assembly points. Replaces deleted compression
subsystem with a simple deterministic cap.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:41:49 -06:00
TÂCHES
da0a8f31f7 refactor(gsd): replace stuck counter with sliding-window detection (#1618)
Replace the crude sameUnitCount counter with a sliding window (size 6)
that detects three stuck patterns:

1. Same error repeated twice in a row → stuck immediately
2. Same unit derived 3 consecutive times → stuck (was 5, now faster)
3. Oscillation pattern A→B→A→B → stuck (previously undetected)

Graduated recovery preserved: first detection triggers cache invalidation
+ retry, second detection triggers hard stop.

Exported detectStuck() function with 8 unit tests covering all rules
plus edge cases (truncation, priority, non-triggers).

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:41:35 -06:00
TÂCHES
5dbfc86882 feat: apply model preferences in guided flow for milestone planning (#1614)
dispatchWorkflow now resolves per-phase model preferences (e.g.,
models.planning, models.execution) via resolveModelWithFallbacksForUnit
and applies them with pi.setModel before dispatching the workflow message.
All 22 call sites pass the appropriate unit type context so planning,
research, execution, and completion phases each use the configured model.

Closes #1582

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:46 -06:00
TÂCHES
dbf24145ab fix: move unit closeout to run immediately after completion (#1612)
closeoutUnit() ran at the start of the next loop iteration, creating a
window where a crash between runUnit() returning and the next iteration
would lose all telemetry (metrics, activity log, memory extraction).
completed-units.json was also never flushed to disk, causing severe
staleness (3 entries for 322 completed units in production).

Closes #1590

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:40 -06:00
TÂCHES
426e0e839c fix: use pathspec exclusions in smartStage to prevent hanging on large repos (#1613)
smartStage() ran `git add -A` on the entire repo then unstaged exclusions,
causing indefinite hangs on repos with large untracked artifact trees (57GB+).
autoCommitDirtyState() bypassed smartStage() entirely via direct nativeAddAll().

Add nativeAddAllWithExclusions() using `git add -A -- ':!pattern'` syntax so
excluded paths are never hashed. Route autoCommitDirtyState() through it with
RUNTIME_EXCLUSION_PATHS.

Closes #1605

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:34 -06:00
TÂCHES
2f5323ee97 fix: add auto-fix for premature slice completion deadlock in doctor (#1611)
When a slice is marked [x] in ROADMAP but tasks are incomplete and no
summary exists, doctor detects slice_checked_missing_summary (declared
fixable) but had no shouldFix handler — creating an unrecoverable
deadlock. Add handler that unchecks the slice when tasks are incomplete,
and add markSliceUndoneInRoadmap to both doctor.ts and
roadmap-mutations.ts.

Closes #1591

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:39:24 -06:00