Commit graph

3141 commits

Author SHA1 Message Date
Tibsfox
60bbf8f0b3 fix(test): update worktree sync tests to use separate milestone IDs
The fix skips the current milestone in syncWorktreeStateBack to prevent
merge conflicts. Update tests to use a different milestone ID for the
milestoneId parameter vs the milestone being synced, matching the new
skip-current-milestone behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:49:02 -07:00
Tibsfox
6bb5a3fe9a fix(gsd): use valid LogComponent type for stale branch guard warning
Change logWarning component from "autoStart" (not in LogComponent union)
to "bootstrap" to fix TypeScript compilation error.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:45:03 -07:00
Tibsfox
cff7ded42c fix(test): update rogue detection test for auto-remediation behavior
The fix auto-remediates stale slice DB status via updateSliceStatus()
instead of reporting it as a rogue artifact. Update the test to expect
0 rogues since the stale status is now silently fixed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:43:53 -07:00
Tibsfox
f8e98de19f fix(test): update stuck-planning test to expect executing after reconciliation
The fix reconciles plan-file tasks into the DB when the planner skips
persistence, so the phase correctly advances to executing instead of
remaining stuck in planning. Update the known-issue test to expect the
fixed behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:42:17 -07:00
Tibsfox
9479fe07bd fix(test): update file path consistency tests for inputs-only checking
The fix changed checkFilePathConsistency to only check task.inputs, not
task.files, since files includes paths the task will create. Update tests
to use inputs instead of files for consistency checks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:40:29 -07:00
Tibsfox
1254b631c8 fix(test): add CONTEXT file to queued milestone ghost detection test
The fix changed isGhostMilestone to treat queued+no-files as a ghost.
The test was asserting queued+DB-row = not ghost, but without content
files it is now correctly identified as a ghost. Add a CONTEXT file to
make it a legitimate queued milestone.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:38:56 -07:00
Tibsfox
c829956ec3 fix(test): update needs-remediation test to expect validating-milestone phase
The fix intentionally changed needs-remediation to route back to
validating-milestone instead of completing-milestone. Update the test
assertion to match the new expected behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:37:52 -07:00
Tibsfox
5b72365567 test: update edge-cases test to use pending slices for SUMMARY check
Closed slices (complete/done/skipped) are now excluded from
findMissingSummaries per #3620. Update the test to use pending
status so the missing-SUMMARY block still fires.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:33:32 -07:00
Tibsfox
2a2ad20592 test: add regression test for sync-worktree skip current milestone
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:31:40 -07:00
Tibsfox
f028c0938d test: add regression test for discuss-slice structured questions conditional
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:30:02 -07:00
Tibsfox
3c83aa5539 test: add regression test for restoring tools after discuss flow scoping
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:29:28 -07:00
Tibsfox
77216f6075 test: add regression test for verify-artifact tightened legacy branch
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:28:51 -07:00
Tibsfox
ce3b31e3c4 test: add regression test for stale lockfile auto-recovery
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:27:30 -07:00
Tibsfox
9ab2557f48 test: add regression test for complete-slice verification gate
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:27:30 -07:00
Tibsfox
2e4c19eb16 test: add regression test for stale pending auto-start cleanup
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:27:04 -07:00
Tibsfox
8dd8744b91 test: add regression test for pre-execution backtick strip and inputs-only check
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:53 -07:00
Tibsfox
fe84893351 test: add regression test for importing done milestones as complete
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:51 -07:00
Tibsfox
ef68e37e79 test: add regression test for skipped validation completion
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:33 -07:00
Tibsfox
b8536a896d test: add regression test for worktree expected-condition warning suppression
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:28 -07:00
Tibsfox
fceb983beb test: add regression test for slice sequence on insert
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:19 -07:00
Tibsfox
08ebf3387d test: add regression test for projection plan overwrite prevention
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:06 -07:00
Tibsfox
474c3c287d test: add regression test for prompt step ordering and runtime fixes
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:04 -07:00
Tibsfox
808a0e56bd test: add regression test for error-success mask detection
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:26:03 -07:00
Tibsfox
5a0c127543 test: add regression test for isolation:none stale branch guard
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:57 -07:00
Tibsfox
9ea3beab22 test: add regression test for phantom milestone default queued status
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:44 -07:00
Tibsfox
fc210a4edf test: add regression test for .bg-shell/ in gitignore BASELINE_PATTERNS
Structural verification that .bg-shell/ is included in the
BASELINE_PATTERNS array in gitignore.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:38 -07:00
Tibsfox
5222801ebd test: add regression test for frontmatter parse noise suppression
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:32 -07:00
Tibsfox
faf8c95c8a test: add regression test for provider manager Enter key handler
Structural verification that selectConfirm handler and onSetupAuth
callback exist in provider-manager.ts (#3579).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:26 -07:00
Tibsfox
b461cf75ed test: add regression test for run-uat replay cap
Structural verification that MAX_UAT_ATTEMPTS constant exists and
incrementUatCount is called before dispatch (#3624).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:12 -07:00
Tibsfox
1d428c5ffd test: add regression test for complete-task normalizeListParam
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:10 -07:00
Tibsfox
9475757d9a test: add regression test for dispatcher stuck-planning reconciliation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:25:10 -07:00
Tibsfox
26d1222096 test: add regression test for MCP createRequire subpath resolution
Structural verification that createRequire import and _require.resolve
usage exist in mcp-server.ts (#3603).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:24:58 -07:00
Tibsfox
7372948585 test: add regression test for status DB open in cold sessions
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:24:55 -07:00
Tibsfox
ad21e0de76 test: add regression test for note captures execution in triage resolution
Structural verification that classification === "note" filter and
markCaptureExecuted call exist in executeTriageResolutions (#3578).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:24:43 -07:00
Tibsfox
383fbfdd16 test: add regression test for isClosedStatus dispatch guard
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:24:40 -07:00
Tibsfox
554c7a5ff3 test: add regression test for project-root cwd crash and main_branch validation
Structural verification that process.cwd() is wrapped in try/catch (#3598)
and nativeBranchExists validates prefs.main_branch (#3589).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:24:26 -07:00
Tibsfox
c9a4d117b0 test: add regression test for auto-remediate stale slice status
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:24:18 -07:00
Tibsfox
a7af280c81 test: add regression test for query-tools ensureDbOpen usage
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:23:54 -07:00
Tibsfox
ce6beb3000 test: add regression test for phantom milestone ghost detection
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:23:28 -07:00
Tibsfox
64d5232cc0 test: add regression test for needs-remediation revalidation guard
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:23:05 -07:00
Tibsfox
83822c51b3 test: add regression test for findMissingSummaries closed-status exclusion
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:21:33 -07:00
Tibsfox
ba8f6a0be2 test: add regression test for findMissingSummaries closed-status exclusion
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 22:19:52 -07:00
github-actions[bot]
a1fb64a6ba release: v2.65.0 2026-04-07 04:25:48 +00:00
Jeremy McSpadden
97bd6bf0ee Merge pull request #3700 from jeremymcs/fix/notification-overlay-backdrop
fix(gsd): wrap notification messages and fit overlay to content
2026-04-06 23:05:27 -05:00
Jeremy
5b959648f9 test(gsd): add wrapText tests for notification overlay wrapping
Tests cover: short text, long wrapping, single-word truncation,
empty string, exact-fit, and word preservation across lines.
2026-04-06 22:52:46 -05:00
Jeremy
073a6dc546 fix(gsd): wrap long notification messages and fit overlay to content
Long messages now word-wrap onto continuation lines aligned with the
message start instead of being truncated with ellipsis. Overlay box
sizes to content height instead of padding to fill the viewport.
2026-04-06 22:49:14 -05:00
Tibsfox
f65f92cf76 fix(gsd): import all-done milestones as complete during DB migration
migrateHierarchyToDb imported milestones with all-done roadmap slices
as "active" when SUMMARY.md was missing. This let plan-milestone
overwrite already-completed work.

Now checks parsed roadmap slices — if all are done, imports as
"complete" even without SUMMARY.md.

Closes #3390
Closes #3379

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 20:07:42 -07:00
Tibsfox
5affaaf734 fix(gsd): allow milestone completion when validation skipped by preference
The completing-milestone dispatch guard blocked completion when
operational verification was planned but the validation was
intentionally skipped by a budget profile preference. The guard
now detects skip-by-preference markers in the validation content
and allows completion to proceed.

Closes #3399
Closes #3344

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 19:52:55 -07:00
Tibsfox
2d3723691a fix(gsd): set slice sequence at all three insertion sites
All slices got sequence=0 because the three code paths that insert
slices never set the sequence column. This made positional ordering
degenerate to alphabetical-by-ID, causing deadlocks when dependency-
free slices were ordered after blocked ones.

Now passes sequence at:
- plan-milestone: array index from agent-ordered params.slices
- reassess-roadmap: existingCount + index for newly added slices
- md-importer: parse order from roadmap content

Closes #3356

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 19:51:16 -07:00
Tibsfox
994fc15c9d fix(gsd): four prompt/runtime fixes for completion and session stability
1. complete-milestone: move gsd_requirement_update before
   gsd_complete_milestone so agents don't exit before updating
   requirement status (#3155)
2. complete-slice: use gsd_requirement_update instead of
   gsd_save_decision for requirement status transitions (#3154)
3. uncaughtException handler: log instead of re-throwing to prevent
   fatal double-fault that kills the session (#3163)
4. session_before_compact: only cancel during active auto-mode, not
   when paused — allows compaction during interactive work (#3165)

Closes #3155
Closes #3154
Closes #3163
Closes #3165

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-06 19:47:38 -07:00