singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #689 from jeremymcs/fix/visualizer-completedAt-date-coercion

Browse source 
fix: coerce completedAt to String in visualizer changelog sort
This commit is contained in:
TÂCHES 2026-03-16 14:18:09 -06:00 • committed by GitHub
commit 9838ef3781
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/resources/extensions/gsd/tests/visualizer-data.test.ts
View file

@ -165,6 +165,17 @@ assertTrue(
"VisualizerData has changelog field",
);
// completedAt must be coerced to String() to handle YAML Date objects (issue #644)
assertTrue(
dataSrc.includes("String(summary.frontmatter.completed_at"),
"completedAt assignment coerces to String() for YAML Date safety",
);
assertTrue(
dataSrc.includes("String(b.completedAt") && dataSrc.includes("String(a.completedAt"),
"changelog sort coerces completedAt to String() for YAML Date safety",
);
// Verify overlay source exists and imports data module
const overlayPath = join(__dirname, "..", "visualizer-overlay.ts");
const overlaySrc = readFileSync(overlayPath, "utf-8");

4
src/resources/extensions/gsd/visualizer-data.ts
View file

@ -379,7 +379,7 @@ async function loadChangelog(basePath: string, milestones: VisualizerMilestone[]
path: f.path,
description: f.description,
})),
completedAt: summary.frontmatter.completed_at ?? '',
completedAt: String(summary.frontmatter.completed_at ?? ''),
};
changelogCache.set(cacheKey, { mtime, entry });
@ -388,7 +388,7 @@ async function loadChangelog(basePath: string, milestones: VisualizerMilestone[]
}
// Sort by completedAt descending
entries.sort((a, b) => (b.completedAt || '').localeCompare(a.completedAt || ''));
entries.sort((a, b) => String(b.completedAt || '').localeCompare(String(a.completedAt || '')));
return { entries };
}