singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #690 from trek-e/fix/688-thinking-minimal-gpt5

Browse source 
fix: clamp 'minimal' thinking level to 'low' for gpt-5.x models (#688)
This commit is contained in:
TÂCHES 2026-03-16 14:17:51 -06:00 • committed by GitHub
commit e4d47de1f6
2 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/pi-ai/src/providers/azure-openai-responses.ts
View file

@ -15,6 +15,16 @@ import { AssistantMessageEventStream } from "../utils/event-stream.js";
import { convertResponsesMessages, convertResponsesTools, processResponsesStream } from "./openai-responses-shared.js";
import { buildBaseOptions, clampReasoning } from "./simple-options.js";
/**
* Clamp reasoning effort for models that don't support all levels.
* gpt-5.x models don't support "minimal" — map to "low".
*/
function clampReasoningForModel(modelName: string, effort: string): string {
const name = modelName.includes("/") ? modelName.split("/").pop()! : modelName;
if (name.startsWith("gpt-5") && effort === "minimal") return "low";
return effort;
}
const DEFAULT_AZURE_API_VERSION = "v1";
const AZURE_TOOL_CALL_PROVIDERS = new Set(["openai", "openai-codex", "opencode", "azure-openai-responses"]);
@ -234,8 +244,9 @@ function buildParams(
if (model.reasoning) {
if (options?.reasoningEffort || options?.reasoningSummary) {
const effort = clampReasoningForModel(model.name, options?.reasoningEffort || "medium") as typeof options.reasoningEffort;
params.reasoning = {
effort: options?.reasoningEffort || "medium",
effort: effort || "medium",
summary: options?.reasoningSummary || "auto",
};
params.include = ["reasoning.encrypted_content"];

13
packages/pi-ai/src/providers/openai-responses.ts
View file

@ -18,6 +18,16 @@ import { buildCopilotDynamicHeaders, hasCopilotVisionInput } from "./github-copi
import { convertResponsesMessages, convertResponsesTools, processResponsesStream } from "./openai-responses-shared.js";
import { buildBaseOptions, clampReasoning } from "./simple-options.js";
/**
* Clamp reasoning effort for models that don't support all levels.
* gpt-5.x models don't support "minimal" — map to "low".
*/
function clampReasoningForModel(modelName: string, effort: string): string {
const name = modelName.includes("/") ? modelName.split("/").pop()! : modelName;
if (name.startsWith("gpt-5") && effort === "minimal") return "low";
return effort;
}
const OPENAI_TOOL_CALL_PROVIDERS = new Set(["openai", "openai-codex", "opencode"]);
/**
@ -215,8 +225,9 @@ function buildParams(model: Model<"openai-responses">, context: Context, options
if (model.reasoning) {
if (options?.reasoningEffort || options?.reasoningSummary) {
const effort = clampReasoningForModel(model.name, options?.reasoningEffort || "medium") as typeof options.reasoningEffort;
params.reasoning = {
effort: options?.reasoningEffort || "medium",
effort: effort || "medium",
summary: options?.reasoningSummary || "auto",
};
params.include = ["reasoning.encrypted_content"];