singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test(gsd): align hasImplementationArtifacts tests with string return type

Browse source 
The function signature changed from boolean to "present" | "absent" |
"unknown" but three test assertions still compared against true/false.

Update assertions to match the new return type.
This commit is contained in:
Jeremy 2026-04-07 17:20:37 -05:00
parent 5cfc865040
commit 4fdce5d179
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/resources/extensions/gsd/tests/integration/auto-recovery.test.ts
View file

@ -684,7 +684,7 @@ function makeGitBase(): string {
return base;
}
test("hasImplementationArtifacts returns false when only .gsd/ files committed (#1703)", (t) => {
test("hasImplementationArtifacts returns 'absent' when only .gsd/ files committed (#1703)", (t) => {
const base = makeGitBase();
t.after(() => cleanup(base));
@ -697,10 +697,10 @@ test("hasImplementationArtifacts returns false when only .gsd/ files committed (
execFileSync("git", ["commit", "-m", "chore: add plan files"], { cwd: base, stdio: "ignore" });
const result = hasImplementationArtifacts(base);
assert.equal(result, false, "should return false when only .gsd/ files were committed");
assert.equal(result, "absent", "should return 'absent' when only .gsd/ files were committed");
});
test("hasImplementationArtifacts returns true when implementation files committed (#1703)", (t) => {
test("hasImplementationArtifacts returns 'present' when implementation files committed (#1703)", (t) => {
const base = makeGitBase();
t.after(() => cleanup(base));
@ -714,16 +714,16 @@ test("hasImplementationArtifacts returns true when implementation files committe
execFileSync("git", ["commit", "-m", "feat: add feature"], { cwd: base, stdio: "ignore" });
const result = hasImplementationArtifacts(base);
assert.equal(result, true, "should return true when implementation files are present");
assert.equal(result, "present", "should return 'present' when implementation files are present");
});
test("hasImplementationArtifacts returns true on non-git directory (fail-open)", (t) => {
test("hasImplementationArtifacts returns 'unknown' on non-git directory (fail-open)", (t) => {
const base = join(tmpdir(), `gsd-test-nogit-${randomUUID()}`);
mkdirSync(base, { recursive: true });
t.after(() => cleanup(base));
const result = hasImplementationArtifacts(base);
assert.equal(result, true, "should return true (fail-open) in non-git directory");
assert.equal(result, "unknown", "should return 'unknown' (fail-open) in non-git directory");
});
// ─── verifyExpectedArtifact: complete-milestone requires impl artifacts (#1703) ──