From 4fdce5d1796141b37be5afbe86e55f1725601866 Mon Sep 17 00:00:00 2001 From: Jeremy Date: Tue, 7 Apr 2026 17:20:37 -0500 Subject: [PATCH] test(gsd): align hasImplementationArtifacts tests with string return type The function signature changed from boolean to "present" | "absent" | "unknown" but three test assertions still compared against true/false. Update assertions to match the new return type. --- .../gsd/tests/integration/auto-recovery.test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/resources/extensions/gsd/tests/integration/auto-recovery.test.ts b/src/resources/extensions/gsd/tests/integration/auto-recovery.test.ts index 11f5a3d48..610f4d442 100644 --- a/src/resources/extensions/gsd/tests/integration/auto-recovery.test.ts +++ b/src/resources/extensions/gsd/tests/integration/auto-recovery.test.ts @@ -684,7 +684,7 @@ function makeGitBase(): string { return base; } -test("hasImplementationArtifacts returns false when only .gsd/ files committed (#1703)", (t) => { +test("hasImplementationArtifacts returns 'absent' when only .gsd/ files committed (#1703)", (t) => { const base = makeGitBase(); t.after(() => cleanup(base)); @@ -697,10 +697,10 @@ test("hasImplementationArtifacts returns false when only .gsd/ files committed ( execFileSync("git", ["commit", "-m", "chore: add plan files"], { cwd: base, stdio: "ignore" }); const result = hasImplementationArtifacts(base); - assert.equal(result, false, "should return false when only .gsd/ files were committed"); + assert.equal(result, "absent", "should return 'absent' when only .gsd/ files were committed"); }); -test("hasImplementationArtifacts returns true when implementation files committed (#1703)", (t) => { +test("hasImplementationArtifacts returns 'present' when implementation files committed (#1703)", (t) => { const base = makeGitBase(); t.after(() => cleanup(base)); @@ -714,16 +714,16 @@ test("hasImplementationArtifacts returns true when implementation files committe execFileSync("git", ["commit", "-m", "feat: add feature"], { cwd: base, stdio: "ignore" }); const result = hasImplementationArtifacts(base); - assert.equal(result, true, "should return true when implementation files are present"); + assert.equal(result, "present", "should return 'present' when implementation files are present"); }); -test("hasImplementationArtifacts returns true on non-git directory (fail-open)", (t) => { +test("hasImplementationArtifacts returns 'unknown' on non-git directory (fail-open)", (t) => { const base = join(tmpdir(), `gsd-test-nogit-${randomUUID()}`); mkdirSync(base, { recursive: true }); t.after(() => cleanup(base)); const result = hasImplementationArtifacts(base); - assert.equal(result, true, "should return true (fail-open) in non-git directory"); + assert.equal(result, "unknown", "should return 'unknown' (fail-open) in non-git directory"); }); // ─── verifyExpectedArtifact: complete-milestone requires impl artifacts (#1703) ──