ci(android): quote Firebase secrets in workflows, store tokens in OpenBao
- Adds quotes around FIREBASE_APP_ID and FIREBASE_CI_TOKEN in workflow steps to handle special characters safely. - Firebase CI token and App ID are now stored in OpenBao kv/android-signing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
parent
684ac9597d
commit
d1b2bd7450
2 changed files with 2 additions and 2 deletions
|
|
@ -80,7 +80,7 @@ jobs:
|
||||||
run: |
|
run: |
|
||||||
firebase appdistribution:distribute \
|
firebase appdistribution:distribute \
|
||||||
app/build/outputs/apk/fdroid/release/*.apk \
|
app/build/outputs/apk/fdroid/release/*.apk \
|
||||||
--app ${{ secrets.FIREBASE_APP_ID }} \
|
--app "${{ secrets.FIREBASE_APP_ID }}" \
|
||||||
--groups "oncall-testers" \
|
--groups "oncall-testers" \
|
||||||
--release-notes "Build ${{ github.ref_name }} from ${{ github.sha }}" \
|
--release-notes "Build ${{ github.ref_name }} from ${{ github.sha }}" \
|
||||||
--token "${{ secrets.FIREBASE_CI_TOKEN }}"
|
--token "${{ secrets.FIREBASE_CI_TOKEN }}"
|
||||||
|
|
|
||||||
|
|
@ -80,7 +80,7 @@ jobs:
|
||||||
run: |
|
run: |
|
||||||
firebase appdistribution:distribute \
|
firebase appdistribution:distribute \
|
||||||
app/build/outputs/apk/play/release/*.apk \
|
app/build/outputs/apk/play/release/*.apk \
|
||||||
--app ${{ secrets.FIREBASE_APP_ID }} \
|
--app "${{ secrets.FIREBASE_APP_ID }}" \
|
||||||
--groups "oncall-testers" \
|
--groups "oncall-testers" \
|
||||||
--release-notes "Build ${{ github.ref_name }} from ${{ github.sha }}" \
|
--release-notes "Build ${{ github.ref_name }} from ${{ github.sha }}" \
|
||||||
--token "${{ secrets.FIREBASE_CI_TOKEN }}"
|
--token "${{ secrets.FIREBASE_CI_TOKEN }}"
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue