From d1b2bd7450854921e59bd1f4aa9a526ccedb109d Mon Sep 17 00:00:00 2001 From: Mikael Hugo Date: Fri, 15 May 2026 03:55:40 +0200 Subject: [PATCH] ci(android): quote Firebase secrets in workflows, store tokens in OpenBao - Adds quotes around FIREBASE_APP_ID and FIREBASE_CI_TOKEN in workflow steps to handle special characters safely. - Firebase CI token and App ID are now stored in OpenBao kv/android-signing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .forgejo/workflows/build-fdroid-release.yml | 2 +- .forgejo/workflows/build-play-release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.forgejo/workflows/build-fdroid-release.yml b/.forgejo/workflows/build-fdroid-release.yml index e7fb19d7..0490fe30 100644 --- a/.forgejo/workflows/build-fdroid-release.yml +++ b/.forgejo/workflows/build-fdroid-release.yml @@ -80,7 +80,7 @@ jobs: run: | firebase appdistribution:distribute \ app/build/outputs/apk/fdroid/release/*.apk \ - --app ${{ secrets.FIREBASE_APP_ID }} \ + --app "${{ secrets.FIREBASE_APP_ID }}" \ --groups "oncall-testers" \ --release-notes "Build ${{ github.ref_name }} from ${{ github.sha }}" \ --token "${{ secrets.FIREBASE_CI_TOKEN }}" diff --git a/.forgejo/workflows/build-play-release.yml b/.forgejo/workflows/build-play-release.yml index ea2e6637..2669d142 100644 --- a/.forgejo/workflows/build-play-release.yml +++ b/.forgejo/workflows/build-play-release.yml @@ -80,7 +80,7 @@ jobs: run: | firebase appdistribution:distribute \ app/build/outputs/apk/play/release/*.apk \ - --app ${{ secrets.FIREBASE_APP_ID }} \ + --app "${{ secrets.FIREBASE_APP_ID }}" \ --groups "oncall-testers" \ --release-notes "Build ${{ github.ref_name }} from ${{ github.sha }}" \ --token "${{ secrets.FIREBASE_CI_TOKEN }}"