oncall-engine/engine/apps
Joey Orlando d568ad6707
few add responders patches (#3220)
# Which issue(s) this PR fixes

Closes https://github.com/grafana/support-escalations/issues/8143

Fix a few minor issues introduced in #3128:

- Fix slow `GET /users` internal API endpoint related to [this
change](https://github.com/grafana/oncall/blob/dev/engine/apps/api/views/user.py#L239)
- Fix slow `GET /teams` internal API endpoint. Introduced a `short`
query parameter that only invokes
`apps.schedules.ical_utils.get_oncall_users_for_multiple_schedules` when
`short=false`.
- Order results from `GET /teams` internal API endpoint by name
(ascending)
- Fix search issue when searching for teams in the add responders popup
window (this was strictly a frontend issue)
- CSS changes to add responders dropdown to fix lonnnggg results list:
  **Before**
<img width="377" alt="Screenshot 2023-10-31 at 10 06 20"
src="https://github.com/grafana/oncall/assets/9406895/246c7c3b-7bea-44a1-afec-a38144c2c2d1">
  **After**
<img width="444" alt="Screenshot 2023-10-31 at 10 48 12"
src="https://github.com/grafana/oncall/assets/9406895/b5602a22-c691-4dc7-bd3d-e4d6b76d04a0">



## Still todo

The `apps.schedules.ical_utils.get_oncall_users_for_multiple_schedules`
method is still very slow when an instance has a lot of users (ex.
`ops`). Ideally we should refactor this method to be more efficient
because we still need to call this method under some circumstances. Ex.
to populate this dropdown when Direct Paging a user (note that it didn't
finish loading here on `ops`):
<img width="1037" alt="Screenshot 2023-10-30 at 18 14 59"
src="https://github.com/grafana/oncall/assets/9406895/9d91a57c-5db8-4ff9-862a-cd3755f52690">



## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-10-31 11:18:33 -04:00
..
alerts address some minor direct paging backend issues (#3208) 2023-10-27 20:47:00 +00:00
api few add responders patches (#3220) 2023-10-31 11:18:33 -04:00
api_for_grafana_incident Add render_for_web information to alert group incident API (#3005) 2023-09-12 12:02:42 +00:00
auth_token Return API URL as part of status (#2791) 2023-08-22 17:17:26 +00:00
base WIP: Direct paging improvements (#3064) 2023-09-28 03:57:49 +00:00
email Minor formatting changes (#2641) 2023-07-26 14:45:44 +01:00
grafana_plugin Add labels implementation for integration (#3014) 2023-10-20 07:30:11 +00:00
heartbeat Use periodic task for heartbeats (#2723) 2023-08-10 02:25:00 +00:00
integrations Fixing ratelimit texts 2023-09-27 14:18:00 +03:00
labels Add labels implementation for integration (#3014) 2023-10-20 07:30:11 +00:00
metrics_exporter Fix metrics and dashboard (#2895) 2023-08-29 13:52:24 +00:00
mobile_app "Going oncall" notification settings (#3187) 2023-10-30 13:44:18 +00:00
oss_installation Minor formatting changes (#2641) 2023-07-26 14:45:44 +01:00
phone_notifications Re-enable a few mypy rules + fix existing errors (#2725) 2023-08-03 09:43:03 +00:00
public_api add support for datetime on final_shifts API parameters (#3103) 2023-10-30 12:00:39 +00:00
schedules Upgrade to django 4.2.6 and other deps updates (#3176) 2023-10-27 18:45:00 +00:00
slack fix RBAC authz issue for Slack Alert Group actions (#3213) 2023-10-30 09:48:54 -04:00
social_auth Upgrade to django 4.2.6 and other deps updates (#3176) 2023-10-27 18:45:00 +00:00
telegram Fix "Replied message not found" Telegram bug (#3013) 2023-09-12 15:55:13 +00:00
twilioapp Minor formatting changes (#2641) 2023-07-26 14:45:44 +01:00
user_management Upgrade to django 4.2.6 and other deps updates (#3176) 2023-10-27 18:45:00 +00:00
webhooks Allow deletion for removed presets (#3072) 2023-09-27 10:21:55 -06:00
zvonok Minor formatting changes (#2641) 2023-07-26 14:45:44 +01:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00