centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make usernames unique in tests (#3310)

Browse source 
Some tests (particularly when there are schedules and shifts involved)
depend on generated usernames being unique (we randomly get [CI
errors](https://github.com/grafana/oncall/actions/runs/6812435056/job/18524768961#step:5:676)
because of this). Although username field is not required to be unique,
I think it makes sense for testing purposes to enable this (and when a
duplicated username is needed in a test, make that explicit).
This commit is contained in:
Matias Bordese 2023-11-09 11:30:28 -03:00 • committed by GitHub
parent dd348f01f9
commit e41ccb9d9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
engine/apps/user_management/tests/factories.py
View file

@ -14,7 +14,7 @@ class OrganizationFactory(factory.DjangoModelFactory):
class UserFactory(factory.DjangoModelFactory):
username = factory.Faker("user_name")
username = UniqueFaker("user_name")
email = factory.Faker("email")
user_id = UniqueFaker("pyint")
avatar_url = factory.Faker("url")