From e41ccb9d9b080389b04ff7c93f00f50da496f3ab Mon Sep 17 00:00:00 2001 From: Matias Bordese Date: Thu, 9 Nov 2023 11:30:28 -0300 Subject: [PATCH] Make usernames unique in tests (#3310) Some tests (particularly when there are schedules and shifts involved) depend on generated usernames being unique (we randomly get [CI errors](https://github.com/grafana/oncall/actions/runs/6812435056/job/18524768961#step:5:676) because of this). Although username field is not required to be unique, I think it makes sense for testing purposes to enable this (and when a duplicated username is needed in a test, make that explicit). --- engine/apps/user_management/tests/factories.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/apps/user_management/tests/factories.py b/engine/apps/user_management/tests/factories.py index c66099c0..b876c06e 100644 --- a/engine/apps/user_management/tests/factories.py +++ b/engine/apps/user_management/tests/factories.py @@ -14,7 +14,7 @@ class OrganizationFactory(factory.DjangoModelFactory): class UserFactory(factory.DjangoModelFactory): - username = factory.Faker("user_name") + username = UniqueFaker("user_name") email = factory.Faker("email") user_id = UniqueFaker("pyint") avatar_url = factory.Faker("url")