Fixes #882 — npm install -g gsd-pi installing a broken version where @gsd/pi-coding-agent cannot be resolved, causing ERR_MODULE_NOT_FOUND. Root causes addressed: 1. On Windows without Developer Mode or admin rights, symlinkSync fails even for NTFS junctions, leaving node_modules/@gsd/ empty and causing a cryptic ERR_MODULE_NOT_FOUND instead of a usable error message. 2. If npm latest dist-tag is stale (pointing to an old version that predates the packages/ directory), users get the same failure. Changes: - src/loader.ts: after symlinking, validate @gsd/pi-coding-agent exists; emit a clear actionable error with reinstall instructions instead of letting Node throw ERR_MODULE_NOT_FOUND deep inside cli.js. Also adds cpSync fallback when symlinkSync fails (Windows without elevated perms). - scripts/link-workspace-packages.cjs: same cpSync fallback — ensures postinstall succeeds on restricted Windows environments. - scripts/validate-pack.js: verify @gsd/* packages are resolvable after the isolated install test, and run `gsd -v` to confirm end-to-end resolution before declaring the pack valid. - .github/workflows/build-native.yml: add post-publish dist-tag verification step that confirms npm dist-tags.latest matches the published version for stable releases, catching stale-tag regressions in CI before users encounter them.
272 lines
10 KiB
YAML
272 lines
10 KiB
YAML
name: Build Native Binaries
|
|
|
|
on:
|
|
push:
|
|
tags:
|
|
- "v*"
|
|
workflow_dispatch:
|
|
inputs:
|
|
publish:
|
|
description: "Publish platform packages to npm"
|
|
required: false
|
|
default: "false"
|
|
type: choice
|
|
options:
|
|
- "false"
|
|
- "true"
|
|
|
|
jobs:
|
|
build:
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- os: macos-14
|
|
target: aarch64-apple-darwin
|
|
platform: darwin-arm64
|
|
- os: macos-14
|
|
target: x86_64-apple-darwin
|
|
platform: darwin-x64
|
|
- os: ubuntu-latest
|
|
target: x86_64-unknown-linux-gnu
|
|
platform: linux-x64-gnu
|
|
- os: ubuntu-latest
|
|
target: aarch64-unknown-linux-gnu
|
|
platform: linux-arm64-gnu
|
|
cross: true
|
|
- os: windows-latest
|
|
target: x86_64-pc-windows-msvc
|
|
platform: win32-x64-msvc
|
|
|
|
runs-on: ${{ matrix.os }}
|
|
name: Build ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- name: Install Rust toolchain
|
|
uses: dtolnay/rust-toolchain@stable
|
|
with:
|
|
targets: ${{ matrix.target }}
|
|
|
|
- name: Cache Rust build artifacts
|
|
uses: Swatinem/rust-cache@v2
|
|
with:
|
|
shared-key: native-${{ matrix.platform }}
|
|
workspaces: |
|
|
native -> target
|
|
|
|
- name: Install cross-compilation tools (Linux ARM64)
|
|
if: matrix.cross
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y gcc-aarch64-linux-gnu g++-aarch64-linux-gnu
|
|
|
|
- name: Build native addon
|
|
working-directory: native/crates/engine
|
|
env:
|
|
# CARGO_ENCODED_RUSTFLAGS overrides target-specific rustflags in
|
|
# .cargo/config.toml, which sets -C target-cpu=native for dev builds.
|
|
# CI must produce portable binaries.
|
|
CARGO_ENCODED_RUSTFLAGS: ""
|
|
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: ${{ matrix.cross && 'aarch64-linux-gnu-gcc' || '' }}
|
|
run: cargo build --release --target ${{ matrix.target }}
|
|
|
|
- name: Prepare artifact (Unix)
|
|
if: runner.os != 'Windows'
|
|
run: |
|
|
mkdir -p artifacts
|
|
cp native/target/${{ matrix.target }}/release/libgsd_engine.dylib artifacts/gsd_engine.node 2>/dev/null || \
|
|
cp native/target/${{ matrix.target }}/release/libgsd_engine.so artifacts/gsd_engine.node 2>/dev/null || \
|
|
{ echo "::error::No library found for ${{ matrix.platform }}"; exit 1; }
|
|
ls -la artifacts/
|
|
|
|
- name: Prepare artifact (Windows)
|
|
if: runner.os == 'Windows'
|
|
run: |
|
|
mkdir artifacts
|
|
copy native\target\${{ matrix.target }}\release\gsd_engine.dll artifacts\gsd_engine.node
|
|
|
|
- name: Upload artifact
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: native-${{ matrix.platform }}
|
|
path: artifacts/gsd_engine.node
|
|
if-no-files-found: error
|
|
|
|
publish:
|
|
needs: build
|
|
if: startsWith(github.ref, 'refs/tags/v') || github.event.inputs.publish == 'true'
|
|
runs-on: ubuntu-latest
|
|
name: Publish platform packages
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: "22"
|
|
registry-url: "https://registry.npmjs.org"
|
|
|
|
- name: Download all artifacts
|
|
uses: actions/download-artifact@v4
|
|
with:
|
|
path: artifacts
|
|
|
|
- name: Copy binaries to platform packages
|
|
run: |
|
|
for platform in darwin-arm64 darwin-x64 linux-x64-gnu linux-arm64-gnu win32-x64-msvc; do
|
|
cp "artifacts/native-${platform}/gsd_engine.node" "native/npm/${platform}/gsd_engine.node"
|
|
echo "Copied binary for ${platform}"
|
|
ls -la "native/npm/${platform}/"
|
|
done
|
|
|
|
- name: Sync platform package versions
|
|
run: node native/scripts/sync-platform-versions.cjs
|
|
|
|
- name: Detect prerelease version
|
|
id: version-check
|
|
run: |
|
|
VERSION=$(node -p "require('./package.json').version")
|
|
if echo "$VERSION" | grep -q '-next\.'; then
|
|
echo "is_prerelease=true" >> "$GITHUB_OUTPUT"
|
|
echo "tag_flag=--tag next" >> "$GITHUB_OUTPUT"
|
|
echo "Prerelease detected: ${VERSION} → publishing with --tag next"
|
|
else
|
|
echo "is_prerelease=false" >> "$GITHUB_OUTPUT"
|
|
echo "tag_flag=" >> "$GITHUB_OUTPUT"
|
|
echo "Stable release: ${VERSION} → publishing with --tag latest (default)"
|
|
fi
|
|
|
|
- name: Publish platform packages
|
|
env:
|
|
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
|
|
run: |
|
|
for platform in darwin-arm64 darwin-x64 linux-x64-gnu linux-arm64-gnu win32-x64-msvc; do
|
|
echo "Publishing @gsd-build/engine-${platform}..."
|
|
cd "native/npm/${platform}"
|
|
OUTPUT=$(npm publish --access public ${{ steps.version-check.outputs.tag_flag }} 2>&1) && echo "$OUTPUT" || {
|
|
if echo "$OUTPUT" | grep -q "cannot publish over the previously published"; then
|
|
echo "Already published, skipping"
|
|
else
|
|
echo "::error::Failed to publish ${platform}: $OUTPUT"
|
|
exit 1
|
|
fi
|
|
}
|
|
cd "$GITHUB_WORKSPACE"
|
|
done
|
|
|
|
- name: Wait for npm registry propagation
|
|
run: sleep 30
|
|
|
|
- name: Verify platform packages are published
|
|
run: |
|
|
VERSION=$(node -p "require('./package.json').version")
|
|
echo "Verifying platform packages at version ${VERSION}..."
|
|
FAILED=0
|
|
for platform in darwin-arm64 darwin-x64 linux-x64-gnu linux-arm64-gnu win32-x64-msvc; do
|
|
PKG="@gsd-build/engine-${platform}"
|
|
PUBLISHED=$(npm view "${PKG}@${VERSION}" version 2>/dev/null || echo "")
|
|
if [ "${PUBLISHED}" = "${VERSION}" ]; then
|
|
echo " ✓ ${PKG}@${VERSION}"
|
|
else
|
|
echo "::error::${PKG}@${VERSION} not found on npm (got: '${PUBLISHED}')"
|
|
FAILED=1
|
|
fi
|
|
done
|
|
if [ "${FAILED}" = "1" ]; then
|
|
echo "::error::One or more platform packages are missing from npm. Aborting main package publish to prevent broken installs."
|
|
exit 1
|
|
fi
|
|
echo "All platform packages verified."
|
|
|
|
- name: Install dependencies
|
|
run: npm ci
|
|
|
|
- name: Build
|
|
run: npm run build
|
|
|
|
- name: Verify dist exists
|
|
run: test -s dist/loader.js || { echo "::error::dist/loader.js missing or empty after build"; exit 1; }
|
|
|
|
- name: Validate package is installable
|
|
run: npm run validate-pack
|
|
|
|
- name: Publish main package
|
|
env:
|
|
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
|
|
run: |
|
|
# --ignore-scripts: skip prepublishOnly since we built explicitly above
|
|
OUTPUT=$(npm publish --ignore-scripts ${{ steps.version-check.outputs.tag_flag }} 2>&1) && echo "$OUTPUT" || {
|
|
if echo "$OUTPUT" | grep -q "cannot publish over the previously published\|You cannot publish over"; then
|
|
echo "Already published, skipping"
|
|
else
|
|
echo "$OUTPUT"
|
|
exit 1
|
|
fi
|
|
}
|
|
|
|
- name: Post-publish smoke test
|
|
run: |
|
|
VERSION=$(node -p "require('./package.json').version")
|
|
TMPDIR=$(mktemp -d)
|
|
cd "$TMPDIR"
|
|
npm init -y > /dev/null 2>&1
|
|
|
|
# Wait for npm registry to show the new version (metadata propagation)
|
|
echo "Waiting for gsd-pi@${VERSION} to appear on npm..."
|
|
for attempt in $(seq 1 20); do
|
|
PUBLISHED=$(npm view "gsd-pi@${VERSION}" version 2>/dev/null || echo "")
|
|
if [ "${PUBLISHED}" = "${VERSION}" ]; then
|
|
echo " ✓ Version ${VERSION} visible on npm (attempt ${attempt})"
|
|
break
|
|
fi
|
|
if [ "$attempt" = "20" ]; then
|
|
echo "::warning::gsd-pi@${VERSION} not visible on npm after 5 minutes — skipping smoke test"
|
|
exit 0
|
|
fi
|
|
sleep 15
|
|
done
|
|
|
|
# Now install and verify
|
|
echo "Installing gsd-pi@${VERSION}..."
|
|
for attempt in 1 2 3; do
|
|
if npm install "gsd-pi@${VERSION}" 2>&1 | tee /tmp/install-output.txt; then
|
|
echo " ✓ Install succeeded"
|
|
# Run version check via node directly (npx may resolve wrong binary)
|
|
# Strip ANSI escape codes and match version on any line (--version prints a banner)
|
|
RAW=$(node node_modules/gsd-pi/dist/loader.js --version 2>&1 || echo "FAILED")
|
|
ACTUAL=$(echo "$RAW" | sed 's/\x1b\[[0-9;]*m//g' | grep -oE "^${VERSION}$" | head -1)
|
|
if [ "$ACTUAL" = "$VERSION" ]; then
|
|
echo " ✓ gsd --version = ${VERSION}"
|
|
echo "Published package is functional"
|
|
exit 0
|
|
else
|
|
echo "::error::Version mismatch: expected ${VERSION} in output:"
|
|
echo "$RAW"
|
|
exit 1
|
|
fi
|
|
fi
|
|
echo "Install attempt ${attempt}/3 failed, retrying in 15s..."
|
|
cat /tmp/install-output.txt
|
|
sleep 15
|
|
done
|
|
echo "::error::Smoke test failed — gsd-pi@${VERSION} not installable"
|
|
exit 1
|
|
|
|
- name: Verify dist-tag after publish
|
|
if: steps.version-check.outputs.is_prerelease == 'false'
|
|
run: |
|
|
VERSION=$(node -p "require('./package.json').version")
|
|
echo "Verifying npm dist-tag 'latest' points to ${VERSION}..."
|
|
for attempt in $(seq 1 10); do
|
|
LATEST=$(npm view gsd-pi dist-tags.latest 2>/dev/null || echo "")
|
|
if [ "${LATEST}" = "${VERSION}" ]; then
|
|
echo " ✓ npm dist-tags.latest = ${VERSION}"
|
|
exit 0
|
|
fi
|
|
echo " Attempt ${attempt}/10: latest=${LATEST}, expected=${VERSION}, retrying in 15s..."
|
|
sleep 15
|
|
done
|
|
echo "::error::dist-tags.latest is '${LATEST}' but expected '${VERSION}' — run: npm dist-tag add gsd-pi@${VERSION} latest"
|
|
exit 1
|