c6093b4bbd
Fixes identified by comprehensive state machine validation: - M12: reopen-task/slice now deletes SUMMARY.md from disk, preventing the DB-filesystem reconciler from auto-correcting tasks back to "complete" — reopen was previously a no-op when artifacts existed - H4: add 30s hard timeout to unitPromise via Promise.race — prevents permanent hang if supervision fails to resolve agent_end - H5: add handleReopenMilestone — milestone completion was irrevocable - H6: pass ID as title when auto-creating phantom parent entities - H7: guard loadRegistry() against missing/corrupt registry.json - M4: report_blocker replay now sets blocker_discovered flag via new setTaskBlockerDiscovered() DB function - M5: insertVerificationEvidence uses INSERT OR IGNORE with unique index on (task_id, slice_id, milestone_id, command, verdict) - M11: complete-slice rollback preserves original status instead of hardcoding "pending" - M14: deriveWorkflowAction shows contextual labels for blocked, paused, validating-milestone, completing-milestone, needs-discussion, and replanning-slice phases instead of generic "Continue" Includes 86 regression tests (49 unit + 37 integration) validating every phase transition, completion guard, and edge case. Closes #3161
107 lines
4.1 KiB
TypeScript
107 lines
4.1 KiB
TypeScript
/**
|
|
* Pure derivation of the primary workflow action based on workspace state.
|
|
* No React dependencies — fully testable with plain imports.
|
|
*/
|
|
|
|
export interface WorkflowActionInput {
|
|
phase: string
|
|
autoActive: boolean
|
|
autoPaused: boolean
|
|
onboardingLocked: boolean
|
|
commandInFlight: string | null
|
|
bootStatus: string
|
|
hasMilestones: boolean
|
|
/** When set, suppresses the action bar if the welcome screen is handling initialization. */
|
|
projectDetectionKind?: string | null
|
|
}
|
|
|
|
export interface WorkflowAction {
|
|
label: string
|
|
command: string
|
|
variant: "default" | "destructive"
|
|
}
|
|
|
|
export interface WorkflowActionResult {
|
|
primary: WorkflowAction | null
|
|
secondaries: { label: string; command: string }[]
|
|
disabled: boolean
|
|
disabledReason?: string
|
|
/** When true, the action represents the all-milestones-complete "New Milestone" state. */
|
|
isNewMilestone: boolean
|
|
}
|
|
|
|
export function deriveWorkflowAction(input: WorkflowActionInput): WorkflowActionResult {
|
|
const { phase, autoActive, autoPaused, onboardingLocked, commandInFlight, bootStatus, hasMilestones, projectDetectionKind } = input
|
|
|
|
// When the project welcome screen is active, it handles the initialization CTA.
|
|
// Suppress the action bar to avoid duplicate/confusing buttons.
|
|
if (
|
|
projectDetectionKind &&
|
|
projectDetectionKind !== "active-gsd" &&
|
|
projectDetectionKind !== "empty-gsd"
|
|
) {
|
|
return { primary: null, secondaries: [], disabled: true, disabledReason: "Project setup pending", isNewMilestone: false }
|
|
}
|
|
|
|
// Determine disabled state and reason
|
|
let disabled = false
|
|
let disabledReason: string | undefined
|
|
|
|
if (commandInFlight !== null) {
|
|
disabled = true
|
|
disabledReason = "Command in progress"
|
|
} else if (bootStatus !== "ready") {
|
|
disabled = true
|
|
disabledReason = "Workspace not ready"
|
|
} else if (onboardingLocked) {
|
|
disabled = true
|
|
disabledReason = "Setup required"
|
|
}
|
|
|
|
// Derive primary action
|
|
let primary: WorkflowAction | null = null
|
|
const secondaries: { label: string; command: string }[] = []
|
|
let isNewMilestone = false
|
|
|
|
if (autoActive && !autoPaused) {
|
|
primary = { label: "Stop Auto", command: "/gsd stop", variant: "destructive" }
|
|
} else if (autoPaused) {
|
|
primary = { label: "Resume Auto", command: "/gsd auto", variant: "default" }
|
|
} else {
|
|
// Auto is not active
|
|
if (phase === "complete") {
|
|
// All milestones done — surface a distinct "New Milestone" action
|
|
primary = { label: "New Milestone", command: "/gsd", variant: "default" }
|
|
isNewMilestone = true
|
|
} else if (phase === "planning") {
|
|
primary = { label: "Plan", command: "/gsd", variant: "default" }
|
|
} else if (phase === "executing" || phase === "summarizing") {
|
|
primary = { label: "Start Auto", command: "/gsd auto", variant: "default" }
|
|
} else if (phase === "pre-planning" && !hasMilestones) {
|
|
primary = { label: "Initialize Project", command: "/gsd", variant: "default" }
|
|
} else if (phase === "blocked") {
|
|
primary = { label: "Blocked", command: "/gsd", variant: "default" }
|
|
disabled = true
|
|
disabledReason = "Project is blocked — check blockers"
|
|
} else if (phase === "paused") {
|
|
primary = { label: "Resume", command: "/gsd auto", variant: "default" }
|
|
} else if (phase === "validating-milestone") {
|
|
primary = { label: "Validate", command: "/gsd", variant: "default" }
|
|
} else if (phase === "completing-milestone") {
|
|
primary = { label: "Complete Milestone", command: "/gsd", variant: "default" }
|
|
} else if (phase === "needs-discussion") {
|
|
primary = { label: "Discuss", command: "/gsd", variant: "default" }
|
|
} else if (phase === "replanning-slice") {
|
|
primary = { label: "Replan", command: "/gsd", variant: "default" }
|
|
} else {
|
|
primary = { label: "Continue", command: "/gsd", variant: "default" }
|
|
}
|
|
|
|
// Add "Step" secondary when auto is not active (not for new milestone — no step concept there)
|
|
if (primary.command !== "/gsd next" && !isNewMilestone) {
|
|
secondaries.push({ label: "Step", command: "/gsd next" })
|
|
}
|
|
}
|
|
|
|
return { primary, secondaries, disabled, disabledReason, isNewMilestone }
|
|
}
|