* fix(worktree): recurse into tasks/ when syncing slice artifacts back to project root (#1678)
syncWorktreeStateBack() only processed files directly in each slice
directory, silently skipping the tasks/ subdirectory. Task-level
summaries (T01-SUMMARY.md, T02-SUMMARY.md, etc.) were therefore never
copied from the worktree back to the project root before teardown,
causing data loss when the worktree was removed on milestone completion.
Fix: detect the tasks/ directory entry in the inner loop and recurse
into it, copying all .md files and appending them to the synced list.
Consistent with how syncStateToProjectRoot() already uses recursive
copy via safeCopyRecursive().
Adds regression test (case 8 in worktree-sync-milestones.test.ts)
covering slice-level and task-level summary sync.
* feat(cleanup): add ~/.gsd/projects/ orphan detection and pruning
Introduces a complete lifecycle management story for the external project
state directory (~/.gsd/projects/<hash>/). Previously these directories
accumulated indefinitely with no mechanism to identify or remove them
after a repo was deleted or moved.
Changes:
repo-identity.ts
- Write `repo-meta.json` into each external state dir on first open
(and backfill on any subsequent open if the file is missing).
- Records: version, hash (dir name), gitRoot, remoteUrl, createdAt.
- Non-fatal: metadata write failure never blocks project setup.
- Export `readRepoMeta()` and `RepoMeta` interface for consumers.
doctor-types.ts
- Add `orphaned_project_state` to DoctorIssueCode.
- Add `GLOBAL_STATE_CODES` set — codes that must never be auto-fixed
at fixLevel=task (post-task automated health checks must not delete
project state directories).
doctor-checks.ts
- Add `checkGlobalHealth()` — scans ~/.gsd/projects/, reads repo-meta.json
from each dir, reports info-severity issue for any whose gitRoot is gone.
- Auto-fixable with --fix; skipped entirely at fixLevel=task.
doctor.ts
- Import and call `checkGlobalHealth` after `checkRuntimeHealth`.
- Gate on `GLOBAL_STATE_CODES` in `shouldFix` at task fixLevel.
commands-maintenance.ts
- Add `handleCleanupProjects(args, ctx)` — interactive audit command.
- Categorises dirs as active / orphaned / unknown (no metadata yet).
- Without --fix: prints full report with per-dir gitRoot + remoteUrl.
- With --fix: deletes orphaned dirs, reports removed/failed counts.
commands/handlers/ops.ts
- Route `cleanup projects` and `cleanup projects --fix` to handler.
commands/catalog.ts
- Add `projects` and `projects --fix` to cleanup tab-completions.
* feat(cleanup): add metrics.json bloat detection and pruning
The metrics ledger has no TTL and grows by one entry per completed unit —
~1-2 KB/entry with no ceiling. On a busy project (50 units/day) this
reaches 4-9 MB in 90 days and continues growing indefinitely.
Changes:
metrics.ts
- Add pruneMetricsLedger(base, keepCount): trims oldest entries from the
head of the units array, keeping the newest `keepCount`. Updates both
the on-disk file and the in-memory ledger if a session is active.
doctor-types.ts
- Add "metrics_ledger_bloat" to DoctorIssueCode.
doctor-checks.ts (checkRuntimeHealth)
- Add metrics ledger bloat check after the existing integrity check.
- Threshold: 2000 units / fires as "warning".
- Fix: prune to newest 1500 entries via pruneMetricsLedger().
- Reports both the unit count and file size in MB in the issue message.
* fix cleanup project-state path and repo-meta refresh
* fix: prevent parallel worktree path resolution from escaping to home directory
When .gsd is a symlink into ~/.gsd/projects/<hash> (the default layout),
parallel workers resolve their cwd through the symlink. findWorktreeSegment()
then matches /.gsd/ at the user-level ~/.gsd boundary instead of the project
.gsd, causing resolveProjectRoot() to return ~ as the project root.
This corrupts ~/.gsd, creates ~/.git, and crashes pi.
Fix (3 layers):
1. Pass GSD_PROJECT_ROOT env var from coordinator to workers — the
coordinator already knows the real basePath unambiguously.
2. In resolveProjectRoot(), detect when the candidate root's .gsd
matches the user-level ~/.gsd and fall back to reading the worktree's
.git file (gitdir: pointer) to recover the real project root.
3. Existing validateDirectory() already blocks ~ — but the bug bypassed
it because the worktree path itself was 'safe'.
Also fixes the existing test that asserted the buggy behavior as correct.
Closesgsd-build/gsd-2#1676
* fix worktree root resolution for deep symlink paths
---------
Co-authored-by: Vojtěch Šplíchal <splichal@gmail.com>
* fix: prune stale env-utils.js from extensions root, preventing startup load error
- Move env-utils.ts from extensions/ root into gsd/ subdirectory
- Update all import paths to reflect new location
- Add manifest-based tracking in resource-loader to record which root-level
extension files are installed, so future upgrades can detect and prune files
that get removed or relocated (preventing recurrence)
- Add known-stale fallback for pre-manifest upgrades (explicitly removes
env-utils.js which was moved into gsd/ in this release)
- Remove re-export block from auto.ts that referenced relocated symbols
- Clean up session_start handler in native-search.ts (remove provider diagnostics
that were duplicating info already shown by model_select)
- Update welcome-screen layout to two-panel bar design for visual consistency
* fix: resolve PR1655 extension load and compile regressions
* fix: remove duplicate _clearGsdRootCache export
* fix: restore native-search session_start diagnostics
* fix(gsd extension): detect initialized projects in health widget
Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.
* fix(gsd extension): detect initialized projects in health widget
Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.
* feat: add Skill tool resolution for Pi agent
Expose a built-in Skill tool so dispatched prompts can resolve skill names without guessing file paths. This aligns runtime behavior with skill activation prompts and adds coverage for exact activation and unknown-skill handling.
Replaces the rounded box-corner two-panel layout (╭╮╰╯) with full-width
cyan ─ bars at top and bottom, matching the auto-mode progress widget's
ui.bar() style exactly. The inner │ divider and ├─ section separators are
kept (dimmed) so the two-panel logo/info layout is preserved.
Changes:
- Top/bottom borders: chalk.cyan('─'.repeat(termWidth)) — same as widget ui.bar()
- Outer vertical box borders removed; inner │ divider kept as dim separator
- Section dividers changed to dim ├──── style
- Trailing spaces removed from hint/version strings (no closing │ to pad against)
- Panel width formula updated: 1 + LEFT_INNER + 1 + RIGHT_INNER = termWidth
* feat: surface real doctor issue details in progress score widget
Previously the progress score traffic light (green/yellow/red) only
showed generic labels like "2 consecutive error units" or "Health
trend declining". The actual doctor issue descriptions were computed
in auto-post-unit but discarded before reaching the widget — only
aggregate counts were stored in HealthSnapshot.
Now the full data flows through:
- HealthSnapshot stores issue details (code, message, severity,
unitId) and fix descriptions alongside the counts
- recordHealthSnapshot() accepts optional issue/fix arrays
(backwards compatible — existing callers unchanged)
- getLatestHealthIssues() and getLatestHealthFixes() retrieve the
most recent details for display
- computeProgressScore() surfaces up to 5 real issue messages
(errors first) and up to 3 recent fixes as ProgressSignals
when the level is yellow or red
- Dashboard overlay renders signal details with ✓/✗/· icons
below the traffic light when degraded
This gives real-time visibility into what the auto-doctor is
detecting and fixing, without requiring manual /gsd doctor runs
or opening the full dashboard to investigate.
* feat: integrate doctor health data into visualizer and HTML reports
Phase 2b: close visibility gaps across visualizer and export surfaces.
Persistence (doctor.ts):
- Enrich DoctorHistoryEntry with issue details (severity, code,
message, unitId) and fix descriptions
- appendDoctorHistory now persists up to 10 issues per entry and
all fix descriptions to doctor-history.jsonl
- Export DoctorHistoryEntry type for consumers
Data layer (visualizer-data.ts):
- Add VisualizerDoctorEntry and VisualizerProgressScore types
- Extend HealthInfo with doctorHistory (last 20 persisted entries)
and progressScore (current in-memory traffic light)
- loadHealth reads doctor-history.jsonl synchronously and snapshots
current progress score when health data exists
TUI visualizer (visualizer-views.ts):
- Health tab now shows "Progress Score" section with traffic light
icon, summary, and all signal details (✓/✗/· prefixed)
- Health tab now shows "Doctor History" section with timestamped
entries, issue messages, and applied fixes
HTML export (export-html.ts):
- Health section includes progress score with colored indicator
and signal breakdown
- Health section includes "Doctor Run History" table with
timestamps, error/warning/fix counts, issue codes, expandable
issue messages, and fix descriptions
* feat: fill remaining health gaps — scope tagging, level notifications, human-readable logs
Gap fills:
Per-milestone/slice scope tagging:
- HealthSnapshot now stores scope (e.g. "M001/S02") from the
doctor run's unit context
- DoctorHistoryEntry persists scope to doctor-history.jsonl
- Visualizer and HTML reports display scope tags per entry
State transition notifications:
- setLevelChangeCallback() registers a handler for progress level
changes (green→yellow, yellow→red, red→green, etc.)
- auto-start.ts wires the callback to ctx.ui.notify on start
- auto.ts clears it on stop
- Notifications include the triggering issue message
Human-readable formatting throughout:
- formatHealthSummary() uses full words: "2 errors, 3 warnings ·
trend degrading · 1 fix applied · 1 of 5 consecutive errors
before escalation · latest: Missing PLAN.md for S03"
- DoctorHistoryEntry stores a human-readable summary field
built from error counts, fix counts, and top issue message
- Visualizer doctor history shows summary instead of "2E 1W 0F"
- HTML export doctor table uses summary column with scope tags
- Post-unit notification says what was fixed ("Doctor: rebuilt
STATE.md; cleared stale lock") instead of "applied 2 fix(es)"
Test updates:
- formatHealthSummary assertions updated for new readable format
* fix: default UAT type to artifact-driven to prevent unnecessary auto-mode pauses (#1651)
When a UAT file has no `## UAT Type` section, `extractUatType()` returns
`undefined`. The fallback was `"human-experience"`, causing `pauseAfterDispatch:
true` in the auto-dispatch rule. Since doctor-generated UAT placeholders never
include a UAT Type section and LLM-executed UATs are always artifact-driven,
the correct default is `"artifact-driven"`.
Closes#1649
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: remove duplicate doctorScope declaration (CI build fix)
* fix: resolve PR1644 regressions in health views and post-unit hook
---------
Co-authored-by: TÂCHES <afromanguy@me.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* refactor: add PhaseResult/IterationContext/LoopState types to auto-loop
No behavioral changes. Pure type additions for upcoming phase extraction.
* refactor: extract runFinalize() from autoLoop body
No behavioral changes. Pure structural extraction.
* refactor: extract runUnitPhase() from autoLoop body
No behavioral changes. Pure structural extraction.
* refactor: extract runGuards() from autoLoop body
No behavioral changes. Pure structural extraction.
* refactor: extract runDispatch() from autoLoop body
No behavioral changes. Pure structural extraction.
* refactor: extract runPreDispatch() from autoLoop body
No behavioral changes. Pure structural extraction.
Completes autoLoop pipeline phase decomposition:
runPreDispatch → runGuards → runDispatch → runUnitPhase → runFinalize
* refactor: hoist loopState before autoLoop loop, drop sync-back hacks
loopState was created inside the loop each iteration, requiring 3 manual
sync-backs for stuckRecoveryAttempts (number copy-by-value). Hoist it
before the loop so it's a true persistent mutable struct across iterations.
The forensics prompt listed only 5 source files and told the agent to
"analyze the report." This led to shallow analysis and hallucinated
paths because the agent had no knowledge of the source layout, runtime
paths, activity log format, or crash lock structure.
The rewritten prompt gives the forensics agent a complete source map
organized by domain, the full .gsd/ directory structure, data format
references for activity logs / crash locks / metrics, and a step-by-step
investigation protocol that requires tracing from symptom to specific
file:line in GSD source before filing an issue.
Closes#1656
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The forensics prompt references "activity logs" in natural language but
never provides the actual filesystem paths. This causes the LLM agent to
hallucinate paths like `activity-logs/` when it needs to inspect raw JSONL
logs beyond the pre-parsed forensic data.
Adds a "Key Runtime Paths" section with concrete `.gsd/` paths for
activity logs, debug logs, runtime state, crash lock, completed units,
and forensics reports.
Closes#1652
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The progress widget's render() synchronously accesses sessionManager
state via cmdCtx. When newSession() is in-flight, this can block the
TUI input loop, freezing the terminal. Guard render() to return the
last cached frame while a session switch is in progress.
Closes#1653
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Refactor GSD command/bootstrap modules
* fix: resolve TypeScript build errors in refactored db-tools and catalog
- db-tools.ts: add missing execute callback params (signal, onUpdate, ctx),
remove isError from return objects (not in AgentToolResult type), cast
details as any to avoid union type mismatch across error/success paths
- catalog.ts: use Object.entries() on TemplateRegistry.templates Record
instead of treating it as an array, use Record key as template id
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: update source-contract tests to reference refactored file locations
The god-file refactor moved code from index.ts and commands.ts into
bootstrap/agent-end-recovery.ts, bootstrap/register-hooks.ts, and
commands/handlers/core.ts. Update three test files to read from the
correct paths and adjust pattern assertions to match the new code
structure.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When a UAT file has no `## UAT Type` section, `extractUatType()` returns
`undefined`. The fallback was `"human-experience"`, causing `pauseAfterDispatch:
true` in the auto-dispatch rule. Since doctor-generated UAT placeholders never
include a UAT Type section and LLM-executed UATs are always artifact-driven,
the correct default is `"artifact-driven"`.
Closes#1649
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When a unit spawns background jobs via async_bash, job completion callbacks
fire follow-up messages after agent_end has resolved. The auto-loop has
moved on but the previous session's LLM processes these follow-ups, adding
12-45s of wasted time and ~14 unnecessary turns per unit.
Two complementary fixes:
1. Cancel all running background jobs on session_before_switch so
completion callbacks never fire for the old session.
2. Clear the follow-up queue after runUnit() completes as defense-in-depth,
discarding any already-queued notifications before the next session starts.
Closes#1642
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(gsd extension): detect initialized projects in health widget
Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.
* fix(gsd extension): detect initialized projects in health widget
Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.
* feat(gsd): activate matching skills in dispatched prompts
Inject skill activations from installed skills, preferences, and task-plan handoff so GSD agents load the right skills automatically instead of relying on generic guidance. Align prompt templates and tests with the activation flow and current resource sync behavior.
* fix(gsd extension): detect initialized projects in health widget
Use .gsd presence plus project-state detection for the health widget so bootstrapped projects no longer appear as unloaded before metrics exist.
* fix(gsd extension): restore health widget build paths
* test(resource-loader): fix sibling cleanup assertion
When a milestone has a roadmap with unchecked slice checkboxes AND a
summary file, deriveState() incorrectly treated it as incomplete. The
summary check only ran inside the `if (isMilestoneComplete(roadmap))`
branch, so it was never reached when checkboxes weren't ticked.
This caused auto-mode to pick an already-completed milestone as active,
ignoring the actual current milestone entirely.
The fix adds summary-existence checks to all three resolution paths:
1. `getActiveMilestoneId()` — now checks for summary before returning
a milestone as incomplete
2. Phase 1 pre-scan in `deriveState()` — now adds milestones with
unchecked roadmaps + summaries to `completeMilestoneIds`
3. Phase 2 registry builder — now checks for summary before falling
through to the active/pending logic
This is consistent with the existing principle that the summary is the
terminal artifact (#864), which was already stated in a comment but not
enforced for the unchecked-roadmap case.
Adds two tests:
- Unchecked roadmap + summary → status is 'complete', next milestone
is active
- Unchecked roadmap + summary satisfies depends_on for downstream
milestones
Two targeted fixes that close the three remaining paths where .gsd/
tracked files can still be silently deleted after the v2.36.0 fix.
--- Path 1: hasGitTrackedGsdFiles fails open on git error (gitignore.ts)
nativeLsFiles() swallows git failures via allowFailure=true and returns
[], making hasGitTrackedGsdFiles() indistinguishable between "nothing
tracked" and "git failed". On any transient git failure (locked index,
binary not on PATH, corrupted .git/index), the function returned false
and .gsd was added to .gitignore, deleting all tracked state.
Fix: after nativeLsFiles returns [], verify git is reachable with a
cheap rev-parse call. If git is unavailable, return true (fail safe —
assume tracked). The outer catch also returns true instead of false.
--- Path 2: migration never cleans git index (migrate-external.ts)
migrateToExternalState() correctly creates the .gsd symlink/junction but
never ran `git rm -r --cached .gsd/`. All previously tracked .gsd/* files
remained in the git index pointing through the new symlink, which git
cannot follow — causing PROJECT.md, milestones/, REQUIREMENTS.md etc. to
appear as deleted in git status immediately after every migration.
Fix: after the symlink is verified, run:
git rm -r --cached --ignore-unmatch .gsd
--ignore-unmatch makes this a no-op on fresh/untracked projects.
--- Path 3: race between migration and ensureGitignore
Resolved by Path 2. If migration always cleans the index, the race
window (another process converting .gsd/ to a symlink between the
migrateToExternalState() and ensureGitignore() calls) is harmless —
the index is already clean and there is nothing to lose.
--- Tests added (gitignore-tracked-gsd.test.ts)
- hasGitTrackedGsdFiles returns true (fail-safe) when git is unavailable
(simulated via .git/index.lock to force git ls-files failure)
- migrateToExternalState cleans git index so tracked files don't show
as deleted after successful migration
Fixes residual vectors from #1364 (original fix: #1367, v2.36.0)
Template for projects to declare stack, build, test, and environment
details. Inlined into execute-task prompts when present.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds createDraftPR() to git-service.ts and hooks it into the milestone
transition block in auto-loop.ts. Best-effort, non-fatal on failure.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Native ESM import() ignores NODE_PATH and resolves packages by walking up
the directory tree. Extension files synced to ~/.gsd/agent/extensions/ have
no ancestor node_modules, so imports of @gsd/* packages fail with "Cannot
find package" errors during report generation and other dynamic-import paths.
Create a symlink ~/.gsd/agent/node_modules -> GSD's node_modules after
resource sync so Node's standard resolution finds @gsd/* packages. Also
migrate the most critical dynamic imports in auto-loop, exit-command, and
commands to use importExtensionModule (jiti-based) as a belt-and-suspenders
fix.
Closes#1594
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Two bugs fixed:
1. recordHealthSnapshot counted ALL doctor issues including cross-milestone
stale errors, inflating consecutiveErrorUnits past the escalation threshold
from unfixable errors in other milestones. Now filters report.issues to
only the current milestone before summarizing for health tracking.
2. matchesScope used unitId.startsWith(scope) without a delimiter, so scope
"M004/S01" would false-match "M004/S010". Removed the redundant
delimiter-less startsWith branch — exact match and slash-delimited
startsWith are sufficient.
Closes#1579
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* refactor(auto-loop): hoist MAX_RECOVERY_CHARS to module level
Constant was defined inside the while loop body on every iteration.
Moved to module level next to MAX_LOOP_ITERATIONS.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* refactor(auto-loop): cache loadEffectiveGSDPreferences() once per iteration
Was called 9 times per loop iteration. Now called once at the top of the
try block and stored in `prefs`, used throughout the iteration.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
New UAT types skip human pause, enabling automated browser and script
verification by the engine.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
capPreamble() enforces MAX_PREAMBLE_CHARS via truncateAtSectionBoundary,
applied to all inlinedContext assembly points. Replaces deleted compression
subsystem with a simple deterministic cap.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the crude sameUnitCount counter with a sliding window (size 6)
that detects three stuck patterns:
1. Same error repeated twice in a row → stuck immediately
2. Same unit derived 3 consecutive times → stuck (was 5, now faster)
3. Oscillation pattern A→B→A→B → stuck (previously undetected)
Graduated recovery preserved: first detection triggers cache invalidation
+ retry, second detection triggers hard stop.
Exported detectStuck() function with 8 unit tests covering all rules
plus edge cases (truncation, priority, non-triggers).
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dispatchWorkflow now resolves per-phase model preferences (e.g.,
models.planning, models.execution) via resolveModelWithFallbacksForUnit
and applies them with pi.setModel before dispatching the workflow message.
All 22 call sites pass the appropriate unit type context so planning,
research, execution, and completion phases each use the configured model.
Closes#1582
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
closeoutUnit() ran at the start of the next loop iteration, creating a
window where a crash between runUnit() returning and the next iteration
would lose all telemetry (metrics, activity log, memory extraction).
completed-units.json was also never flushed to disk, causing severe
staleness (3 entries for 322 completed units in production).
Closes#1590
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
smartStage() ran `git add -A` on the entire repo then unstaged exclusions,
causing indefinite hangs on repos with large untracked artifact trees (57GB+).
autoCommitDirtyState() bypassed smartStage() entirely via direct nativeAddAll().
Add nativeAddAllWithExclusions() using `git add -A -- ':!pattern'` syntax so
excluded paths are never hashed. Route autoCommitDirtyState() through it with
RUNTIME_EXCLUSION_PATHS.
Closes#1605
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When a slice is marked [x] in ROADMAP but tasks are incomplete and no
summary exists, doctor detects slice_checked_missing_summary (declared
fixable) but had no shouldFix handler — creating an unrecoverable
deadlock. Add handler that unchecks the slice when tasks are incomplete,
and add markSliceUndoneInRoadmap to both doctor.ts and
roadmap-mutations.ts.
Closes#1591
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The MCP client passed raw "${VAR}" strings to child processes instead of
resolving them against process.env, breaking MCP servers that expect
resolved environment variable values.
Adds a resolveEnv() helper that interpolates ${VAR} patterns in env
config values before passing them to StdioClientTransport.
Closes#1599
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
After dispatchDoctorHeal fires pi.sendMessage({ triggerTurn: true }),
the function fell through to return "continue". The auto-loop treated
"continue" as "proceed to next unit", called newSession() while the
session manager was still processing the heal turn, and the 30s timeout
killed auto-mode.
Returning "dispatched" causes the auto-loop to break, letting the heal
turn complete and trigger its own handleAgentEnd to resume the loop.
Closes#1580
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
In manual sessions (no auto-mode), bootstrapAutoSession never runs, so the
GSD database is never opened. This causes gsd_save_decision,
gsd_update_requirement, and gsd_save_summary tools to always fail with
'GSD database is not available'.
Add ensureDbOpen() helper that checks isDbAvailable() first, then tries to
open the DB from the expected .gsd/gsd.db path if it exists. All three tool
handlers now use this helper instead of the check-only pattern.
The fix is backward-compatible: in auto-mode the DB is already open, so
ensureDbOpen() returns true immediately on the isDbAvailable() check.
Move `pendingResolve` and `sessionSwitchInFlight` from AutoSession to
module-level variables in auto-loop.ts (`_currentResolve`,
`_sessionSwitchInFlight`). Remove `pendingAgentEndQueue` entirely —
agent_end events arriving with no pending resolver are now dropped
(with a debug warning) instead of queued.
This eliminates the `_activeSession` singleton, the queue drain logic
in `runUnit`, and three properties from `AutoSession.reset()`.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Extract validateProjectId() and validate at startup in
bootstrapAutoSession() so users get immediate feedback on invalid
values. repoIdentity() returns the custom ID directly when set.
Delete prompt-compressor, summary-distiller, and semantic-chunker modules
plus all associated tests. Replace all compression/distillation/chunking
call sites with section-boundary truncation via truncateAtSectionBoundary.
Remove compression_strategy preference, validation, and documentation.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Each cleanup group in stopAuto is wrapped in its own try/catch so a
failure in one step (e.g., worktree exit, DB close, model restore)
cannot abort remaining cleanup. Critical invariants (s.active=false,
s.paused=false, UI reset, pendingResolve=null) are moved into a
finally block that executes unconditionally.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(gsd): tighten prompt automation contracts
* fix(gsd): restore confirmation gates for reflection/requirements/roadmap, scope workflow autonomy by complexity
Amends PR #1556 to address two behavioral risks:
1. discuss.md: Remove "treat continuation as confirmation" fallthrough —
elaboration is not confirmation. Restore explicit confirmation gates
for requirements and roadmap preview.
2. workflow-start.md: Gate autonomy on {{complexity}} — low/medium
workflows keep moving by default, high complexity workflows confirm
at phase transitions.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Address six convergent audit findings in the auto-mode agent loop:
1. Move rewriteAttemptCount to AutoSession — eliminates module-level state
that leaked across stop/start cycles in auto-dispatch.ts
2. Add unit correlation to agent_end queue — tag events with unitId so late
completions from unit A cannot falsely resolve unit B
3. Split post-unit into heavy/light paths — sidecars skip settle delay,
doctor, state rebuild, and worktree sync; reduce sleep 500ms→100ms
4. Data-driven budget thresholds — consolidate 75/80/90% copy-pasted
notification blocks into BUDGET_THRESHOLDS array lookup
5. Fix session teardown — stopAuto() restores model first then calls
s.reset() replacing 36 lines of manual field clearing
6. Add debugLog to 12 silent catch blocks in auto-post-unit.ts
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Centralise all ~/.gsd path construction through app-paths.ts (compiled
code) or a module-level `gsdHome` const (runtime extensions that cannot
import app-paths). When GSD_HOME is set, every path that previously
resolved under ~/.gsd now resolves under the override.
Existing overrides (GSD_STATE_DIR, GSD_CODING_AGENT_DIR) continue to
take precedence when set.
PR #1527 fixed metrics.ts but missed several other paths that still
reach shared/mod.js → ui.js → @gsd/pi-tui during report generation
via native dynamic import() (which bypasses jiti alias resolution).
Remaining chains fixed:
- preferences.ts, preferences-validation.ts, export.ts, forensics.ts,
migrate/parsers.ts: import from shared/format-utils.js directly
- state.ts, visualizer-data.ts, files.ts: import from milestone-ids.js
instead of guided-flow.js (which pulls in shared/mod.js)
- files.ts: import checkExistingEnvKeys from new env-utils.ts instead
of get-secrets-from-user.ts (which imports @gsd/pi-tui)
New file: env-utils.ts extracts the pure checkExistingEnvKeys function.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
New detections:
- Circular dependency detection (DFS cycle check on slice depends:[])
- Orphaned slice directories (dirs not in roadmap)
- Duplicate task IDs in plan files
- Task summary files on disk not in plan (info)
- Stale REPLAN.md when all tasks are done (info)
- Metrics ledger corruption (version != 1 or units not array)
- Large planning files >100KB (warning)
- Future completed_at timestamps >24h ahead (warning)
New modes and output:
- --dry-run flag: reports [dry-run] would fix entries without writing
- --json flag: formatDoctorReportJson() for CI/tooling integration
- --build / --test flags: opt-in slow checkBuildHealth/checkTestHealth
- Per-check timing: timing.{git,runtime,environment,gsdState} on DoctorReport
- Doctor history: appends compact JSONL entry to .gsd/doctor-history.jsonl;
exports readDoctorHistory() for programmatic access
Tests: 27 new test scenarios in doctor-enhancements.test.ts covering all features
* fix: apply pi manifest opt-out to extension-discovery.ts (#1537 follow-up)
The cmux fix in #1537 patched resolveExtensionEntries() in
packages/pi-coding-agent/src/core/extensions/loader.ts to honor
"pi": {} as an opt-out from auto-discovery. However, there is a
second copy of resolveExtensionEntries() in src/extension-discovery.ts
that was not updated. This is the version actually used at startup
by loader.js via discoverExtensionEntryPaths().
As a result, cmux/index.js is still discovered and loaded as an
extension on startup, producing:
Extension does not export a valid factory function: .../cmux/index.js
Fix: Apply the same authoritative-manifest logic to the
extension-discovery.ts copy. When a package.json has a "pi" field,
treat it as authoritative and return early — either with declared
extension paths or an empty array for library opt-out.
Tests: 7 new tests covering resolveExtensionEntries and
discoverExtensionEntryPaths behavior for opt-out, declared
extensions, and fallback discovery.
* fix: apply pi manifest opt-out to package-manager.ts (third copy)
There are THREE copies of resolveExtensionEntries():
1. packages/pi-coding-agent/src/core/extensions/loader.ts (fixed in #1537)
2. src/extension-discovery.ts (fixed in previous commit)
3. packages/pi-coding-agent/src/core/package-manager.ts (THIS commit)
Copy #3 is used by collectAutoExtensionEntries() which is called from
addAutoDiscoveredResources() during DefaultPackageManager.resolve().
This is the actual code path that discovers ~/.gsd/agent/extensions/cmux
and passes it to loadExtensions(), producing the factory function error.
* fix: rewrite pi.extensions .ts paths to .js during resource copy
copy-resources.cjs compiles .ts → .js via tsc but copies package.json
files verbatim. Extensions with pi.extensions: ["./index.ts"] end up
in dist/ pointing to a .ts file that doesn't exist (only .js does).
This causes resolveExtensionEntries() to find no valid entry points,
silently skipping the extension. Affected: gsd, browser-tools, context7,
google-search, universal-config — all extensions with pi manifests.
Fix: When copying package.json files, rewrite .ts/.tsx extensions in
pi.extensions arrays to .js so they match the compiled output.
* fix: add missing commands to /gsd description and rate sub-completions
- Add 9 missing commands to the description string: widget, rate, park,
unpark, init, setup, logs, inspect, extensions
- Add sub-completions for /gsd rate (over/ok/under)
* feat: grid layout for parallel cmux splits and completion trailing-space fix
CmuxClient.createGridLayout(count) pre-creates a tiled grid of surfaces
before launching parallel agents, instead of the previous approach of
creating splits per-agent with alternating right/down directions.
Grid layout strategy:
1 agent: [gsd | A]
2 agents: [gsd | A] (A split down)
[ | B]
3 agents: [gsd | A] (2x2 grid)
[ C | B]
4 agents: [gsd | A] (additional splits from bottom-right)
[ C | B]
[ | D]
Changes:
- Add CmuxClient.createSplitFrom(sourceSurfaceId, direction) to split
from a specific surface rather than always the gsd surface
- Add CmuxClient.createGridLayout(count) that builds the grid and
returns surface IDs in order
- Update runSingleAgentInCmuxSplit to accept a pre-created surface ID
(string) or a direction for backward compatibility
- Parallel dispatch pre-creates grid, assigns each agent a surface
- Fix getArgumentCompletions trailing-space handling so sub-completions
work (e.g., /gsd cmux <tab> now shows status/on/off/etc.)
- 5 new tests for grid layout logic
* feat(ui): add GSD welcome screen on interactive startup
Renders a two-panel boxed welcome screen to stderr before the TUI
takes over, mirroring the style of the Claude Code welcome screen.
Left panel — personalized greeting, GSD ASCII logo, active model + cwd
Right panel — getting-started tips, recent session activity
The screen is printed to stderr immediately before InteractiveMode.run(),
so it appears on launch and reappears when the TUI exits (alternate-screen
buffer swap). It silently skips when not a TTY or terminal < 60 cols.
Files:
src/welcome-screen.ts — printWelcomeScreen() implementation
src/cli.ts — call site before interactiveMode.run()
src/tests/welcome-screen.test.ts — 11 unit tests (all passing)
* refactor(ui): minimal welcome screen — logo + metadata, no box
Replace two-panel boxed layout with a minimal design:
logo block with version/model/cwd alongside it, dim hint below.
No box borders, no tips panel. Clean and fast.
* feat(ui): show tool status line (Brave/Jina/Tavily) when keys are configured
When .gsd is a symlink (e.g., openclip/.gsd -> ~/.gsd/projects/<hash>),
worktrees resolve to ~/.gsd/projects/<hash>/worktrees/<name> instead of
the expected <repo>/.gsd/worktrees/<name>. All worktree detection
functions used the marker /.gsd/worktrees/ which did not match the
resolved path /.gsd/projects/<hash>/worktrees/.
This caused three cascading failures:
1. escapeStaleWorktree failed to detect stale worktree CWD
2. isUnderGsdWorktrees returned false, causing nested worktrees
3. Empty registry was conflated with "all milestones complete"
Changes:
- Add findWorktreeSegment helper matching both direct and symlink layouts
- Refactor detectWorktreeName and resolveProjectRoot to use the helper
- Fix escapeStaleWorktree in auto-worktree-sync.ts for symlink paths
- Fix isUnderGsdWorktrees in auto-start.ts for symlink paths
- Fix resolveCapturesPath in captures.ts for symlink paths
- Distinguish empty registry from all-complete in auto-loop.ts
- Add tests for symlink-resolved path detection
* fix(gsd): batch-specific artifact verification for reactive-execute
The reactive-execute artifact verifier previously checked only that
'at least one task summary exists' in the slice. This meant the unit
could report success even when none of the dispatched tasks actually
completed — a pre-existing T01 summary would satisfy the check.
Fix:
- Encode dispatched task IDs in the unitId: M001/S01/reactive+T02,T03
- Persist dispatched batch in ReactiveExecutionState before dispatch
- Verify each dispatched task's summary file exists individually
- Legacy unitId format (no +batch suffix) falls back to old behavior
The verifier now answers 'did the tasks we dispatched actually finish?'
instead of 'does any summary exist?'
Added ReactiveExecutionState.dispatched field to track the batch.
5 new tests covering: all-pass, partial-fail, pre-existing-irrelevant,
legacy fallback, and unitId round-trip encoding.
* fix(gsd): dependency-based carry-forward for reactive task execution
In reactive mode, each subagent task was getting order-based carry-forward
(all prior task summaries by number), not dependency-based. T05 depending
only on T02 would still receive T01, T03, T04 summaries — noise context
that wastes tokens and could confuse execution.
Fix:
- Add getDependencyTaskSummaryPaths() — returns only summaries for tasks
in the derived dependsOn set, falling back to order-based for root tasks
with no dependencies (preserves continuity)
- Add ExecuteTaskPromptOptions with carryForwardPaths override
- buildExecuteTaskPrompt accepts optional override, sequential callers
unchanged (no options = order-based, backward compatible)
- buildReactiveExecutePrompt now passes dependency-scoped paths per task
Sequential execute-task dispatch is completely unchanged — the new code
path only activates when carryForwardPaths is explicitly provided.
3 new tests: dependency-only filtering, root task fallback, missing
dependency summary handling.
* fix(gsd): enforce backtick file paths in task plan IO sections
The reactive task graph (ADR-004) derives dependencies from backtick-wrapped
file paths in ## Inputs and ## Expected Output sections. Without concrete
paths, the graph is ambiguous and falls back to sequential execution.
Changes:
- task-plan.md template: add comments explaining paths are machine-parsed
- plan-slice.md prompt: explicitly instruct planner to write backtick file
paths in IO sections, add self-audit check for path presence
- observability-validator.ts: new validation rules missing_output_file_paths
(warning) and missing_input_file_paths (info) catch plans without paths
- plan-quality-validator.test.ts: 4 new test cases for IO path validation
* fix(ci): increase max_tokens and add JSON parse error handling in ai-triage
max_tokens: 300 was too low, causing truncated JSON responses from Claude
that failed to parse. Bumped to 1024 and added try/catch with raw text
logging for easier debugging.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
