Commit graph

93 commits

Author SHA1 Message Date
Mikael Hugo
b24f426f2b batch: snapshot of in-flight v2 work
This commit captures uncommitted modifications that accumulated in the
working tree across multiple in-progress workstreams. It is a snapshot
to clear the deck before sf v3 work begins; individual workstreams
should land separately on top of this.

Notable additions:
- trace-collector.ts, traces.ts, src/tests/trace-export.test.ts —
  trace export plumbing
- biome.json — Biome linter configuration
- .gitignore — exclude native/npm/**/*.node compiled binaries

The bulk of the diff is across src/resources/extensions/sf/ (301 files)
and src/resources/extensions/sf/tests/ (277 files), reflecting the
ongoing sf extension work. Specific feature commits should follow this
snapshot rather than being archaeology'd out of it.

The 76MB native/npm/linux-x64-gnu/forge_engine.node compiled binary
was left out of the commit — it's now gitignored and built locally.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-29 12:42:31 +02:00
Mikael Hugo
f98a1e360e batch: codex-rescue session output (multiple in-flight tasks)
Combined output of multiple parallel codex-rescue runs that produced
working-tree edits but didn't commit. Tasks contributing:

- prefs: per-provider model allow-list (provider_model_allow) — manual
- TUI scroll + unresponsive (a7884d1a / bt3fpn4y2)
- planningMeeting required (aa09e904 / br127l763)
- Logs UX 4-pack (a5c65314 / btcplhu7f)
- Gate auto-resolve + completion nudge (ae4c8b64 / bw1w1fjkp)
- sf_task_complete atomic + retry (a7a079b4 / b20cy5owv)
- Multi-model meeting + minimax M2.7 + draft promotion (a756faac / task-moifjknd-lwjc98)
- Per-role slice prompts (a94c3e1a)
- Per-role vision-meeting prompts (afd165a0 / task-moifple5-lcwtjl)
- Schema sweep (ac994b1e / task-moifq7pu-83coqz)
- Flow audit (ad26ecfd / bttj4vrqm)

Typecheck passes. Tests not run as a full suite — spot-check after merge.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
2026-04-28 11:52:42 +02:00
ace-pm
c744bdf6c1
fix: atomic writes, parse radix, lossy json, silent worker spawn
8 fixes from 3rd-pass scan:

1. web/components/sf/tempCodeRunnerFile.tsx: remove orphan VS Code
   'Code Runner' artifact (850+ lines duplicated from shell-terminal.tsx).
   Unreferenced but compiled into tsc project.

2. sf/phase-anchor.ts: writePhaseAnchor used plain writeFileSync — a crash
   mid-write would corrupt the handoff checkpoint that readPhaseAnchor then
   silently returns null for, losing cross-phase context. Switched to
   atomicWriteSync (already used by sibling files).

3. sf/forensics.ts: same non-atomic writeFileSync on active-forensics.json
   marker. Race with a concurrent reader produces an empty object and the
   forensics session is lost. Switched to atomicWriteSync.

4. web/auto-dashboard-service.ts: paused-session.json existence was the
   intended signal but a corrupt body silently dropped the paused flag so
   the UI showed active. Now reports paused on file existence regardless
   of body integrity, and warns on corruption.

5. sf/visualizer-data.ts: doctor-history.jsonl parser did .map(JSON.parse)
   inside an outer catch. One corrupt line discarded 19 valid entries.
   Per-line try/catch preserves the valid rows.

6. sf/files.ts: three parseInt calls without radix (step, total_steps,
   totalSteps) — also missing || 0 fallback for NaN.

7. cli.ts: parseInt(process.versions.node) without radix. Split on '.' and
   use radix 10 explicitly.

8. sf/slice-parallel-orchestrator.ts: silent 'catch {}' around spawn()
   masked worker-spawn failures as 'no workers available'. Matches sibling
   parallel-orchestrator.ts pattern — now logs via logWarning.

Skipped from the scan (need a real lock mechanism, not safe as a one-line
fix):
- sf/auto-dispatch.ts:164 (UAT counter race)
- sf/captures.ts:107 (CAPTURES.md append race)

Deferred (low-value):
- preferences-models.ts, key-manager.ts, auto-timers.ts silent catches
- dead variable in visualizer-data.ts
- google-gemini-cli.ts maxTokens clamp interaction

tsc --noEmit green at root.
2026-04-21 02:13:10 +02:00
ace-pm
485e8f608e
chore: init sf 2026-04-21 01:38:02 +02:00
Mikael Hugo
30730dd25b Fix rebrand artifacts, add family-priority model routing to proxy server
- Update Dockerfile image name and package.json URLs to singularity-ng/singularity-foundry
- Add uv to nix develop shell in flake.nix
- Rename resolveGsdRoot → resolveSFRoot in src/cli.ts
- Add PROXY_FAMILY_PRIORITY routing table + sortByFamilyPriority to proxy-server.ts
- Fix duplicate scope key and simplify link-workspace-packages.cjs
- Remove duplicate conditions in postinstall.js
- Add ES2024 target/lib to tsconfig.extensions.json
- Delete obsolete GSD recovery scripts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-18 12:28:27 +02:00
ace-pm
f92ee8d64c
Rename @sf-run/* → @singularity-forge/* package scope
- All 373 source files updated
- Package.json scopes in all workspace packages
- Loader workspace symlink dir updated
- RpcClient import unified from pi-coding-agent (fixes type mismatch)
- Scripts, configs, flake.nix updated
- Workspace symlinks rebuilt
2026-04-15 22:56:33 +02:00
ace-pm
9d739dfa5d Rename GSD→SF: complete rebrand from fork origin
- All gsdDir/gsdRoot/gsdHome → sfDir/sfRootDir/sfHome
- GSDWorkspace* → SFWorkspace* interfaces
- bootstrapGsdProject → bootstrapProject
- runGSDDoctor → runSFDoctor
- GsdClient → SfClient, gsd-client.ts → sf-client.ts
- .gsd/ → .sf/ in all tests, docs, docker, native, vscode
- Auto-migration: headless detects .gsd/ → renames to .sf/
- Deleted gsd-phase-state.ts backward-compat re-export
- Renamed bin/gsd-from-source → bin/sf-from-source
- Updated mintlify docs, github workflows, docker configs
2026-04-15 18:33:47 +02:00
ace-pm
6b0ac484ba refactor: update log prefixes and string values from gsd- to sf- namespace
Updates channel prefixes, log messages, comments, and configuration values
across daemon, mcp-server, and related packages to complete the rebrand from
gsd to sf-run naming.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 15:37:12 +02:00
ace-pm
b29c12d5e5 refactor(native): rename gsd_parser.rs to forge_parser.rs
Final rebrand: rename remaining Rust source file to complete the gsd → forge
transition. All parser references already use forge_parser after earlier commits.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 14:58:21 +02:00
ace-pm
35dc87ef53 chore: sync workspace state after rebrand
- Rebrand commits already in history (gsd → forge)
- Sync pre-existing doc, docker, and CI config updates
- All rebrand artifacts verified in place:
  * Native crates: forge-engine, forge-ast, forge-grep
  * Log prefixes: [forge] across 22+ files
  * Binary: ~/bin/sf-run
  * Workspace scopes: @sf-run/*, @singularity-forge/*
  * Nix flake: Rust toolchain ready

System ready for: nix develop && bun run build:native

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 14:54:20 +02:00
ace-pm
d501ca7d6d fix: clean up git state after directory restoration
- Accept deletion of gsd-phase-state.ts (renamed to forge-phase-state.ts earlier)
- Accept deletion of create-gsd-extension/ (renamed to create-forge-extension/ earlier)
- These renames were part of the rebrand and are preserved in commit history

Stabilize git state after restoration operations.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 14:34:53 +02:00
ace-pm
172753c3b2 refactor(forge): complete gsd → forge rebrand across native, logging, and build system
- Rename native Rust crates: gsd-engine → forge-engine, gsd-ast → forge-ast, gsd-grep → forge-grep
- Update all crate dependencies (Cargo.toml, .rs source) and N-API artifacts
- Mass rename log prefix [gsd] → [forge] across 81 files (scripts, src/, extensions, tests)
- Rename log prefix "gsd-db:" → "forge-db:" in template literals
- Update nix flake: add sf-run-native devShell with Rust toolchain for native addon builds
- Update CI workflow artifact names (build-native.yml)
- Verify only packages/native/* touched (no upstream pi-* packages renamed)

Rationale: Complete gsd-2 → singularity-forge rebrand (2026-04-15). Native addon is
sf-run-specific; all gsd-prefixed logging and crate names must align with new identity.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 14:11:45 +02:00
ace-pm
e5d655bdb3 chore: checkpoint workspace changes 2026-04-15 13:38:15 +02:00
ace-pm
6612456934 fix(extensions): route print mode through buildResourceLoader
Print mode was constructing DefaultResourceLoader directly, which
bypassed the GSD extension registry filter and let disabled bundled
extensions leak through. With the community @0xkobold/pi-ollama
installed, every `gsd -p` invocation printed an /ollama command
conflict because the bundled ollama extension (explicitly disabled
in ~/.gsd/extensions/registry.json) was still being loaded.

- Add extension-manifest.json for the bundled ollama extension so the
  registry's id-keyed disable entry can actually target it.
- Extend buildResourceLoader() with an options bag for print-mode
  callers (additionalExtensionPaths, appendSystemPrompt).
- Switch print mode to buildResourceLoader() so the registry filter
  (extensionPathsTransform) runs in both TUI and print paths.

Also fix a stderr leak in the GSD codebase-generator: execSync("git
ls-files") was inheriting stderr to the parent, so running gsd from a
non-repo cwd (e.g. $HOME) printed "fatal: not a git repository" before
the catch silently returned []. Pipe stderr so it lands in the thrown
Error instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 11:44:52 +02:00
ace-pm
1f1c029c74 fix(cli): invert persistModelChanges default to false (#4251)
Followup to 828c5edf6. Swarm review flagged default=true as a latent
footgun: any SDK consumer of createAgentSession() that forgets to pass
persistModelChanges would silently mutate ~/.gsd/agent/settings.json.

Flip the default to false so persistence is opt-in. Interactive CLI
entry points now explicitly pass persistModelChanges: true:
- src/cli.ts interactive createAgentSession call
- packages/pi-coding-agent/src/main.ts: persistModelChanges = isInteractive

Print/rpc/mcp stay at the safe default. Tests updated (9/9 green).
2026-04-15 10:45:26 +02:00
ace-pm
828c5edf62 fix(cli): don't persist --model override in print mode (#4251)
`gsd -p --model X "msg"` was silently overwriting defaultProvider/
defaultModel in settings.json. One-shot verification runs must use the
model for that invocation only.

Adds an AgentSessionConfig.persistModelChanges flag (default true so
interactive behavior is unchanged), forwards it through createAgentSession,
and sets it false in main.ts when !isInteractive and in src/cli.ts print
mode. The gsd wrapper also skips validateConfiguredModel when --model is
explicitly passed, so a CLI-provided model can't trigger a fallback repair
that writes the wrong default back.

Three settings.json write sinks audited: agent-session._applyModelChange
(gated on flag), model-selector.ts (interactive only, unreachable in
print), startup-model-validation (gated by !cliFlags.model in print).

Regression: 8 source-assertion tests in
agent-session-print-mode-persist.test.ts.
2026-04-15 10:12:32 +02:00
Nils Reeh
15bccca78f feat(graph): implement knowledge graph system (closes #4202)
Ports the v1 graphify system to v2 as a native TypeScript implementation.
The knowledge graph builds semantic relationships between milestones, slices,
tasks, and knowledge entries — and injects relevant subgraphs automatically
into every agent dispatch prompt.

## Core implementation (packages/mcp-server/src/readers/graph.ts)

- `buildGraph(projectDir)` — walks all .gsd/ artifacts (STATE.md,
  milestone PLANs, slice PLANs, KNOWLEDGE.md), extracts nodes and edges
  with confidence tiers (EXTRACTED / INFERRED / AMBIGUOUS). Parse errors
  skip the node rather than crashing.
- `writeGraph(gsdRoot, graph)` — atomic write via tmp file + rename.
- `writeSnapshot(gsdRoot)` — saves a diff baseline before each rebuild.
- `graphQuery(projectDir, term, budget?)` — BFS subgraph search with
  case-insensitive matching on label + description; trims AMBIGUOUS edges
  first, then INFERRED, respecting the token budget (default 4 000).
- `graphStatus(projectDir)` — freshness check; stale = older than 24 h.
- `graphDiff(projectDir)` — compares current graph to last snapshot,
  returns added / removed / changed counts for nodes and edges.

## MCP tool (packages/mcp-server/src/server.ts)

Registers `gsd_graph` immediately after `gsd_knowledge` with four modes:
build | query | status | diff. All errors returned as isError: true.

## CLI subcommand (src/cli.ts, src/help-text.ts)

`gsd graph build|status|query <term>|diff` — follows the established
`if (cliFlags.messages[0] === '...')` dispatch pattern. Uses
`resolveGsdRoot()` for git-root-aware path resolution (not a naive
`.gsd` append). Help text updated with correct positional argument format.

## Auto-rebuild after slice completion
(src/resources/extensions/gsd/tools/complete-slice.ts)

Fire-and-forget `buildGraph → writeGraph` triggered after every slice
completion. Uses `@gsd-build/mcp-server` package import (not a relative
src path) and `resolveGsdRoot()` for correct path resolution in monorepos.

## Graph-aware dispatch injection
(src/resources/extensions/gsd/graph-context.ts,
 src/resources/extensions/gsd/auto-prompts.ts)

`inlineGraphSubgraph(projectDir, term, { budget })` queries the graph and
formats the result as a `### Knowledge Graph Context` markdown block,
consistent with all other inlined context blocks. Adds a stale warning
annotation when the graph is older than 24 h. Returns null (graceful
skip) when graph.json is missing, the query returns zero nodes, or the
import fails — no agent dispatch is ever blocked by graph availability.

Injected into three prompt builders:
- `buildResearchSlicePrompt` — 3 000 token budget
- `buildPlanSlicePrompt`     — 3 000 token budget
- `buildExecuteTaskPrompt`   — 2 000 token budget

## Tests

- 22 tests for the core graph reader (graph.test.ts)
- 14 tests for the dispatch injection helper (graph-context.test.ts)
- All tests use real on-disk fixtures (no module mocking needed)
- Full suite: 6 318 passed, 0 failed

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-15 02:20:49 +02:00
Jeremy
1a8ba9a43b fix(cli): restore --help handling when it follows a subcommand or unknown flag
The #4162 refactor removed parseCliArgs' inline --help handler assuming
loader.ts's fast-path covered it, but loader.ts only intercepts --help/-h
as argv[1]. That broke:

- gsd update --help — fell through to runUpdate() (subcommand help
  check sat dead-code below the update handler)
- gsd --unknown --help in non-TTY — tripped the TTY gate and exited 1

Move the subcommand-help check ahead of every subcommand handler and
fall back to general help when no subcommand matches, so --help wins
whenever it appears anywhere in argv.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-14 05:50:47 -05:00
Claude
679b3177a8 refactor(cli): slim down top-level src/ — dedup, unused fallbacks, onboarding
Pure deletion/deduplication pass on top-level src/*.ts. External behavior
unchanged; all targeted unit tests still pass.

cli.ts (−170 net lines)
  - Adopt canonical validateConfiguredModel from startup-model-validation.ts;
    delete the drifted local copy with hardcoded model fallbacks.
  - Import CliFlags + parseCliArgs from cli-web-branch.ts instead of keeping
    a second, 90%-identical parser; pass cliFlags directly into
    runWebCliBranch instead of re-parsing process.argv.
  - Extract 3 helpers for verbatim duplicates:
      * printNonTtyErrorAndExit (TTY gate, 2 call sites)
      * printExtensionErrors (extension load errors, 2 call sites)
      * reapplyValidatedModelOnFallback (post-createAgentSession fix, 2 sites)
  - Factor runHeadlessFromAuto helper shared by the `gsd auto` shorthand
    and the auto-piped-stdout redirect.
  - Collapse ensureRtkBootstrap from hand-rolled _done flag to a
    promise-memoized doRtkBootstrap.
  - Drop redundant validateConfiguredModel pre-createAgentSession calls
    (the post-createAgentSession call is the correct one per #2626).
  - Delete dead --version/-v and --help/-h fast paths (loader.ts already
    handles these before cli.ts is imported).

cli-web-branch.ts
  - Unify CliFlags with worktree, 'mcp' mode, and _selectedSessionPath.
  - Drop unused help?/version? flags (loader.ts intercepts them).

onboarding.ts
  - Add runStep<T>() helper with shared cancel/warn handling; collapse 4
    near-identical try/catch blocks around runLlmStep, runWebSearchStep,
    runRemoteQuestionsStep, runToolKeysStep.
  - Delete trivial isCancelError helper (inlined as p.isCancel).
  - Rewrite loadPico() adapter to build PicoModule from chalk so we can
    drop the redundant picocolors dependency.

package.json / package-lock.json
  - Remove picocolors direct dep (chalk remains the single color library).
2026-04-14 01:51:22 +00:00
Jeremy
bafa4e483d Merge remote-tracking branch 'upstream/main' into claude/model-agnostic-selection-rmDX3
# Conflicts:
#	packages/pi-coding-agent/src/core/model-resolver.ts
#	src/cli.ts
2026-04-13 10:22:16 -05:00
Claude
0ed576ac00 Make model selection model-agnostic
Remove hard-coded Anthropic/Claude defaults and silent provider swaps so
the app honors whatever model/provider the user has configured.

- src/cli.ts: drop the anthropic->claude-code auto-migration blocks that
  were rewriting the user's saved defaultProvider on every startup.
- packages/pi-coding-agent/src/core/model-resolver.ts: delete the
  defaultModelPerProvider table, drop the "recommended variant" swap
  that silently upgraded e.g. claude-opus-4-6 to -extended, and replace
  the provider-iteration first-available fallback with provider-sticky
  (user's saved provider first, then first registry entry).
- src/startup-model-validation.ts: replace the openai/anthropic-first
  fallback chain with Pi-default -> same-provider -> first-available.
- src/help-text.ts: use a generic provider/model-id example for --model
  instead of claude-opus-4-6.
- src/tests/startup-model-validation.test.ts: update the fallback test
  to assert provider stickiness rather than a specific Claude model id.

https://claude.ai/code/session_01CvuUuzuVjRcQN25263nG6V
2026-04-13 14:03:35 +00:00
Jeremy
a8123ab558 fix(cli): resolve duplicate validateConfiguredModel and missing getPiDefaultModelAndProvider import
Commit 110c01b8c added an inline `validateConfiguredModel` function in
`src/cli.ts` while leaving the prior import from
`./startup-model-validation.js` in place, producing TS2440 (import
declaration conflicts with local declaration). The same commit added a
call to `getPiDefaultModelAndProvider()` without importing it, producing
TS2304 (cannot find name). Both errors block `npm run build` and every
CI job on main.

Drop the stale import and add `getPiDefaultModelAndProvider` to the
existing `./pi-migration.js` import where the symbol is actually
exported. The local `validateConfiguredModel` function (lines 139-174)
becomes the sole definition in scope. `./startup-model-validation.js`
is still consumed by its dedicated test files so the module stays.
2026-04-13 06:30:21 -05:00
Rebecca Chernoff
110c01b8c6 fix: flush extension provider registrations before model resolution (#1923)
Extension-based providers like pi-claude-cli register their models
during extension loading, but registrations were queued and not flushed
until after model resolution ran. This caused findInitialModel() and
the startup model validation to see extension models as nonexistent,
permanently overwriting the user's saved model selection on every launch.

- Flush pendingProviderRegistrations in createAgentSession() before
  findInitialModel() so extension models are visible in the registry
- Move model validation to after createAgentSession() in both print
  and interactive code paths
- Load extensions before --list-models so extension models appear
2026-04-13 07:06:16 -04:00
Jeremy McSpadden
da7a7e255f Merge pull request #4082 from jeremymcs/claude/review-mcp-server-tools-2Gchv
Add query filtering, abort handling, and permission mode control
2026-04-12 20:54:51 -05:00
Claude
1eb357ca46 fix(mcp): expose every registered tool and fix SDK subpath resolution
Two related fixes for `gsd --mode mcp` that the audit missed on first pass:

1. Tool inventory — session.agent.state.tools was the *active* subset, not
   the full registry. Before this change, MCP clients connected to GSD saw
   63 tools and four built-ins were silently missing: `find`, `grep`, `ls`,
   and `hashline_edit`. After: 67 tools, matching the full _toolRegistry.
   Fix: call session.getAllTools() + session.setActiveToolsByName() before
   starting the MCP transport so every registered tool is active for the
   lifetime of the MCP session.

2. SDK subpath resolution — the #3603 createRequire workaround no longer
   works with @modelcontextprotocol/sdk 1.27.x + current Node. The
   wildcard export ./* → ./dist/cjs/* does NOT auto-append `.js`, and
   _require.resolve fails with "Cannot find module .../server/stdio".
   End-to-end handshake was actually broken in src/mcp-server.ts even
   before my earlier F5 change. Fix: use explicit `.js` suffixes on
   every subpath import (server/index.js, server/stdio.js, types.js),
   matching the convention already in use by packages/mcp-server/.

The regression test is rewritten to enforce the `.js`-suffix convention
and reject any bare subpath or lingering createRequire resolution.

Verified end-to-end via raw JSON-RPC against `gsd --mode mcp --bare`:
  BEFORE_COUNT=63
  AFTER_COUNT=67
  diff: +find +grep +hashline_edit +ls

Test sweep: 76 tests pass across mcp-createRequire, stream-adapter,
mcp-server, workflow-tools.

https://claude.ai/code/session_0174sYny3VvdwYTdCNTmY4Do
2026-04-13 01:40:05 +00:00
Jeremy McSpadden
5c271e72e7 Merge pull request #3790 from salioglu/fix/3718-sessions-stdin-cleanup
fix(cli): clean up stdin after sessions command readline interface closes
2026-04-12 20:18:09 -05:00
Jeremy McSpadden
2f92714cbb Merge pull request #3882 from mastertyko/fix/3860-onboarding-custom-default-provider
fix(cli): honor custom-provider defaults before onboarding
2026-04-11 22:56:09 -05:00
mastertyko
fee16a70c3 fix(cli): preserve anthropic api provider 2026-04-11 18:10:09 +02:00
mastertyko
266f02147d fix(cli): honor custom-provider defaults before onboarding 2026-04-09 18:03:00 +02:00
H. Sinan Alioglu
27675a5224 fix(cli): clean up stdin after sessions command readline interface closes
The sessions command uses readline.createInterface() to prompt for session
selection, but was not cleaning up stdin listeners after rl.close().
This left stdin in a corrupted state with lingering readline listeners,
causing duplicate terminal I/O and making the CLI unusable when the TUI
subsequently initialized.

Add proper stdin cleanup after rl.close() to match the pattern used after
onboarding, removing data/keypress listeners, resetting raw mode, and
pausing stdin for a clean state handoff to the TUI.

Closes #3718
2026-04-08 16:27:43 +02:00
Jeremy
ea456d4cdb fix(providers): route Anthropic subscription users through Claude Code CLI (#3772)
Anthropic now blocks third-party apps from using Pro/Max subscription
quotas via direct API calls. This change makes the claude-code provider
(which delegates to the local claude CLI binary) the default path for
Anthropic subscription users — TOS-compliant because requests flow
through Anthropic's own infrastructure.

Changes:
- Enhanced readiness check to verify CLI auth status (not just binary)
- Startup migration: auto-switch anthropic → claude-code when CLI ready
- Error recovery: auto-switch on third-party 400 block error
- Onboarding: removed Anthropic from OAuth, added Claude CLI option
- Added claude-code to flat-rate providers (no dynamic routing benefit)

Closes #3772
2026-04-08 07:20:20 -05:00
Tibsfox
523fcd89a8 fix(headless): sync resources and use agent dir for query 2026-04-05 11:35:11 -07:00
Jeremy
e3cd354d58 fix(cli): guard model re-apply against session restore and async rejection
Address Codex adversarial review findings:

1. Only re-apply the validated model when createAgentSession() signals
   a fallback (modelFallbackMessage is truthy). This prevents silently
   overriding the persisted model of resumed conversations.

2. Use modelRegistry.getAvailable() instead of find() to ensure the
   model's provider is request-ready before calling setModel().

3. Await session.setModel() and wrap in try/catch so provider auth
   failures don't surface as unhandled promise rejections at startup.

Applies to both print-mode and interactive-mode startup paths.
2026-04-05 07:27:26 -05:00
Jeremy
9fe13da3f2 fix(pi-coding-agent): resolve model fallback race that ignores configured provider (#3534)
Extension-provided models (e.g. claude-code/*) were unavailable during
findInitialModel() because pendingProviderRegistrations had not been
flushed yet, causing the fallback chain to select Google Gemini even
when the user explicitly configured claude-code as their default.

Three compounding issues fixed:

(A) Flush pendingProviderRegistrations in createAgentSession() before
    findInitialModel() runs, so extension models are in the registry
    when initial model selection happens.

(B) Re-apply the validated model to the session after
    validateConfiguredModel() in both print and interactive CLI paths.
    Previously, validation updated settingsManager but never called
    session.setModel(), leaving the session on the wrong model.

(C) Update defaultModelPerProvider.anthropic from "claude-opus-4-6[1m]"
    to "claude-opus-4-6" — the [1m] variant was removed from the model
    registry when the base model was upgraded to 1M context, causing the
    Anthropic fallback to silently fail and skip to Google.

Closes #3534
2026-04-05 07:14:24 -05:00
Tom Boucher
e9dabdc649 fix(resource-sync): prune removed bundled subdirectory extensions on upgrade (#1972)
* fix(resource-sync): prune removed bundled subdirectory extensions on upgrade

The managed-resources manifest and pruning system only tracked root-level
files, not subdirectory extensions. When a bundled subdirectory extension
like mcporter/ was removed from the bundle in a newer GSD version, the
previously-synced copy in ~/.gsd/agent/extensions/ persisted indefinitely,
causing tool name conflicts with its replacement (mcp-client/).

- Add installedExtensionDirs to the manifest alongside installedExtensionRootFiles,
  recording directory names present in the bundled extensions dir at sync time.
- In pruneRemovedBundledExtensions, diff previous installedExtensionDirs against
  current bundled dirs and rmSync({ recursive: true }) any that were removed.
- Add mcporter to the hardcoded stale-entry list for pre-manifest upgrades.
- Fix extension conflict error prefix: also match "conflicts with" (not just
  "supersedes") so extension-vs-extension conflicts are classified as warnings
  rather than hard errors.

Fixes #1955

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(resource-loader): repair mangled lines from conflict resolution

The Python regex used to resolve cherry-pick conflicts stripped trailing
newlines, causing declarations and comments to merge onto the same line.
Replace the file with the upstream/main version which contains all the
installedExtensionDirs logic correctly formatted.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(resource-loader): sweep all installed extension dirs not in current bundle

The manifest-based pruner only removed dirs it had previously recorded.
Extensions installed by pre-manifest versions (or manually) were never
tracked, so they survived upgrades. Add a sweep of the actual installed
extensions directory that removes any subdirectory absent from the current
bundle, regardless of manifest history.

Fixes the mcporter stale-dir regression test (#1972).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: check external-state DB path before symlink-resolved handler (#2952)

The external-state handler added in c609d813 was placed after the generic
symlink-resolved handler, which matches the same /.gsd/projects/<hash>/worktrees/
pattern and short-circuits to the wrong result. Move the external-state check
(which uses the more specific hex-hash regex) first so it takes precedence.

Fixes shared-wal test: external-state worktree path resolves to project state DB.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test: update db-path-worktree-symlink expectations for external-state (#2952)

/.gsd/projects/<hash>/worktrees/ paths now resolve to <hash>/gsd.db
after the external-state handler from #2952 was placed before the
symlink-resolved handler. On POSIX, getcwd() returns canonical paths so
<proj>/.gsd/projects/<hash>/worktrees/ would in practice appear as
~/.gsd/projects/<hash>/worktrees/ after OS symlink resolution — both
correctly handled by the external-state behavior.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: trek-e <trek-e@users.noreply.github.com>
2026-04-05 07:44:51 -04:00
Justin Wyer
71caa18552 fix(security): add configurable overrides for command allowlist and SSRF blocklist
PR #666 introduced hardcoded SAFE_COMMAND_PREFIXES and SSRF URL
blocklists with no override mechanism. Users with non-standard
credential tools (sops, doppler, age, infisical) or needing to fetch
from internal URLs (self-hosted docs, VPN services) were silently
blocked with no recourse.

Add two global-only settings (ignored in project-level settings.json
to preserve the security property against malicious repos):

- allowedCommandPrefixes: replaces the built-in command allowlist
- fetchAllowedUrls: exempts hostnames from SSRF blocking

Both also support env var overrides (GSD_ALLOWED_COMMAND_PREFIXES,
GSD_FETCH_ALLOWED_URLS) for CI/container environments. Env vars
take precedence over settings.json.

Security model: global-only keys are stripped from project settings
at load time via stripGlobalOnlyKeys(), applied at all three
assignment points for this.projectSettings. The merge function
stays untouched — no future caller can accidentally skip stripping.

15 new tests covering override behavior, cache invalidation,
allowlist exemptions, and global-only enforcement.
2026-04-02 13:45:05 +02:00
Jeremy McSpadden
d0555857c2 Merge pull request #2976 from jeremymcs/splash-header-updates-clean
feat(splash): add remote channel indicator to tools row
2026-04-01 16:14:23 -05:00
Tom Boucher
05b7cb95cb fix: route gsd auto to headless runner to prevent hang on piped stdin/stdout (#3057)
`gsd auto` was not handled as a subcommand — it fell through to the
interactive TUI, which hangs indefinitely when stdin/stdout are piped
(non-TTY). Add `auto` as a recognized subcommand that rewrites argv
and delegates to `runHeadless(parseHeadlessArgs(...))`, matching the
existing `gsd headless auto` behavior.

Also adds `gsd auto` to TTY error hints and help text.

Closes #2732

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-30 14:44:04 -06:00
Tom Boucher
6e22a20580 fix: defer model validation until after extensions register (#3089)
* fix: defer model validation until after extensions register (#2626)

Extension-provided models (e.g. claude-code/claude-sonnet-4-6) were
silently overwritten on every startup because the model validation ran
before createAgentSession(), which is where extensions register their
models in the ModelRegistry. At validation time, extension models did
not exist in the registry, so the user's valid choice was replaced
with a built-in fallback.

Extract validation into validateConfiguredModel() and call it after
createAgentSession() in both print-mode and interactive-mode paths.

Closes #2626

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: align MinimalSettingsManager interface with SettingsManager

The MinimalSettingsManager interface used `string` for thinking level
types, but SettingsManager uses a specific union type and returns
`undefined`. This caused TS2345 at cli.ts lines 448 and 587.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-30 14:38:10 -06:00
Tom Boucher
3ec96fd992 fix: redirect auto-mode to headless when stdout is piped (#2732) (#3269)
When `gsd auto` is run with piped stdout (e.g. `gsd auto | cat` or
`gsd auto > file`), the TUI cannot render on a non-terminal output
stream, causing the process to hang indefinitely.

This fix:
- Detects piped stdout before entering interactive mode and redirects
  `gsd auto` to headless mode automatically
- Extends the interactive mode TTY gate to also check process.stdout.isTTY
  (previously only checked stdin), with a descriptive error message
- Adds `gsd headless` to the non-interactive alternatives hint

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-30 13:48:07 -06:00
Jeremy
b0bb5390fb feat(splash): add remote channel indicator to welcome screen tools row
Add configured remote channel (Discord/Slack/Telegram) as a checkmark
in the tools row alongside Brave/Answers/Jina. Remove verbose remote
status lines and duplicate display from header-renderer and register-hooks.
2026-03-28 12:38:33 -05:00
mastertyko
24c4e393a7 fix(cli): let gsd update bypass version mismatch gate (#2845)
* test(integration): suppress npm pack buffer overflows

* fix(cli): let gsd update bypass version mismatch gate
2026-03-27 14:30:13 -06:00
Andrew
815be0a698 feat: managed RTK integration with opt-in preference and web UI toggle (#2620)
* feat: integrate managed RTK across shell workflows

* fix(rtk): unify managed fallback and live savings wiring

* fix(rtk): improve TUI status visibility

* fix(tests): make portability tests independent of pi-coding-agent dist build

The CI portability test runs don't guarantee that
packages/pi-coding-agent has been compiled. Any test that
imported files pulling in @gsd/pi-coding-agent (resource-loader,
preferences-skills, async-bash-tool, etc.) crashed with
ERR_MODULE_NOT_FOUND pointing at dist/index.js.

Two changes to dist-redirect.mjs (the Node ESM loader hook used by
all unit tests):
- Redirect the bare @gsd/pi-coding-agent specifier to the workspace
  source entrypoint (src/index.ts) so no dist/ artifact is needed.
- Extend the load() hook to transpile *.ts files under
  packages/pi-coding-agent/src/ through TypeScript's transpileModule.
  Node's --experimental-strip-types can't handle parameter properties
  and similar syntax present in that package's source; full transpilation
  avoids the ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX crash.

Also fix the dashboard.tsx responsive grid:
- xl:grid-cols-5 → xl:grid-cols-4 2xl:grid-cols-5
  (5 metric cards no longer fit at xl without overflow; test contract
  expected xl:grid-cols-4)
- Keep loading-skeletons.tsx in sync with the same breakpoints.

Add src/tests/resolve-ts-loader.test.ts to guard the loader behaviour:
- bare @gsd/pi-coding-agent redirect points to workspace source
- direct source-entry rewrite (.js → .ts)
- transpilation removes TS parameter property syntax that strip-only
  mode cannot parse

* fix(tests): redirect all workspace package imports to source in portability tests

The previous fix only redirected @gsd/pi-coding-agent to its
source entrypoint. In CI, pi-coding-agent/src itself imports
@gsd/pi-ai (and other workspace packages) which were still pointing
at dist/. Since no workspace dist is built during the portability
test run, any transitive resolution hit the same ERR_MODULE_NOT_FOUND.

Changes to dist-redirect.mjs:
- Redirect @gsd/pi-ai, @gsd/pi-ai/oauth, @gsd/pi-agent-core, and
  @gsd/pi-tui bare imports to their workspace src/ entrypoints.
- Broaden the load() transpilation condition from
  '/packages/pi-coding-agent/src/' to '/packages/*/src/' so that
  all workspace source files are run through TypeScript's
  transpileModule, handling parameter properties and other syntax
  that Node's strip-only mode rejects.

Verified by hiding all four workspace dist/ directories locally and
running the failing test set — 96/96 pass.

* fix(tests): redirect @gsd/native sub-paths; fix Windows .cmd spawnSync

Two more portability failures after the previous fix:

1. @gsd/native sub-path imports (@gsd/native/fd, @gsd/native/text, etc.)
   were not redirected — the loader only handled the bare specifier.
   Added a prefix-match redirect for @gsd/native/* → packages/native/src/<sub>/index.ts.

2. Windows RTK tests failed because createFakeRtk produces a .cmd wrapper
   on Windows, and spawnSync(binaryPath, [...]) without shell:true silently
   returns non-zero when the binary is a .cmd file.
   Added shell: /\.(cmd|bat)$/i.test(binaryPath) to the spawnSync calls in:
   - src/resources/extensions/shared/rtk.ts (rewriteCommandWithRtk)
   - src/resources/extensions/shared/rtk-session-stats.ts (readCurrentRtkGainSummary)
   - packages/pi-coding-agent/src/utils/rtk.ts (rewriteCommandForGsd)
   Production use of rtk.exe is unaffected; the shell flag is only true for
   .cmd/.bat paths.

Verified: all 93 portability tests pass with all workspace dist/ directories
removed (simulating CI portability environment).

* fix(tests): Windows portability fixes — HOME env, managed RTK path, perf threshold

Four Windows-specific failures fixed:

1. app-smoke.test.ts: process.env.HOME is undefined on Windows (uses
   USERPROFILE instead). Changed to homedir() from node:os which works
   cross-platform.

2. Managed RTK path tests on Windows: tests placed a fake RTK as rtk.exe
   (by copying a .cmd script into a .exe filename), which Windows cannot
   execute. Two-part fix:
   - resolveRtkBinaryPath() in both rtk.ts files now falls back to rtk.cmd
     in the managed dir on Windows when rtk.exe is absent.
   - withManagedFakeRtk and equivalent patterns in rtk.test.ts,
     rtk-session-stats.test.ts, rtk-execution-seams.test.ts changed to
     place the fake at rtk.cmd instead of rtk.exe on Windows.

3. bg_shell RTK test on Windows: requires bash (for shell sessions), which
   is not available on the blacksmith-4vcpu-windows-2025 runner without
   Git Bash installed. Test now skips on win32.

4. derive-state-db perf assertion: 10ms threshold was too tight for Windows
   CI runners (measured 12ms under load). Raised to 25ms — still catches
   real regressions (baseline is 3ms locally and ~12ms on stressed runners).

* fix(tests): fix managed RTK path fallback on Windows in src/rtk.ts + fix copyable fake

Two remaining Windows failures:

1. src/rtk.ts was never patched with the rtk.cmd managed-dir fallback
   (only the shared/rtk.ts and pi-coding-agent/src/utils/rtk.ts were updated).
   Added the same rtk.cmd fallback and shell:.cmd detection to src/rtk.ts,
   which is what rtk.test.ts imports from.

2. createFakeRtk on Windows wrote '%~dp0\fake-rtk.js' in the .cmd content —
   this resolves relative to the .cmd file's own directory. When the test
   copies rtk.cmd to a different managed dir, %~dp0 resolves to the copy
   destination where fake-rtk.js does not exist. Fixed by embedding the
   absolute path to fake-rtk.js directly in the .cmd content so the fake
   works correctly regardless of where the .cmd is copied.

* feat(experimental): add RTK opt-in preference with web UI toggle

- Add `experimental` category to GSDPreferences with `rtk: boolean` (default: false)
- RTK is now opt-in: disabled by default for all projects unless explicitly enabled
- Validate experimental.* keys; unknown experimental keys produce warnings

Web UI:
- Add ExperimentalPanel component with animated toggle switch per flag
- Add /api/experimental route (GET/PATCH) to read/write flags in preferences.md
- Add 'Experimental' tab to settings dialog sidebar nav (FlaskConical icon)
- Include ExperimentalPanel at bottom of gsd-prefs mega-scroll
- Fix toggle disabled state: trigger loadSettingsData for 'experimental' section
  and self-fetch on mount when data is absent

Dashboard:
- Gate RTK Saved metric card on rtkEnabled from live auto state (web)
- Gate TUI dashboard RTK savings row on rtkEnabled
- Gate TUI footer RTK status updates on experimental.rtk preference
- Propagate rtkEnabled through AutoDashboardData → bridge-service → store

Build:
- Add scripts/build-if-stale.cjs: incremental build driver that skips each
  step (packages, root tsc, copy-resources, web) when output is newer than
  source; replaces full rebuild chain in gsd:web
- Add scripts/web-stop.cjs: robust stop with registry + legacy PID + orphan
  sweep via pgrep; handles crash/restart orphaned next-server processes
- gsd:web now uses build-if-stale.cjs (fast cold starts, instant when unchanged)
- gsd:web:stop / gsd:web:stop:all use web-stop.cjs directly

Fix: correct import path in rtk-status.ts (./preferences.js not ../preferences.js)

* fix: restore em-dash encoding in package.json to match upstream

* refactor(rtk): move command rewrite out of pi-coding-agent into GSD extension

Per review feedback from igouss: pi-coding-agent should not be modified to add
GSD-specific logic. Instead, add a proper extension point and wire RTK through it.

Changes to packages/pi-coding-agent (extension API only — no RTK logic):
- Add BashTransformEvent + BashTransformEventResult types to extension API
- Add on('bash_transform') overload to ExtensionAPI interface
- Add emitBashTransform() to ExtensionRunner (chains all handlers in order)
- Call emitBashTransform() in wrapToolWithExtensions before bash tool execution
- Export new types from extensions/index.ts and package index.ts
- Revert all RTK-specific changes from bash-executor.ts, tools/bash.ts
- Remove packages/pi-coding-agent/src/utils/rtk.ts entirely

Changes to GSD extension:
- Register bash_transform handler in register-hooks.ts that calls
  rewriteCommandWithRtk() from the existing shared/rtk.ts module
- Handler is a no-op when RTK is disabled or not installed

* fix: correct import path for shared/rtk.js in register-hooks

* fix(tests): remove deleted pi-coding-agent/utils/rtk imports from execution seams test

The RTK rewrite logic was moved out of pi-coding-agent into the GSD
extension (bash_transform hook). Tests that directly imported the
deleted utils/rtk.ts are removed; remaining tests verify the shared
RTK module and GSD-layer surfaces that still call rewriteCommandWithRtk.
2026-03-26 09:33:07 -06:00
Jay The Reaper
bc278d12d9 feat(core): support for 'non-api-key' provider extensions like Claude Code CLI (#2382)
* feat(core): add generic native post-install hooks for package install

* feat(core): add before/after install/remove lifecycle hooks

* refactor(core): remove postInstall alias from lifecycle hook fallback

* feat(core): complete authMode support for keyless providers

The initial authMode implementation fixed model-registry, sdk, and
fallback-resolver but missed agent-session.ts (6 callsites) and
compaction-orchestrator.ts (2 callsites) that block externalCli
providers at runtime.

Architecture: separate readiness gating from credential retrieval.
- isProviderRequestReady(): authMode-aware readiness check
- getApiKey()/getApiKeyForProvider(): return undefined for
  externalCli/none providers instead of triggering auth errors
- All 8 callsites in agent-session and compaction-orchestrator
  now gate on readiness, not key presence
- Downstream signatures (compaction, branch-summarization) accept
  apiKey: string | undefined
- Replaced hardcoded ollama exception in discoverModels with
  isProviderRequestReady

Zero behavioral change for classic apiKey/oauth providers.

* feat(core): add isReady callback for provider readiness verification

Extensions can now provide an isReady() callback when registering any
provider. isProviderRequestReady() calls it before default auth checks,
allowing providers to verify actual reachability (CLI authenticated,
API key valid, service online) rather than relying solely on credential
presence.

* test(core): expand authMode test coverage

Cover all four auth modes (apiKey, oauth, externalCli, none),
isReady callback behavior, getProviderAuthMode defaults,
isProviderRequestReady for each mode, getAvailable filtering,
and getApiKey early-return for keyless providers.

* chore: remove provider-api-bridge files from this branch

These files implement GSD core → provider-api wiring (deps + tool
registry) and belong in a separate PR. Reverts register-extension.ts
to upstream state.
2026-03-24 15:50:12 -06:00
mastertyko
b3d12628f9 fix: prevent banner from printing twice on first run (#2251)
On first launch (before ~/.gsd/ exists), loader.ts prints a branded
ASCII logo and welcome message. Later, cli.ts unconditionally calls
printWelcomeScreen(), resulting in a duplicate banner.

Set GSD_FIRST_RUN_BANNER env flag in loader.ts after printing the
first-run banner. cli.ts now checks for this flag and skips the
welcome screen when it is already set.

The session-restart banner in register-hooks.ts is unaffected because
it only fires on non-first sessions (isFirstSession guard).

Closes #2245
2026-03-23 11:51:08 -06:00
Tom Boucher
f4ee51017a perf: startup optimizations — pre-compiled extensions, compile cache, batch discovery (#2125)
Skip jiti JIT compilation for bundled extensions that have pre-compiled .js
siblings, enable V8 bytecode caching on Node 22+, and batch directory
discovery to reduce syscalls during resource loading.

Fixes #2108

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-23 10:02:30 -06:00
Andrew
d93956ba4e feat(web): browser-based web interface (#1717)
* chore(M003/S01): auto-commit after plan-slice

* chore(M003/S01/T02): auto-commit after execute-task

* chore(M003/S01/T03): auto-commit after execute-task

* docs: queue M004 — web mode documentation and CI/CD integration

* chore(M003/S01/T04): auto-commit after execute-task

* chore(M003/S01): auto-commit after complete-slice

* chore(M003/S01): auto-commit after reassess-roadmap

* chore: production polish — real logo, remove scaffold remnants

- Replace placeholder 'G' box in header with real GSD logo icon SVG (currentColor, theme-aware)
- Delete 5 dead placeholder files (placeholder-logo.svg/png, placeholder-user.jpg, placeholder.jpg, placeholder.svg)
- Remove v0.app generator tag from layout metadata
- Remove unused @vercel/analytics dependency

* chore(M003/S02): auto-commit after research-slice

* chore(Q1): auto-commit after quick-task

* fix: remove duplicate parse cache block causing web mode boot failure

The 'Parse Cache' section in files.ts was duplicated (merge artifact),
causing 'Identifier CACHE_MAX has already been declared' when Node's
--experimental-strip-types loaded the file. This made /api/boot return
500, which caused waitForBootReady to time out and web mode launch to
fail with 'boot-ready:http 500'.

Removed the second (older) duplicate block, keeping the first one which
includes the improved mid-sample cache key.

* docs: add quick task summary and update STATE.md

* fix: replace sidebar icon+text with full logo image

Swap the inline SVG G-mark icon and 'GSD 2' text span in the app shell
header with an <img> referencing /logo-white.svg (the full GSD wordmark).
Removes the redundant text label. Sized at h-4 (16px) to fit the header.

* docs(S02): add slice plan

* chore: update state for S02 execution

* chore(M003/S02/T01): auto-commit after execute-task

* chore(M003/S02/T02): auto-commit after execute-task

* chore(M003/S02/T03): auto-commit after execute-task

* chore(M003/S02): auto-commit after complete-slice

* chore(M003/S02): auto-commit after reassess-roadmap

* chore(M003/S03): auto-commit after research-slice

* docs(S03): add slice plan

* chore(M003/S03/T01): auto-commit after execute-task

* chore(M003/S03/T02): auto-commit after execute-task

* chore(M003/S03/T03): auto-commit after execute-task

* chore(M003/S03): auto-commit after complete-slice

* chore(M003/S03): auto-commit after reassess-roadmap

* chore(M003/S04): auto-commit after research-slice

* docs(S04): add slice plan

* chore(M003/S04/T01): auto-commit after execute-task

* chore(M003/S04/T02): auto-commit after execute-task

* chore(M003/S04/T03): auto-commit after execute-task

* chore(M003/S04): auto-commit after complete-slice

* chore(M003/S04): auto-commit after reassess-roadmap

* chore(M003/S05): auto-commit after research-slice

* docs(S05): add slice plan

* chore(M003/S05/T01): auto-commit after execute-task

* chore(M003/S05/T02): auto-commit after execute-task

* chore(M003/S05): auto-commit after complete-slice

* chore(M003/S05): auto-commit after reassess-roadmap

* chore(M003/S06): auto-commit after research-slice

* docs: queue M005

* docs(S06): add slice plan

* chore(M003/S06/T01): auto-commit after execute-task

* chore(M003/S06/T02): auto-commit after execute-task

* chore(M003/S06): auto-commit after complete-slice

* chore(M003/S06): auto-commit after reassess-roadmap

* chore(M003/S07): auto-commit after research-slice

* docs(S07): add slice plan

* chore: update STATE.md for S07 execution

* chore(M003/S07/T01): auto-commit after execute-task

* chore(M003/S07/T02): auto-commit after execute-task

* chore(M003/S07/T03): auto-commit after execute-task

* chore(M003): record integration branch

* chore(M003/S07/T04): auto-commit after execute-task

* chore(M003/S07): auto-commit after complete-slice

* chore(M003/S07): auto-commit after reassess-roadmap

* chore(M003/S08): auto-commit after research-slice

* docs(S08): add slice plan

* chore(M003/S08/T01): auto-commit after execute-task

* chore(M003/S08/T02): auto-commit after execute-task

* chore(M003/S08): auto-commit after complete-slice

* chore(M003/S08): auto-commit after reassess-roadmap

* chore(M003/S09): auto-commit after research-slice

* docs(S09): add slice plan

* chore(M003/S09/T01): auto-commit after execute-task

* chore(M003/S09/T02): auto-commit after execute-task

* chore(M003/S09): auto-commit after complete-slice

* chore(M003): auto-commit after complete-milestone

* chore(M004): record integration branch

* chore: untrack .gsd/ runtime files from git index

* chore(M004): auto-commit after research-milestone

* feat(M006): multi-project workspace

- Bridge registry replacing singleton (Map<string, BridgeService> keyed by project path)
- resolveProjectCwd(request) for ?project= query param with env-var fallback
- All 26 API routes and 16 services threaded with project context
- Project discovery service scanning one directory level with smart detection
- /api/projects and /api/preferences routes
- ProjectStoreManager with per-project SSE lifecycle isolation
- Projects NavRail tab with kind badges and signal chips
- Onboarding dev root step (position 3, skippable)
- Context-aware launch detection (resolveContextAwareCwd)
- BootProjectInitializer for auto-registering boot project
- 25 new contract tests (8 bridge, 10 discovery, 7 launch)
- 1222 tests pass, both builds green

Squash-merged from milestone/M006 work on gsd/quick branch.
Includes M004 and M005 milestone artifacts.

* feat: add dev root setup in Projects view and Settings panel

- Projects view empty state now has inline dev root input with
  suggestion chips instead of just a text message
- Settings gear → Workspace tab shows dev root configuration
- /gsd prefs command surface includes dev root section at top
- PUT /api/preferences now merges with existing prefs (read-modify-write)
  instead of overwriting — fixes potential data loss of lastActiveProject
- Fixed pre-existing type issue: sectionLabel/sectionIcon Records use
  Partial<Record> to handle gsd-* sections that aren't in the map

* feat: native folder picker for dev root selection

- New /api/browse-directories?path= endpoint returns directory listings
  from the server filesystem (directories only, excludes dotfiles/node_modules)
- FolderPickerDialog component with directory browser: navigate folders,
  go up to parent, select current folder
- Projects view empty state shows 'Browse for Folder' button opening the picker
- Settings Workspace tab shows current path with 'Change' button opening picker
- Replaces text input approach — no more typing paths manually

* fix: move Projects icon to bottom of NavRail, above Git

Projects is a workspace-level navigation action, not a primary view.
Placing it in the bottom section alongside Git and Settings keeps
the top section focused on content views.

* feat: multi-project-aware exit dialog

When multiple projects are open, the exit button shows two options:
- Close current project (disconnects it, switches to another)
- Stop server (shuts down all projects and closes the tab)

With only one project open, shows the original simple 'Stop server' dialog.

Also adds closeProject(), getProjectCount(), and getActiveProjectPaths()
to ProjectStoreManager.

* feat: intercept browser tab close with confirmation and auto-shutdown

beforeunload triggers the browser's native 'Leave site?' confirmation
dialog when the user tries to close the tab. If they confirm, pagehide
fires sendBeacon to /api/shutdown, cleanly stopping all GSD instances.

* feat: remove session card from dashboard, fix beforeunload

- Removed the session card (model, cost, tokens, elapsed, auto mode,
  live tool/streaming indicators) from the dashboard right column
- Dashboard current slice section now takes full width
- Removed beforeunload handler (tab close silently shuts down via
  pagehide + sendBeacon instead of showing native browser dialog)
- Updated web-state-surfaces-contract test: removed assertion for
  activeToolExecution/streamingAssistantText in dashboard
- 1220/1221 tests pass (1 flaky context-store unrelated to changes)

* feat: show loading dialog when switching to a new project

When clicking a project that doesn't have a bridge instance yet,
a shadcn Dialog with a spinner and 'Opening [project]' message
appears instead of navigating to the dashboard with skeleton cards.
The dialog waits for the store's bootStatus to become 'ready' or
'error' (or 30s timeout) before navigating to the dashboard.

Clicking the already-active project navigates directly.

* feat: restore theme toggle and light/dark CSS from M005

M005's theme work was lost during the M006 squash merge (different
branch base). This restores:

- ThemeProvider in layout.tsx with class-based theming and FOIT prevention
- NavRail theme toggle cycling system → light → dark (Monitor/Sun/Moon icons)
- Light-mode :root CSS variables (monochrome oklch, inverted lightness)
- Dark .dark section with custom tokens (--success, --warning, --info,
  --terminal, --terminal-foreground, --code-line-number)
- suppressHydrationWarning on <html> for next-themes compatibility

* fix: switch logo between black/white variants based on theme

Uses paired dark:/hidden Tailwind classes — zero JS cost, no flash.

* chore: untrack .gsd/ runtime files from git index

* chore(Q2): auto-commit after quick-task

* feat(web): resizable milestone sidebar + rename tab title to GSD

- Add drag-to-resize handle on left edge of milestone sidebar
  (col-resize, 180-480px range, same pattern as terminal resize)
- Change document.title suffix from 'GSD 2' to 'GSD'
- Remove border-l from MilestoneExplorer (drag handle provides separation)

* docs: quick task 2 summary and state update

* feat: spawn GSD instance in right-side terminal, rename browser tab to GSD

- Add command option to PTY manager to spawn pi instead of default shell
- Thread command param through terminal API routes and ShellTerminal component
- DualTerminal right pane now launches a separate pi (GSD) instance
- Update header label to 'Right: Interactive GSD'
- Set browser tab title to 'GSD' instead of project folder name

* fix: use distinct default session ID for GSD terminal to avoid reusing stale zsh session

* fix: make shell terminal respect light/dark theme

- Add light xterm theme alongside existing dark theme
- Detect theme via next-themes useTheme and pass isDark to terminal instances
- Dynamically update xterm theme when user switches themes
- Replace all hardcoded dark bg colors (#0a0a0a, #0c0c0c, zinc-*) with
  theme-aware classes (bg-terminal, text-muted-foreground, etc.)

* feat: add loading spinner while terminal session initializes

* feat: replace left-side AutoTerminal with real GSD terminal instance

- Remove custom AutoTerminal React component
- Left side now runs a real pi terminal (sessionPrefix=gsd-main)
- Right side uses sessionPrefix=gsd-interactive for isolation
- Add sessionPrefix prop to ShellTerminal for distinct session IDs
- Update header labels: Left: Primary GSD | Right: Interactive GSD

* feat: auto-select STATE.md on files view initial load

* feat: pre-initialize dual terminal PTY sessions on boot

Keep DualTerminal always mounted (hidden when not active) so PTY
sessions spawn as soon as the bridge connects. Terminals are ready
immediately when the user switches to the power view.

* fix: move STATE.md auto-select effect after handleSelectFile declaration

Fixes TDZ ReferenceError — the useEffect was referencing handleSelectFile
before its useCallback declaration.

* chore(M006): record integration branch

* Squashed commit of the following:

commit e3f495a224f53e954798b6f96a59806db43bfdb0
Author: snowdamiz <yurlovandrew@gmail.com>
Date:   Tue Mar 17 16:12:50 2026 -0400

    chore: auto-commit before milestone merge

commit d9a0193c9c54fafcaff6bc0de7c169936f41b2df
Author: snowdamiz <yurlovandrew@gmail.com>
Date:   Tue Mar 17 08:35:53 2026 -0400

    chore: auto-commit before milestone merge

commit 010430059ca50c6b773ee4480e42d2c54a1c0b75
Author: snowdamiz <yurlovandrew@gmail.com>
Date:   Tue Mar 17 04:57:49 2026 -0400

    chore(M006): record integration branch

commit a6f6d0294c90a253585571a5a9615c7f3e41e7ea
Author: snowdamiz <yurlovandrew@gmail.com>
Date:   Tue Mar 17 04:57:36 2026 -0400

    docs: queue M006 — Multi-project workspace

commit b2dd57423835d132f6d3963abbb2bfc799e64100
Author: snowdamiz <yurlovandrew@gmail.com>
Date:   Tue Mar 17 03:43:52 2026 -0400

    chore(M005): record integration branch

# Conflicts:
#	.gsd/DECISIONS.md
#	.gsd/PROJECT.md
#	.gsd/REQUIREMENTS.md
#	.gsd/milestones/M006/M006-META.json
#	src/web/recovery-diagnostics-service.ts

* chore(M006): record integration branch

* feat(M006): Multi-Project Workspace

Completed slices:
- S01: Bridge registry and project-scoped API surface
- S02: Project discovery, Projects view, and store switching
- S03: Onboarding dev root step, context-aware launch, and final assembly

Branch: milestone/M006

* refactor(visualizer): redesign visualizer-view layout and tab structure

* docs(M007): context, requirements, and roadmap

* chore(M007): record integration branch

* docs(M007): rewrite roadmap and all slice plans to new template format

* chore(M007/S01/T01): auto-commit after execute-task

* chore(M007/S01/T02): auto-commit after execute-task

* chore(M007/S01): auto-commit after complete-slice

* chore(M007/S01): auto-commit after reassess-roadmap

* chore(M007/S02/T01): auto-commit after execute-task

* chore(M007/S02/T02): auto-commit after execute-task

* chore(M007/S02/T03): auto-commit after execute-task

* chore(M007/S02): auto-commit after complete-slice

* chore(M007/S02): auto-commit after reassess-roadmap

* chore(M007/S03/T01): auto-commit after execute-task

* chore(M007/S03/T02): auto-commit after execute-task

* chore(M007/S03): auto-commit after complete-slice

* chore(M007/S03): auto-commit after reassess-roadmap

* chore(M007/S04/T01): auto-commit after execute-task

* chore(M007/S04/T02): auto-commit after execute-task

* chore(M007/S04/T03): auto-commit after execute-task

* chore(M007/S04): auto-commit after complete-slice

* chore(M007): auto-commit after complete-milestone

* feat(M007): Chat Mode — Consumer-Grade GSD Interface

Completed slices:
- S01: PTY output parser and chat message model
- S02: Chat Mode view — main pane
- S03: TUI prompt intercept UI
- S04: Action toolbar and right panel lifecycle

Branch: milestone/M007

* feat(chat-mode): move Discuss to input bar

* fix(web): launch browser PTYs with GSD loader

* chore(M005): record integration branch

* feat(M005): Light Theme with System-Aware Toggle

Completed slices:
- S01: Theme foundation and NavRail toggle
- S02: Component color audit and visual verification

Branch: milestone/M005

* chore(M007): record integration branch

* feat(web): chat mode action bar, smart CTA, project-level status bar, centered visualizer tabs

- Chat input bar: top 3 buttons (Discuss, Next, Auto) + overflow menu with all /gsd subcommands grouped by category, tooltips on hover
- Action routing: main-panel commands (next, auto, stop, pause) vs action-panel commands (discuss, status, visualize, etc.)
- Removed Config, Hooks, Migrate, Inspect from action menu
- Smart placeholder CTA: derives contextual button from workspace state (New Milestone, Start Auto, Resume, Plan, etc.)
- Status bar: project-level totals (duration, tokens, cost) from visualizer API instead of session-scoped auto data
- Visualizer: centered tab bar

* docs(M008): context, requirements, and roadmap

* chore(M008): record integration branch

* chore(M008/S01): auto-commit after research-slice

* docs(S01): add slice plan

* chore(M008/S01/T01): auto-commit after execute-task

* chore(M008/S01/T02): auto-commit after execute-task

* chore(M008/S01): auto-commit after complete-slice

* chore(M008/S01): auto-commit after reassess-roadmap

* chore(M008/S02): auto-commit after research-slice

* docs(S02): add slice plan

* chore(M008/S02/T01): auto-commit after execute-task

* chore(M008/S02/T02): auto-commit after execute-task

* chore(M008/S02): auto-commit after complete-slice

* chore(M008/S02): auto-commit after reassess-roadmap

* chore(M008/S03): auto-commit after research-slice

* docs(S03): add slice plan

* chore(M008/S03/T01): auto-commit after execute-task

* chore(M008/S03/T02): auto-commit after execute-task

* chore(M008/S03/T03): auto-commit after execute-task

* chore(M008/S03): auto-commit after complete-slice

* chore(M008/S03): auto-commit after reassess-roadmap

* chore(M008/S04): auto-commit after research-slice

* docs(S04): add slice plan

* chore(M008/S04/T01): auto-commit after execute-task

* chore(M008/S04/T02): auto-commit after execute-task

* chore(M008/S04): auto-commit after complete-slice

* chore(M008/S04): auto-commit after reassess-roadmap

* chore(M008/S05): auto-commit after research-slice

* docs(S05): add slice plan

* chore(M008/S05/T01): auto-commit after execute-task

* chore(M008/S05/T02): auto-commit after execute-task

* chore(M008/S05): auto-commit after complete-slice

* chore(M008): auto-commit after complete-milestone

* feat(M008): Web Polish

Completed slices:
- S01: Projects Page Redesign
- S02: Browser Update UI
- S03: Theme Defaults & Light Mode Color Audit
- S04: Remote Questions Settings
- S05: Progress Bar Dynamics & Terminal Text Size

Branch: milestone/M008

* docs: project plan — 3 milestones (M009 editor, M010 upstream sync, M011 CI/CD+PWA)

* chore(M009): record integration branch

* chore(M009/S01): auto-commit after research-slice

* docs(S01): add slice plan

* chore(M009/S01/T01): auto-commit after execute-task

* chore(M009/S01/T02): auto-commit after execute-task

* chore(M009/S01): auto-commit after complete-slice

* chore(M009/S01): auto-commit after reassess-roadmap

* chore(M009/S02): auto-commit after research-slice

* docs(S02): add slice plan

* state: S02 executing, next T01

* chore(M009/S02/T01): auto-commit after execute-task

* chore(M009/S02/T02): auto-commit after execute-task

* chore: untrack .gsd/ runtime files from git index

* chore(M009/S04): auto-commit after plan-slice

* docs(S04): add slice plan

* feat(S04/T01): Added dual shiki theme loading (dark + light) driven by…

- web/components/gsd/file-content-viewer.tsx

* chore(M010): record integration branch

* chore(M011): record integration branch

* feat(S02/T01): Added dist/web/standalone/{server.js, public/manifest.js…

- scripts/validate-pack.js

* test(S02/T02): Created .github/workflows/web.yml with full web host CI…

- .github/workflows/web.yml

* fix gitignore

* chore: update .gitignore to match upstream, untrack ignored files

- Updated .gitignore to match upstream/main patterns
- Removed 498 tracked files now covered by .gitignore:
  - .gsd/ project state (milestones, plans, summaries, db files)
  - Stale lock files (bun.lock, root pnpm-lock.yaml, web/pnpm-lock.yaml)
- Preserved upstream-tracked files:
  - pkg/dist/core/export-html/ (negation rules)
  - packages/*/pnpm-lock.yaml (tracked upstream)

* feat(M011): PWA support — service worker, install prompt, CI workflow

Squash-merge of milestone/M011 branch.

- Serwist service worker integration with Next.js (sw.ts, sw-register.tsx)
- PWA manifest with standalone display mode and app icons
- Install prompt hook and dismissible banner component
- Web host CI workflow (.github/workflows/web.yml)
- Updated web/.gitignore for Serwist build artifacts
- validate-pack.js script addition

* refine .gitignore: track GSD project artifacts, ignore runtime state

* gitignore: restore full .gsd/ exclusion

* docs(M012): context, requirements, and roadmap

* feat(S01/T01): Squash-merged 443 upstream commits (v2.22→v2.31) into fo…

- .gitignore
- src/cli.ts
- src/resource-loader.ts
- src/resources/extensions/get-secrets-from-user.ts
- src/resources/extensions/gsd/workspace-index.ts
- package-lock.json

* chore: squash merge upstream/main (v2.22→v2.31)

Merges 443 upstream commits from v2.22 to v2.31.0. Resolves 12 conflict files. Preserves fork web-mode additions. Switches web build to webpack mode for NodeNext .js extension import compatibility.

* feat(S02/T01): Added a lowercase "beta" pill badge next to the GSD logo…

- web/components/gsd/app-shell.tsx

* feat(S03/T01): Branch FileContentViewer editable mode: non-markdown fil…

- web/components/gsd/file-content-viewer.tsx

* chore(S04/T01): Added image input pipeline for chat mode: drag-and-drop…

- web/lib/image-utils.ts
- web/components/gsd/chat-mode.tsx
- web/lib/pty-chat-parser.ts
- web/lib/gsd-workspace-store.tsx

* feat(S04/T02): Created /api/terminal/upload endpoint and wired drag-dro…

- web/app/api/terminal/upload/route.ts
- web/components/gsd/shell-terminal.tsx

* chore(S05/T01): Replaced left ShellTerminal with bridge-event Terminal…

- web/components/gsd/dual-terminal.tsx

* feat(S06/T01): Created GuidedDialog component wrapping ChatPane in a fu…

- web/components/gsd/guided-dialog.tsx
- web/components/gsd/project-welcome.tsx

* feat(S06/T02): Wired GuidedDialog into Dashboard with nullable state, o…

- web/components/gsd/dashboard.tsx

* merge upstream/main: sync with v2.31.2, resolve conflicts preserving fork web UI changes

- Version bumps: 2.31.0 → 2.31.2 across all packages
- Upstream refactors adopted: createGitService factory, dispatchUnit helper,
  STATE_REBUILD_MIN_INTERVAL_MS constant extraction, KNOWN_UNIT_TYPES centralization
- New upstream features merged: environment health checks, progress score,
  doctor providers, health widget, auto-reentrancy guard
- Fork-specific code preserved: web CLI branch, TTY check with --web hint,
  workspace index risk/depends/demo fields, dist-redirect web/ extensionless imports
- checkExistingEnvKeys moved inline (upstream deleted env-key-utils.ts)
- Fixed 5 pre-existing test failures: edit-mode slash command parity,
  gsd:web script assertion, dual-terminal store contract (moved to terminal.tsx)

* ci: consolidate web workflow into main CI pipeline

Moved web host install and build steps into the CI build job.
Removed the separate web.yml workflow.

* fix(tests): configure onboarding service in bridge/live tests for CI

Tests calling sendBridgeInput via the command route now configure
the onboarding service with in-memory auth storage. Without this,
collectOnboardingState() returns locked (no API key in CI env),
causing all command route calls to return HTTP 423.

* fix: CI and Windows portability for web mode tests

- cli.ts: early TTY check now skips when --web flag is set, allowing
  headless web mode launches in CI (fixes 5 runtime harness failures)
- auto-dashboard-service.ts: convert --import path to file:// URL via
  pathToFileURL() (fixes ERR_UNSUPPORTED_ESM_URL_SCHEME on Windows)
- web-mode-cli.test.ts: use resolve() for registry key lookups so
  Windows-normalized paths match (fixes registerInstance/unregisterInstance)
- web-mode-assembled.test.ts: configure onboarding service with
  in-memory auth for settings and slash-command tests (fixes 423 in CI)

* fix: Windows portability for all web service subprocess launchers

All 17 `--import` arguments across web service files now use
pathToFileURL().href instead of raw file paths. Node's --import
flag requires URL scheme on Windows (D:\ paths fail with
ERR_UNSUPPORTED_ESM_URL_SCHEME).

Affected services: auto-dashboard, recovery-diagnostics, hooks,
export, cleanup, forensics, history, settings, doctor, skill-health,
undo, visualizer, bridge, captures, cli-entry.

Also fixes:
- web-session-parity-contract: normalize git rev-parse output with
  resolve() for Windows backslash consistency

* fix: repair web recovery diagnostics CI failures

* test: align launched-host integration flows with current web UI

* fix(ci): stabilize packaged web onboarding flow

* feat(web): render main-session native TUI in power user mode

* Update web terminal parity and eslint setup

* Fix web lint and typecheck issues

* Normalize Power User terminal headers

* Restore Geist web font loading

* fix(web): update PWA app name and icon assets

* Remove web PWA functionality

* fix(web): scope terminal surfaces to active project

* feat(web): add project creation flow

* refactor(web): centralize workflow actions and simplify dashboard

* test(web): align packaged runtime integration flows

* fix: route dashboard/sidebar CTA commands through session API and handle RPC lock conflicts

Two bugs prevented the dashboard and sidebar workflow action buttons
(New Milestone, Start Auto, Initialize Project, etc.) from working:

1. Frontend: executeWorkflowActionInPowerMode sent commands via raw
   fetch to /api/bridge-terminal/input (PTY keystroke injection) instead
   of the session command pipeline (/api/session/command). The agent
   never received these commands. Refactored to accept a dispatch
   callback that callers wire through sendCommand(buildPromptCommand()).

2. Backend: guardRemoteSession in the /gsd extension called
   showNextAction() — an interactive TUI prompt — when it detected
   another session's lock. In RPC/web bridge mode this blocks forever
   since there is no terminal to answer the prompt. Now detects
   GSD_WEB_BRIDGE_TUI=1 and emits an actionable warning notification
   instead of blocking.

Files changed:
- web/lib/workflow-action-execution.ts (dispatch callback instead of raw fetch)
- web/components/gsd/dashboard.tsx (pass store-backed dispatch)
- web/components/gsd/sidebar.tsx (MilestoneExplorer + CollapsedMilestoneSidebar)
- src/resources/extensions/gsd/commands.ts (RPC-mode guard in guardRemoteSession)

* fix: terminal drag-drop image upload, Shift+Enter newline, and chat mode unified response bubble

Bug 1 - Power Mode drag-drop: Dropping images on either terminal pane
opened the file in a new tab instead of uploading. Fixed by switching
all drag/drop handlers to native DOM capture-phase listeners (React
synthetic events don't reliably fire through xterm's internal DOM).
Both panes now upload images via /api/terminal/upload and inject
@filepath into the terminal input. DualTerminal wrapper prevents
browser default file-navigation as a safety net.

Bug 2 - Chat Mode dual response: During streaming, the assistant
response and thinking indicator rendered as two separate UI blocks.
Fixed by moving thinking content inline into the assistant ChatBubble
via a new InlineThinking component. Removed the standalone
ThinkingIndicator. Thinking text now appears as a collapsible section
above the response text within the same bubble.

Bug 3 - Shift+Enter newline: xterm.js sends \r for both Enter and
Shift+Enter, but pi's TUI editor expects \n (LF) for newline
insertion. Added native DOM capture-phase keydown listeners on both
MainSessionTerminal and ShellTerminal that intercept Shift+Enter,
preventDefault to block xterm, and send \n through the input channel.

* chore: update lockfile and tsbuildinfo

* refactor: remove right-side action panel, route all commands through main bridge

- Remove ActionPanel, StructuredTerminalActionPane, and all PTY screen-scraping
  infrastructure (~700 lines deleted: stripTerminalChrome, isScreenChromeLine,
  normalizeScreenLine, beautifyParsedScreenContent, parseStructuredTerminalScreen,
  SCREEN_* constants, hidden xterm.js terminal buffer)

- All /gsd subcommands now dispatch through the main bridge session via
  sendCommand(buildPromptCommand()). No separate PTY instances.

- Add disabledDuringAuto flag to GSDActionDef. Commands that inject competing
  LLM prompts are disabled while auto-mode runs:
  - discuss: calls dispatchWorkflow -> pi.sendMessage (would conflict with auto)
  - triage: injects triage prompt via pi.sendMessage (same conflict)
  - All other commands verified safe: stop/pause control auto, steer explicitly
    handles auto with HARD STEER message, capture/knowledge/skip are file IO,
    status/queue/history/visualize are read-only, mode/prefs/doctor/export/
    cleanup/remote are config/maintenance

- Add inline PendingUiRequest rendering in ChatPane: select (single + multi),
  confirm, input, and editor requests appear as interactive chat bubbles in the
  message flow with native clickable controls and post-submission confirmation

- Wire FocusedPanel in app-shell.tsx as fallback overlay for pendingUiRequests
  in non-chat views (dashboard, power mode, files, etc.)

- Remove unused imports: AnimatePresence, motion, buildProjectAbsoluteUrl,
  buildProjectPath, HeadlessTerminal type, compact prop

* chore: gitignore tsbuildinfo files

* onboarding overhaul: add mode, project, and remote steps; refactor existing steps

- Add step-mode.tsx for user/dev mode selection
- Add step-project.tsx for project selection/creation
- Add step-remote.tsx for remote repository configuration
- Add use-user-mode.ts hook for mode state management
- Add /api/dev-mode route for dev mode toggle
- Refactor onboarding-gate.tsx flow and step sequencing
- Refactor step-authenticate, step-dev-root, step-optional,
  step-provider, step-ready, step-welcome with updated styling
- Update command-surface, app-shell, dashboard integrations
- Update dev-overrides and workflow-action-execution

* overhaul projects view, simplify boot readiness, add requireProjectCwd

- Redesign projects-view with Sheet/Dialog components and improved styling
- Simplify waitForBootReady: remove bridge phase tracking, return on first successful response
- Boot route returns minimal no-project payload when no project is configured
- Rename resolveProjectCwd → requireProjectCwd across all API routes
- Minor UI adjustments in app-shell, sidebar, terminal

* fix: update tests for upstream merge and UI refactor

Unit tests (7 fixes, 2133/2133 pass):
- smart-entry-complete: match upstream's chooser-based complete flow
- web-bridge-contract: add projectDetection to boot snapshot keys
- web-command-parity: await async registerExtension (upstream decomposition)
- web-mode-cli: update gsd:web script expectation (copy-resources added)
- web-state-surfaces: match refactored editorTextBuffer consumption
- web-workflow-action-execution: match new dispatch-based API, stub localStorage
- web-mode.ts: restore GSD_WEB_PROJECT_CWD in spawn env

Integration tests:
- web-mode-onboarding: simplify to API-only contract (locked→reject→retry→unlocked)
  without fragile browser UI assertions that depend on refactored wizard flow

* Clean up dashboard header and redesign project selection gate

- Simplify dashboard header: inline scope badge with title, remove
  workflow action buttons and status indicators
- Redesign project selection gate: center logo with subtitle, remove
  header bar and side gutters, cleaner layout
- Remove web-mode-runtime integration test

* settings: consolidate tabs, add General panel with font size controls

- Add General tab (terminal font size + code font size) as default settings landing
- Merge Thinking into Model tab (model selection + thinking level in one panel)
- Merge Queue + Compaction + Retry into Session tab (all session behavior knobs)
- Reduce settings nav from 8 tabs to 6 (+ admin when dev mode)
- Legacy section routes (thinking, queue, compaction, retry) still render correctly
- gsd-prefs mega-scroll uses GeneralPanel instead of separate Terminal/Editor panels

* fix: file explorer & visualizer use selected project context, resizable tree panel

- Route all fetch calls in files-view, visualizer-view, and status-bar
  through buildProjectUrl() so they respect the active project selection
  instead of falling back to GSD_WEB_PROJECT_CWD (server startup project)
- Make file explorer tree panel resizable (180-480px) with drag handle,
  matching the milestone sidebar resize pattern

* feat(web): file explorer Agent tab, merged headers, unified chat timeline

- Merge file path display + save button into single header row (3 layers → 2)
- Add Agent tab to file explorer left panel with embedded ChatPane
- Auto-open files in viewer when agent executes edit/write tools
- Show inline diff (red/green lines) for agent-edited files with auto-dismiss
- MD files default to Edit tab when agent-opened so raw changes are visible
- Unified chat timeline: tool executions render inline where they happen,
  not stacked at the bottom
- Persist user messages in workspace store so they survive tab switches
- Shorten chat input placeholder to 'Message…', remove hint text

* feat(chat): persist thinking blocks and render in chronological order

- Add TurnSegment type to track thinking/text/tool events in order
- Finalize streaming content into segments at phase transitions
  (thinking→text, text→thinking, tool start/end, turn boundary)
- Store completedTurnSegments parallel to liveTranscript for history
- Rebuild chat timeline from segments so thinking blocks render
  in their correct position between text and tool calls
- Thinking blocks now persist after streaming ends (collapsible)
- Restyle InlineThinking to monochrome (muted-foreground) — removes
  amber/warning colors for consistency with dark theme

* feat(web): add Integrations tab to settings panel for remote channel config

* feat(web): bot token input in settings and onboarding, card-based integrations panel

- Add PATCH endpoint to /api/remote-questions for saving bot tokens
  to ~/.gsd/agent/auth.json (same storage as TUI key manager)
- Redesign RemoteQuestionsPanel: card-based channel picker, inline
  token input with show/hide toggle, collapsible advanced settings,
  connected state banner with disconnect
- Add bot token input to onboarding StepRemote with same PATCH flow
- Remove 'configure via TUI or environment' messaging — web UI now
  handles the full setup end-to-end

* fix(web): address PR #1717 security review feedback

Security (blocking):
- Add bearer token auth to all API routes via Next.js middleware
- Generate random token at launch, pass to browser via URL fragment
- Add Origin/CORS validation rejecting cross-origin API requests
- Whitelist PTY commands (gsd, user shell, /bin/bash, /bin/zsh, /bin/sh)
- Restrict /api/browse-directories to devRoot scope

Cleanup:
- Move shiki, react-markdown, remark-gfm from root to web/package.json
- Remove as-any casts in input-controller.ts (extend host type properly)
- Add extensions_ready signal to RPC mode (fixes void bindExtensions race)
- Add test fixture dummy keys to .secretscanignore (fixes CI lint)

* fix(web): resolve Next.js 16 build warnings

- Rename middleware.ts → proxy.ts with proxy() export (Next.js 16 convention)
- Add @gsd/native to webpack externals (fixes package path resolution warning)
- Hide require fallback from webpack static analysis in pty-manager (fixes
  critical dependency warning)

* fix(web): pass auth token to boot readiness probe

The readiness probe hits /api/boot to check server startup, but the
proxy now requires a bearer token. Thread the authToken through
waitForBootReady → requestLocalJson so the probe authenticates.

* chore: sync lockfiles after moving deps to web/package.json

* fix(test): update web-mode-cli test for auth token in browser URL

The test asserted the exact opened URL, which now includes a random
auth token fragment. Updated to pattern-match the token and verify
GSD_WEB_AUTH_TOKEN is passed consistently in the spawn env.

* fix(test): pass auth token in web-mode-onboarding integration test

The runtime harness now extracts the auth token from the browser-open
stub log and exposes it on RuntimeLaunchResult.authToken. Added
runtimeAuthHeaders() helper. Updated the onboarding test to pass
Authorization headers on all fetch calls and waitForHttpOk.

* fix(test): match renamed nextMilestoneIdReserved in smart-entry-complete test

Upstream #1569 renamed nextMilestoneId → nextMilestoneIdReserved.
Updated the regex assertion to accept both names.

* feat(web): support GSD_WEB_ALLOWED_ORIGINS for secure tunnel setups

Adds a comma-separated GSD_WEB_ALLOWED_ORIGINS env var that merges
additional origins into the CORS allowlist. Defaults to localhost-only
when unset. Enables Tailscale Serve, Cloudflare Tunnel, ngrok, etc.
2026-03-21 12:16:54 -06:00
Jeremy McSpadden
1b6b16f2d5 feat: feat(ui): minimal GSD welcome screen on startup (#1584)
* feat(ui): add GSD welcome screen on interactive startup

Renders a two-panel boxed welcome screen to stderr before the TUI
takes over, mirroring the style of the Claude Code welcome screen.

Left panel  — personalized greeting, GSD ASCII logo, active model + cwd
Right panel — getting-started tips, recent session activity

The screen is printed to stderr immediately before InteractiveMode.run(),
so it appears on launch and reappears when the TUI exits (alternate-screen
buffer swap). It silently skips when not a TTY or terminal < 60 cols.

Files:
  src/welcome-screen.ts          — printWelcomeScreen() implementation
  src/cli.ts                     — call site before interactiveMode.run()
  src/tests/welcome-screen.test.ts — 11 unit tests (all passing)

* refactor(ui): minimal welcome screen — logo + metadata, no box

Replace two-panel boxed layout with a minimal design:
logo block with version/model/cwd alongside it, dim hint below.
No box borders, no tips panel. Clean and fast.

* feat(ui): show tool status line (Brave/Jina/Tavily) when keys are configured
2026-03-20 08:11:06 -06:00
Tom Boucher
8aa71bfb55 fix: prevent ensureGitignore from adding .gsd when tracked in git (#1364) (#1367)
* rfc: GitOps branching & versioning strategy proposal

Proposes a Git-Flow Lite model with automated integration branches:

  main          ← production-ready, tagged releases only
  next          ← integration branch for next minor (PRs target here)
  release/X.Y   ← stabilization branch, only bugfixes allowed
  hotfix/X.Y.Z  ← emergency fixes cherry-picked to release

Includes:
  - RFC document with lifecycle diagrams, migration path, open questions
  - Workflow scaffolds (in docs/proposals/workflows/, NOT .github/):
    - create-release.yml: manual dispatch to cut release branch from next
    - sync-next.yml: auto-sync next branch after version tags
    - backmerge.yml: auto back-merge release fixes to next

This is an experimental proposal requesting community feedback before
any implementation. The workflow files are inert scaffolds — they do
not run in CI.

* fix: prevent ensureGitignore from adding .gsd when tracked in git (#1364)

CRITICAL DATA-LOSS FIX: ensureGitignore() unconditionally added '.gsd' to
.gitignore even when .gsd/ was a real git-tracked directory, causing git to
report ~889 tracked files as deleted.

Root cause: BASELINE_PATTERNS included '.gsd' unconditionally, and the
gitignore modification ran BEFORE migration checks in auto-start.ts.

Changes:
- Add hasGitTrackedGsdFiles() helper using nativeLsFiles to detect tracked
  .gsd/ content
- ensureGitignore() now skips the '.gsd' pattern when .gsd/ has tracked files
- untrackRuntimeFiles() now skips entirely when .gsd/ has tracked files
- migrateToExternalState() aborts when .gsd/ has tracked files
- Reorder auto-start.ts: migration runs BEFORE gitignore modification
- Add 8 regression tests covering all scenarios

Fixes #1364

* fix: break recursive dialog loop when all milestones complete (#1348)

Two interacting bugs:

1. Recursive dialog loop: When all milestones are complete, bootstrapAutoSession
   calls showSmartEntry → sets pendingAutoStart → checkAutoStartAfterDiscuss
   calls startAuto → bootstrapAutoSession → showSmartEntry → infinite loop.
   The discuss workflow completes without producing a milestone directory, so
   phase stays 'complete' and the cycle never breaks.

   Fix: Add a re-entry counter (_consecutiveCompleteBootstraps) that tracks
   how many times bootstrapAutoSession enters the 'complete' branch without
   advancing. After 2 consecutive attempts, break the loop with a warning
   message and return false.

2. Missing _releaseFunction = null in retry lock onCompromised handler:
   The retry lock path in session-lock.ts set _lockCompromised but didn't
   null out _releaseFunction, which could leave a stale reference that
   masks the compromise detection in validateSessionLock().

Fixes #1348

* fix: self-heal stale roadmap checkbox for interrupted complete-slice (#1350)

When complete-slice is interrupted after writing SUMMARY.md and UAT.md but
before flipping the roadmap checkbox, auto-mode enters an infinite loop —
re-launching the same complete-slice unit because the dispatch loop uses
the roadmap checkbox as the sole 'slice done' signal.

Fix: Add a self-heal case in selfHealRuntimeRecords that detects when
SUMMARY + UAT exist but the roadmap checkbox is unchecked, and auto-fixes
the checkbox. This allows the verification to pass and the dispatch loop
to advance.

Fixes #1350

* fix: add EISDIR guard to complete/validate milestone prompts (#1343)

The LLM was passing tasks/ directory paths to the read tool during
milestone completion, causing EISDIR crashes. Added file system safety
instructions to both complete-milestone and validate-milestone prompts
telling the LLM to use ls/find for directory listing, not the read tool.

Fixes #1343

* feat: improve extension conflict messages with removal guidance (#1347)

When a user extension registers tools/commands that now ship as built-ins,
the conflict message now includes '(built-in tool supersedes — consider
removing <path>)' and the log level is downgraded from 'Extension load error'
to 'Extension conflict'.

Changes:
- resource-loader.ts: detect built-in vs user extension conflicts, add hint
- cli.ts: downgrade severity for superseded-tool conflicts

Fixes #1347

* test: fix always-skipped preferences test, add test:marketplace script

- preferences.test.ts: Replace always-skipped getIsolationMode test with
  a filesystem-independent version that validates the default through
  validatePreferences() instead of reading ~/.gsd/preferences.md.
  Reduces skipped count from 3 → 2.

- package.json: Add test:marketplace script for running marketplace
  contract tests (claude-import-tui, plugin-importer-live,
  marketplace-discovery) with GSD_TEST_CLONE_MARKETPLACES=1.
  These tests need external repos and self-skip in unit test runs.

Remaining 2 skips:
- Marketplace contract test suites (need external repos, run via test:marketplace)
- Windows-only tests in validate-directory.test.ts are platform-conditional
  and correctly skip on macOS

* fix: use execFileSync in regression tests for Windows portability

The regression tests used execSync with shell-dependent constructs:
- '&&' command chaining (works in bash/cmd but fragile)
- Single-quoted commit messages (bash-only, cmd.exe splits on spaces)

Replaced with execFileSync via a git() helper that bypasses the shell
entirely. Each git operation is a separate call with proper argument
arrays, eliminating all shell interpretation issues.

Fixes windows-portability CI failure.

* fix: guard milestone completion against missing slice summaries (#1368)

Auto-mode could report a milestone as complete after executing only the
last slice, skipping earlier unexecuted slices. The milestone completion
signal fired based on roadmap checkbox state, which could be stale or
inconsistent after worktree transitions.

Changes:
- auto-dispatch.ts: Added slice SUMMARY file existence check to both
  validating-milestone and completing-milestone dispatch rules. If any
  slice lacks a SUMMARY file, dispatch stops with a diagnostic error
  instead of proceeding to validation/completion.
- validate-milestone.test.ts: Updated tests to create slice summary
  files (required by the new guard).
- file-watcher.test.ts: Fixed flaky 'auth.json change emits auth-changed
  event' test by adding watcher initialization delay and increasing event
  propagation timeout (race condition when run in full suite).

Fixes #1368

* fix: warn on common misspelled preference keys + verify field guidance (#1373, #1341)

#1373: Users setting 'taskIsolation.mode: none' instead of 'git.isolation: none'
got a generic 'unknown key' warning. Added KEY_MIGRATION_HINTS that map common
misspellings (taskIsolation, task_isolation, isolation, manage_gitignore, auto_push,
main_branch) to their correct git.* equivalents with actionable messages.

#1341: Planning agent writes aspirational prose in Verify fields ('Sections 3.1
and 3.2 exist with exact formulas. Zero TBD.') instead of executable commands.
Added explicit verify field rules to the plan template: must be mechanically
executable, with examples of good vs bad patterns for content tasks.

Fixes #1373, partially addresses #1341

* refactor: extract roadmap-mutations.ts + shared test-utils.ts

Consolidation:
- roadmap-mutations.ts: Extracted markSliceDoneInRoadmap() and markTaskDoneInPlan()
  from duplicated implementations in doctor.ts, mechanical-completion.ts, and
  auto-recovery.ts. All three callers used identical regex patterns.
  mechanical-completion.ts and auto-recovery.ts now import the shared utility.
  (doctor.ts deferred — touched by PR #1349)

- test-utils.ts: Shared cross-platform test utilities for GSD extension tests.
  Provides git() helper (execFileSync, no shell), makeTempRepo() with
  core.autocrlf=false, cleanup(), createFile(), safeReadFile(), and
  writeMilestoneFixture(). 12 test files currently define their own versions
  of these helpers — new tests should import from test-utils.ts instead.

Security audit: No injection vectors (sid/tid are alphanumeric from roadmap
parser), no path traversal, no secrets, no new dependencies.

* fix: port conflict false positive on non-Node projects + paused worktree resume (#1381, #1383)

projects without package.json. macOS AirPlay Receiver listens on port 5000,
causing a spurious warning on non-Node projects.
Fix: Skip port checks entirely when no package.json exists. When using
default ports, filter out 5000 on macOS.

in-memory only. Re-entering /gsd started a fresh bootstrap from the project
root instead of the active worktree.
Fix: pauseAuto() now writes paused-session.json to .gsd/runtime/ with
milestoneId, worktreePath, originalBasePath, and stepMode. startAuto()
checks for this file before bootstrap and restores the paused session
context, including worktree re-entry. stopAuto() cleans up the file.

Fixes #1381, #1383

* fix: catch spawn ENOENT in uncaught exception guard + snapshot session lock path (#1384, #1363)

uncaught exception and crashes auto-mode. The EPIPE guard now also catches
ENOENT from spawn syscalls — logs the error and continues instead of
terminating the process.

the lock path differently via gsdRoot() because basePath could be either the
project root or a worktree path. gsdRoot() produces different results for
each, so the lock was written to one path and validated against another.
Fix: Snapshot the resolved lock path (_snapshotLockPath) at acquisition time
and reuse it for all subsequent lock operations within the session.

Fixes #1384, #1363

* fix: suppress false-positive lock compromise + skip migration with active worktrees (#1362, #1337)

because the event loop stall delays the heartbeat mtime update. The handler
now checks elapsed time since acquisition — if within the 30-minute stale
window, it logs a warning and continues instead of setting _lockCompromised.
Real takeovers (past the stale window) still trigger the compromise flag.

even when .gsd/worktrees/ contained active git worktrees with locked
directory handles. This caused EBUSY errors and destructive data loss.
Migration now checks for active worktree directories and skips entirely
if any are found.

Fixes #1362, #1337
2026-03-19 17:06:01 -06:00
Jeremy McSpadden
d7bf3d4e72 Improve startup performance with lazy extension loading (#1336) 2026-03-19 07:38:50 -06:00