From f0059a54980b62b0e9792669e309387e7d821733 Mon Sep 17 00:00:00 2001 From: Jeremy McSpadden Date: Tue, 31 Mar 2026 12:54:41 -0500 Subject: [PATCH] fix(extensions): update provides.hooks in 7 extension manifests to match actual registrations (#3157) Audit found that 7 bundled extensions had incomplete provides.hooks arrays in their manifests. Updated each to match actual pi.on() calls: - async-jobs: +session_before_switch, session_shutdown - bg-shell: +8 hooks (session_compact, session_tree, etc.) - browser-tools: +session_start - context7: +session_shutdown - google-search: +session_shutdown - gsd: +12 hooks (bash_transform, tool_call, tool_result, etc.) - search-the-web: +session_start Closes #3156 --- .../async-jobs/extension-manifest.json | 2 +- .../extensions/bg-shell/extension-manifest.json | 2 +- .../browser-tools/extension-manifest.json | 2 +- .../extensions/context7/extension-manifest.json | 2 +- .../google-search/extension-manifest.json | 2 +- .../extensions/gsd/extension-manifest.json | 17 ++++++++++++++++- .../search-the-web/extension-manifest.json | 2 +- 7 files changed, 22 insertions(+), 7 deletions(-) diff --git a/src/resources/extensions/async-jobs/extension-manifest.json b/src/resources/extensions/async-jobs/extension-manifest.json index d849a5cab..edb516dd7 100644 --- a/src/resources/extensions/async-jobs/extension-manifest.json +++ b/src/resources/extensions/async-jobs/extension-manifest.json @@ -8,6 +8,6 @@ "provides": { "tools": ["async_bash", "await_job", "cancel_job"], "commands": ["jobs"], - "hooks": ["session_start"] + "hooks": ["session_start", "session_before_switch", "session_shutdown"] } } diff --git a/src/resources/extensions/bg-shell/extension-manifest.json b/src/resources/extensions/bg-shell/extension-manifest.json index 952ed8ace..ba2700935 100644 --- a/src/resources/extensions/bg-shell/extension-manifest.json +++ b/src/resources/extensions/bg-shell/extension-manifest.json @@ -8,7 +8,7 @@ "provides": { "tools": ["bg_shell"], "commands": ["bg"], - "hooks": ["session_shutdown"], + "hooks": ["session_shutdown", "session_compact", "session_tree", "session_switch", "before_agent_start", "session_start", "turn_end", "agent_end", "tool_execution_end"], "shortcuts": ["Ctrl+Alt+B"] } } diff --git a/src/resources/extensions/browser-tools/extension-manifest.json b/src/resources/extensions/browser-tools/extension-manifest.json index f6156ebbd..40218a31b 100644 --- a/src/resources/extensions/browser-tools/extension-manifest.json +++ b/src/resources/extensions/browser-tools/extension-manifest.json @@ -29,7 +29,7 @@ "browser_visual_diff", "browser_zoom_region", "browser_generate_test", "browser_action_cache", "browser_check_injection" ], - "hooks": ["session_shutdown"] + "hooks": ["session_start", "session_shutdown"] }, "dependencies": { "runtime": ["playwright"] diff --git a/src/resources/extensions/context7/extension-manifest.json b/src/resources/extensions/context7/extension-manifest.json index e95788267..d5bf3098e 100644 --- a/src/resources/extensions/context7/extension-manifest.json +++ b/src/resources/extensions/context7/extension-manifest.json @@ -7,6 +7,6 @@ "requires": { "platform": ">=2.29.0" }, "provides": { "tools": ["resolve_library", "get_library_docs"], - "hooks": ["session_start"] + "hooks": ["session_start", "session_shutdown"] } } diff --git a/src/resources/extensions/google-search/extension-manifest.json b/src/resources/extensions/google-search/extension-manifest.json index b2938627d..c4a775a4d 100644 --- a/src/resources/extensions/google-search/extension-manifest.json +++ b/src/resources/extensions/google-search/extension-manifest.json @@ -7,6 +7,6 @@ "requires": { "platform": ">=2.29.0" }, "provides": { "tools": ["google_search"], - "hooks": ["session_start"] + "hooks": ["session_start", "session_shutdown"] } } diff --git a/src/resources/extensions/gsd/extension-manifest.json b/src/resources/extensions/gsd/extension-manifest.json index 2c01ab4ee..ca0063a5f 100644 --- a/src/resources/extensions/gsd/extension-manifest.json +++ b/src/resources/extensions/gsd/extension-manifest.json @@ -12,7 +12,22 @@ "gsd_requirement_update", "gsd_milestone_generate_id" ], "commands": ["gsd", "kill", "worktree", "exit"], - "hooks": ["session_start", "session_switch"], + "hooks": [ + "session_start", + "session_switch", + "bash_transform", + "session_fork", + "before_agent_start", + "agent_end", + "session_before_compact", + "session_shutdown", + "tool_call", + "tool_result", + "tool_execution_start", + "tool_execution_end", + "model_select", + "before_provider_request" + ], "shortcuts": ["Ctrl+Alt+G"] } } diff --git a/src/resources/extensions/search-the-web/extension-manifest.json b/src/resources/extensions/search-the-web/extension-manifest.json index 582c341d8..b17107d76 100644 --- a/src/resources/extensions/search-the-web/extension-manifest.json +++ b/src/resources/extensions/search-the-web/extension-manifest.json @@ -8,6 +8,6 @@ "provides": { "tools": ["search-the-web", "fetch_page", "search_and_read", "web_search"], "commands": ["search-provider"], - "hooks": ["model_select", "before_provider_request"] + "hooks": ["session_start", "model_select", "before_provider_request"] } }