singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: add main_branch preference tests to git-service

Browse source 
Covers VALID_BRANCH_NAME regex validation, configured preference
returns correctly, fallback to auto-detection, and injection rejection.

Closes #108

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Lex Christopherson 2026-03-12 14:14:26 -06:00
parent 9200401e55
commit ea1dbd26f5
1 changed files with 63 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

63
src/resources/extensions/gsd/tests/git-service.test.ts
View file

@ -7,6 +7,7 @@ import {
inferCommitType,
GitServiceImpl,
RUNTIME_EXCLUSION_PATHS,
VALID_BRANCH_NAME,
runGit,
type GitPreferences,
type CommitOptions,
@ -1230,6 +1231,68 @@ async function main(): Promise<void> {
rmSync(repo, { recursive: true, force: true });
}
// ─── VALID_BRANCH_NAME regex ──────────────────────────────────────────
console.log("\n=== VALID_BRANCH_NAME regex ===");
{
// Valid branch names
assert(VALID_BRANCH_NAME.test("main"), "VALID_BRANCH_NAME accepts 'main'");
assert(VALID_BRANCH_NAME.test("master"), "VALID_BRANCH_NAME accepts 'master'");
assert(VALID_BRANCH_NAME.test("develop"), "VALID_BRANCH_NAME accepts 'develop'");
assert(VALID_BRANCH_NAME.test("feature/foo"), "VALID_BRANCH_NAME accepts 'feature/foo'");
assert(VALID_BRANCH_NAME.test("release-1.0"), "VALID_BRANCH_NAME accepts 'release-1.0'");
assert(VALID_BRANCH_NAME.test("my_branch"), "VALID_BRANCH_NAME accepts 'my_branch'");
assert(VALID_BRANCH_NAME.test("v2.0.1"), "VALID_BRANCH_NAME accepts 'v2.0.1'");
// Invalid / injection attempts
assert(!VALID_BRANCH_NAME.test("main; rm -rf /"), "VALID_BRANCH_NAME rejects shell injection");
assert(!VALID_BRANCH_NAME.test("main && echo pwned"), "VALID_BRANCH_NAME rejects && injection");
assert(!VALID_BRANCH_NAME.test(""), "VALID_BRANCH_NAME rejects empty string");
assert(!VALID_BRANCH_NAME.test("branch name"), "VALID_BRANCH_NAME rejects spaces");
assert(!VALID_BRANCH_NAME.test("branch`cmd`"), "VALID_BRANCH_NAME rejects backticks");
assert(!VALID_BRANCH_NAME.test("branch$(cmd)"), "VALID_BRANCH_NAME rejects $() subshell");
}
// ─── getMainBranch: configured main_branch preference ──────────────────
console.log("\n=== getMainBranch: configured main_branch ===");
{
const repo = initBranchTestRepo();
const svc = new GitServiceImpl(repo, { main_branch: "trunk" });
assertEq(svc.getMainBranch(), "trunk", "getMainBranch returns configured main_branch preference");
rmSync(repo, { recursive: true, force: true });
}
// ─── getMainBranch: falls back to auto-detection when not set ──────────
console.log("\n=== getMainBranch: fallback to auto-detection ===");
{
const repo = initBranchTestRepo();
const svc = new GitServiceImpl(repo, {});
assertEq(svc.getMainBranch(), "main", "getMainBranch falls back to auto-detection when main_branch not set");
rmSync(repo, { recursive: true, force: true });
}
// ─── getMainBranch: ignores invalid branch names ───────────────────────
console.log("\n=== getMainBranch: ignores invalid branch name ===");
{
const repo = initBranchTestRepo();
const svc = new GitServiceImpl(repo, { main_branch: "main; rm -rf /" });
assertEq(svc.getMainBranch(), "main", "getMainBranch ignores invalid branch name and falls back to auto-detection");
rmSync(repo, { recursive: true, force: true });
}
// ─── PreMergeCheckResult type export compile check ─────────────────────
console.log("\n=== PreMergeCheckResult type export ===");