From e18a0001bbfa84426b22326c2773bfb13130e113 Mon Sep 17 00:00:00 2001 From: Mikael Hugo Date: Mon, 11 May 2026 14:12:11 +0200 Subject: [PATCH] refactor(sf-ext): remove local sfHome() clone in preferences.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit preferences.js had its own copy of sfHome() (without resolve() canonicalization). Replace with import from sf-home.js — single source of truth. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/resources/extensions/sf/preferences.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/resources/extensions/sf/preferences.js b/src/resources/extensions/sf/preferences.js index 8822f6c19..109fcf731 100644 --- a/src/resources/extensions/sf/preferences.js +++ b/src/resources/extensions/sf/preferences.js @@ -10,11 +10,11 @@ * statements continue to work without modification. */ import { existsSync, readFileSync } from "node:fs"; -import { homedir } from "node:os"; import { dirname, join, resolve } from "node:path"; import { normalizeStringArray } from "@singularity-forge/coding-agent"; import { parse as parseYaml } from "yaml"; import { sfRoot } from "./paths.js"; +import { sfHome } from "./sf-home.js"; import { _initPrefsLoader, resolveProfileDefaults as _resolveProfileDefaults, @@ -70,9 +70,6 @@ export { } from "./preferences-models.js"; // ─── Path Constants & Getters ─────────────────────────────────────────────── -function sfHome() { - return process.env.SF_HOME || join(homedir(), ".sf"); -} /** * Return the canonical path to the SF agent settings file (~/.sf/agent/settings.json).