singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: prevent crash when cancelling OAuth provider login dialog (#821) (#831)

Browse source 
OAuthSelectorComponent calls its onSelect callback synchronously (no
await), but the callback was async — calling showLoginDialog which
throws 'Login cancelled' on Escape. The unhandled rejection bubbled
up to the uncaughtException handler and crashed GSD.

Wrap the async work in a named function with .catch() so cancellation
errors are swallowed gracefully. showLoginDialog already handles its
own error display internally.
This commit is contained in:
Tom Boucher 2026-03-17 09:49:09 -04:00 • committed by GitHub
parent 776a8800d8
commit d94728aa7e
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/pi-coding-agent/src/modes/interactive/interactive-mode.ts
View file

@ -3883,12 +3883,16 @@ export class InteractiveMode {
const selector = new OAuthSelectorComponent(
mode,
this.session.modelRegistry.authStorage,
async (providerId: string) => {
(providerId: string) => {
done();
if (mode === "login") {
await this.showLoginDialog(providerId);
} else {
// OAuthSelectorComponent calls this synchronously (no await),
// so we must catch async errors here to prevent unhandled rejections
// when the user cancels the login dialog (#821).
const handleAsync = async () => {
if (mode === "login") {
await this.showLoginDialog(providerId);
} else {
// Logout flow
const providerInfo = this.session.modelRegistry.authStorage
.getOAuthProviders()
@ -3919,6 +3923,11 @@ export class InteractiveMode {
this.showError(`Logout failed: ${error instanceof Error ? error.message : String(error)}`);
}
}
};
handleAsync().catch(() => {
// Swallow — showLoginDialog already handles its own errors.
// This prevents unhandled rejections when login is cancelled.
});
},
() => {
done();