From d3db0cb4111da3cdf20af1fad9220fb0fef9aafb Mon Sep 17 00:00:00 2001 From: Derek Pearson Date: Sat, 21 Mar 2026 20:48:12 -0400 Subject: [PATCH] fix(gsd): address review feedback from trek-e - Remove redundant `void verboseMode` suppression (parameter is used at line 364) - Simplify hasStrongRecoverySignal: `hasResumableDiskState || recoveryToolCallCount > 0` (the previous expression had a redundant third disjunct) - Remove extra blank line in auto.ts between stepMode assignment and lock-clear block --- src/resources/extensions/gsd/auto-start.ts | 1 - src/resources/extensions/gsd/auto.ts | 1 - src/resources/extensions/gsd/interrupted-session.ts | 4 +--- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/resources/extensions/gsd/auto-start.ts b/src/resources/extensions/gsd/auto-start.ts index 8b405c111..85ebdc5a3 100644 --- a/src/resources/extensions/gsd/auto-start.ts +++ b/src/resources/extensions/gsd/auto-start.ts @@ -105,7 +105,6 @@ export async function bootstrapAutoSession( deps: BootstrapDeps, interrupted: InterruptedSessionAssessment, ): Promise { - void verboseMode; const { shouldUseWorktreeIsolation, registerSigtermHandler, diff --git a/src/resources/extensions/gsd/auto.ts b/src/resources/extensions/gsd/auto.ts index 6b163db2d..9d3cda351 100644 --- a/src/resources/extensions/gsd/auto.ts +++ b/src/resources/extensions/gsd/auto.ts @@ -987,7 +987,6 @@ export async function startAuto( s.stepMode = requestedStepMode; } - if (freshStartAssessment.lock) { clearLock(base); } diff --git a/src/resources/extensions/gsd/interrupted-session.ts b/src/resources/extensions/gsd/interrupted-session.ts index 7d391b4cd..f226c9507 100644 --- a/src/resources/extensions/gsd/interrupted-session.ts +++ b/src/resources/extensions/gsd/interrupted-session.ts @@ -177,9 +177,7 @@ export async function assessInterruptedSession( } const hasStrongRecoverySignal = - (pausedSession && hasResumableDiskState) || - recoveryToolCallCount > 0 || - hasResumableDiskState; + hasResumableDiskState || recoveryToolCallCount > 0; return { classification: hasStrongRecoverySignal ? "recoverable" : "stale",