singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: address review - extract RAPID_ITERATION_THRESHOLD_MS, simplify data access

Browse source 
Co-authored-by: glittercowboy <186001655+glittercowboy@users.noreply.github.com>
Agent-Logs-Url: https://github.com/gsd-build/gsd-2/sessions/d648480a-42f4-4c41-81c7-85038609c717
This commit is contained in:
copilot-swe-agent[bot] 2026-03-25 18:20:29 +00:00
parent 1737b169b5
commit ce4720bad8
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/resources/extensions/gsd/forensics.ts
View file

@ -343,6 +343,9 @@ export async function buildForensicReport(basePath: string): Promise<ForensicRep
const ACTIVITY_FILENAME_RE = /^(\d+)-(.+?)-(.+)\.jsonl$/;
/** Threshold below which iteration cadence is considered rapid (thrashing). */
const RAPID_ITERATION_THRESHOLD_MS = 5000;
function scanActivityLogs(basePath: string, activeMilestone?: string | null): UnitTrace[] {
const activityDirs = resolveActivityDirs(basePath, activeMilestone);
const allTraces: UnitTrace[] = [];
@ -444,7 +447,7 @@ function scanJournalForForensics(basePath: string): JournalSummary | null {
flowId: e.flowId,
eventType: e.eventType,
rule: e.rule,
unitId: (e.data as Record<string, unknown> | undefined)?.unitId as string | undefined,
unitId: e.data?.unitId as string | undefined,
}));
return {
@ -676,7 +679,7 @@ function detectJournalAnomalies(journal: JournalSummary | null, anomalies: Foren
const spanMs = newest - oldest;
if (spanMs > 0 && journal.flowCount > 10) {
const avgMs = spanMs / journal.flowCount;
if (avgMs < 5000) { // Less than 5 seconds per iteration
if (avgMs < RAPID_ITERATION_THRESHOLD_MS) {
anomalies.push({
type: "journal-rapid-iterations",
severity: "warning",