singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(gsd): detect phantom milestones from abandoned gsd_milestone_generate_id

Browse source 
gsd_milestone_generate_id inserts a DB row with status "queued" as a
side effect. If the milestone is never planned, this phantom row blocks
the state machine — isGhostMilestone returned false for any milestone
with a DB row, regardless of status.

Now isGhostMilestone treats a "queued" DB row with no disk artifacts
(CONTEXT, ROADMAP, SUMMARY) as a ghost, allowing the state machine to
skip phantom milestones.

Closes #3645

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tibsfox 2026-04-06 18:48:22 -07:00
parent b4c6229360
commit cbd705202b
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/resources/extensions/gsd/state.ts
View file

@ -78,10 +78,20 @@ import {
* as ghosts, causing auto-mode to skip them entirely.
*/
export function isGhostMilestone(basePath: string, mid: string): boolean {
// If the milestone has a DB row, it's a known milestone — not a ghost.
// If the milestone has a DB row, it's usually a known milestone — not a ghost.
// Exception: a "queued" row with no disk artifacts is a phantom from
// gsd_milestone_generate_id that was never planned (#3645).
if (isDbAvailable()) {
const dbRow = getMilestone(mid);
if (dbRow) return false;
if (dbRow) {
if (dbRow.status === 'queued') {
const hasContent = resolveMilestoneFile(basePath, mid, "CONTEXT")
|| resolveMilestoneFile(basePath, mid, "ROADMAP")
|| resolveMilestoneFile(basePath, mid, "SUMMARY");
return !hasContent;
}
return false;
}
}
// If a worktree exists for this milestone, it was legitimately created.