singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: prevent infinite loop when milestone detection silently fails (#456)

Browse source 
findMilestoneIds() had a bare catch that returned [] on any error,
causing showSmartEntry() to think no milestones exist and restart
the new-project discuss flow in a loop. Add error logging when the
directory exists but scanning fails, and a sanity check that warns
the user instead of looping when the directory has entries that
weren't recognized.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Lex Christopherson 2026-03-16 11:57:54 -06:00
parent c6ec4eef50
commit cae7d08879
1 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/resources/extensions/gsd/guided-flow.ts
View file

@ -214,7 +214,11 @@ export function findMilestoneIds(basePath: string): string[] {
// Apply custom queue order if available, else fall back to numeric sort
const customOrder = loadQueueOrder(basePath);
return sortByQueueOrder(ids, customOrder);
} catch {
} catch (err) {
// Log why milestone scanning failed — silent [] here causes infinite loops (#456)
if (existsSync(dir)) {
console.error(`[gsd] findMilestoneIds: .gsd/milestones/ exists but readdirSync failed — ${err instanceof Error ? err.message : String(err)}`);
}
return [];
}
}
@ -1002,6 +1006,27 @@ export async function showSmartEntry(
}
const milestoneIds = findMilestoneIds(basePath);
// Sanity check (#456): if findMilestoneIds returns [] but the milestones
// directory has contents, something went wrong (permissions, stale worktree
// cwd, etc). Warn instead of silently starting a new-project flow.
if (milestoneIds.length === 0) {
const mDir = milestonesDir(basePath);
if (existsSync(mDir)) {
try {
const entries = readdirSync(mDir);
if (entries.length > 0) {
ctx.ui.notify(
`Milestone directory has ${entries.length} entries but none were recognized as milestones. ` +
`This may indicate a corrupted state or wrong working directory. Run \`/gsd doctor\` to diagnose.`,
"warning",
);
return;
}
} catch { /* directory exists but unreadable — fall through to normal flow */ }
}
}
const uniqueMilestoneIds = !!loadEffectiveGSDPreferences()?.preferences?.unique_milestone_ids;
const nextId = nextMilestoneId(milestoneIds, uniqueMilestoneIds);
const isFirst = milestoneIds.length === 0;