From b7d7c69b9eb19d99fb97e64d927f4e46c921d2a9 Mon Sep 17 00:00:00 2001 From: Jeremy Date: Tue, 7 Apr 2026 21:41:08 -0500 Subject: [PATCH] fix(gsd): add logWarning to empty catch block in orphaned worktree cleanup The workflow-logger coverage test (#3348) requires all catch blocks in migrated files to include logging. Add logWarning for the expected failure case when nativeWorktreeRemove fails on orphaned directories. Refs #3739 --- src/resources/extensions/gsd/auto-start.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/resources/extensions/gsd/auto-start.ts b/src/resources/extensions/gsd/auto-start.ts index e7d0bb837..695d948fe 100644 --- a/src/resources/extensions/gsd/auto-start.ts +++ b/src/resources/extensions/gsd/auto-start.ts @@ -208,8 +208,9 @@ export function auditOrphanedMilestoneBranches( // Try git worktree remove first (handles registered worktrees) try { nativeWorktreeRemove(basePath, wtDir, true); - } catch { + } catch (e) { // Not a registered worktree — expected for orphaned dirs + logWarning("engine", `worktree remove failed (expected for orphaned dirs): ${e instanceof Error ? e.message : String(e)}`); } // If the directory still exists after git worktree remove (either it