singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(pi-coding-agent): finalize streaming component on agent_end instead of removing it

Browse source 
When message_end does not fire before agent_end (e.g. abort path), the
agent_end case was calling chatContainer.removeChild(streamingComponent),
which silently erased the last assistant message from the TUI chat history.

Fix: follow the message_end finalization pattern — call setShowMetadata(true)
and updateContent() before clearing the reference. Never call removeChild on
a component that was added to the persistent chat history.

Closes #4197
This commit is contained in:
Nils Reeh 2026-04-15 02:36:07 +02:00
parent 736e542304
commit b721ec1445
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/pi-coding-agent/src/modes/interactive/controllers/chat-controller.ts
View file

@ -546,11 +546,18 @@ export async function handleAgentEvent(host: InteractiveModeStateHost & {
host.loadingAnimation = undefined;
host.statusContainer.clear();
}
if (host.streamingComponent) {
host.chatContainer.removeChild(host.streamingComponent);
host.streamingComponent = undefined;
host.streamingMessage = undefined;
// If message_end did not already finalize the streaming component
// (e.g. abort path or event ordering edge case), finalize it now
// instead of removing it. Calling removeChild would erase the last
// assistant message from the chat history (issue #4197).
if (host.streamingComponent && host.streamingMessage) {
host.streamingComponent.setShowMetadata(true);
host.streamingComponent.updateContent(host.streamingMessage);
}
host.streamingComponent = undefined;
host.streamingMessage = undefined;
renderedSegments = [];
lastContentLength = 0;
host.pendingTools.clear();
// Pinned output is only useful while work is actively streaming.
// Keep chat history as the single source after completion.