singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(gsd): surface warnings when DB or STATE.md init fails

Browse source 
ensureDbOpen() returns false on failure instead of throwing, so the
try/catch alone was not catching the real failure path. Now check the
return value and notify the user with a visible warning when DB or
STATE.md generation fails, instead of silently claiming full success.
This commit is contained in:
Jeremy 2026-04-09 17:32:55 -05:00
parent 77e7342756
commit ae9afc0b9b
2 changed files with 36 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/resources/extensions/gsd/init-wizard.ts
View file

@ -238,11 +238,15 @@ export async function showProjectInit(
// Initialize SQLite database so GSD starts in full-capability mode (#3880).
// Without this, isDbAvailable() returns false and GSD enters degraded
// markdown-only mode until a tool handler happens to call ensureDbOpen().
let dbReady = false;
try {
const { ensureDbOpen } = await import("./bootstrap/dynamic-tools.js");
await ensureDbOpen(basePath);
dbReady = await ensureDbOpen(basePath);
} catch {
// Non-fatal — DB creation failure should not block project init
// Swallowed — warning surfaced below
}
if (!dbReady) {
ctx.ui.notify("Warning: database initialization failed — GSD will run in degraded mode until the next /gsd invocation.", "warning");
}
// Ensure .gitignore
@ -263,6 +267,7 @@ export async function showProjectInit(
// Write initial STATE.md so it exists before the first /gsd invocation.
// The explicit /gsd init path (ops.ts) returns without entering showSmartEntry(),
// which would otherwise generate STATE.md at guided-flow.ts:1358.
let stateReady = false;
try {
const { deriveState } = await import("./state.js");
const { buildStateMarkdown } = await import("./doctor.js");
@ -270,8 +275,12 @@ export async function showProjectInit(
const { resolveGsdRootFile } = await import("./paths.js");
const state = await deriveState(basePath);
await saveFile(resolveGsdRootFile(basePath, "STATE"), buildStateMarkdown(state));
stateReady = true;
} catch {
// Non-fatal — STATE.md will be regenerated on next /gsd invocation
// Swallowed — warning surfaced below
}
if (!stateReady) {
ctx.ui.notify("Warning: initial STATE.md generation failed — it will be created on the next /gsd invocation.", "warning");
}
ctx.ui.notify("GSD initialized. Starting your first milestone...", "info");

24
src/resources/extensions/gsd/tests/init-bootstrap-completeness.test.ts
View file

@ -94,4 +94,28 @@ describe("init-wizard bootstrap completeness (#3880)", () => {
"ensureDbOpen must appear before deriveState so DB is ready for state derivation",
);
});
// ── Failure visibility: user must be warned on partial bootstrap ───────
test("ensureDbOpen failure surfaces a warning to the user", () => {
assert.match(
wizardSrc,
/if\s*\(\s*!dbReady\s*\)/,
"init-wizard should check dbReady and warn the user on failure",
);
// The warning must reference degraded mode so the user knows what happened
assert.match(
wizardSrc,
/degraded mode/,
"DB failure warning should mention degraded mode",
);
});
test("STATE.md failure surfaces a warning to the user", () => {
assert.match(
wizardSrc,
/if\s*\(\s*!stateReady\s*\)/,
"init-wizard should check stateReady and warn the user on failure",
);
});
});