singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: route needs-discussion phase to interactive flow instead of stopping (#1175)

Browse source 
When a milestone has CONTEXT-DRAFT.md (phase: needs-discussion), the
dispatch table returned 'stop' — which made auto-mode exit. Running
/gsd again would re-enter auto → dispatch → stop → loop indefinitely.

The guided-flow already has a complete interactive handler for
needs-discussion (discuss from draft / start fresh / skip), but it was
never reached from the auto-mode entry path.

Added an early check in dispatchNextUnit: if phase is needs-discussion,
stop auto-mode gracefully and route to showSmartEntry() which handles
the discussion flow correctly.

Fixes #1170
This commit is contained in:
Tom Boucher 2026-03-18 12:06:48 -04:00 • committed by GitHub
parent 0a974c9765
commit a1ef04a5f3
1 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/resources/extensions/gsd/auto.ts
View file

@ -1439,6 +1439,23 @@ async function dispatchNextUnit(
await runSecretsGate();
// ── Interactive discussion gate ──
// If the active milestone needs discussion (has CONTEXT-DRAFT.md but no roadmap),
// stop auto-mode and route to the interactive discussion flow. The guided-flow
// handles needs-discussion correctly — it just needs to be called instead of
// letting the dispatch table fire "needs-discussion → stop" (#1170).
if (state.phase === "needs-discussion") {
if (s.currentUnit) {
await closeoutUnit(ctx, s.basePath, s.currentUnit.type, s.currentUnit.id, s.currentUnit.startedAt, buildSnapshotOpts(s.currentUnit.type, s.currentUnit.id));
}
const cmdCtx = s.cmdCtx!;
const basePath = s.basePath;
await stopAuto(ctx, pi, `${mid}: ${midTitle} needs discussion before planning.`);
const { showSmartEntry } = await import("./guided-flow.js");
await showSmartEntry(cmdCtx, pi, basePath);
return;
}
// ── Dispatch table ──
const dispatchResult = await resolveDispatch({ basePath: s.basePath, mid, midTitle: midTitle!, state, prefs,
});