From 9e5203fdf8561a5547dc3169140856a8d7afb201 Mon Sep 17 00:00:00 2001
From: Jeremy <jeremy@fluxlabs.net>
Date: Sat, 11 Apr 2026 10:34:51 -0500
Subject: [PATCH] fix(gsd): resolve workflow MCP test typing regressions

---
 .../gsd/tests/workflow-mcp-auto-prep.test.ts  |  6 +--
 .../extensions/gsd/tests/workflow-mcp.test.ts | 44 ++++++++-----------
 2 files changed, 22 insertions(+), 28 deletions(-)

diff --git a/src/resources/extensions/gsd/tests/workflow-mcp-auto-prep.test.ts b/src/resources/extensions/gsd/tests/workflow-mcp-auto-prep.test.ts
index 9d9e8d257..fabb15c3a 100644
--- a/src/resources/extensions/gsd/tests/workflow-mcp-auto-prep.test.ts
+++ b/src/resources/extensions/gsd/tests/workflow-mcp-auto-prep.test.ts
@@ -52,7 +52,7 @@ test("shouldAutoPrepareWorkflowMcp stays disabled when neither transport nor pro
 });
 
 test("prepareWorkflowMcpForProject warns with /gsd mcp init guidance when prep fails", () => {
-  const notifications: Array<{ message: string; level: string }> = [];
+  const notifications: Array<{ message: string; level: "info" | "warning" | "error" | "success" }> = [];
   const result = prepareWorkflowMcpForProject(
     {
       model: { provider: "claude-code", baseUrl: "local://claude-code" },
@@ -61,8 +61,8 @@ test("prepareWorkflowMcpForProject warns with /gsd mcp init guidance when prep f
         isProviderRequestReady: () => true,
       },
       ui: {
-        notify: (message: string, level: string) => {
-          notifications.push({ message, level });
+        notify: (message: string, level?: "info" | "warning" | "error" | "success") => {
+          notifications.push({ message, level: level ?? "info" });
         },
       },
     },
diff --git a/src/resources/extensions/gsd/tests/workflow-mcp.test.ts b/src/resources/extensions/gsd/tests/workflow-mcp.test.ts
index e17c5043b..a1203eade 100644
--- a/src/resources/extensions/gsd/tests/workflow-mcp.test.ts
+++ b/src/resources/extensions/gsd/tests/workflow-mcp.test.ts
@@ -20,10 +20,20 @@ import {
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const gsdDir = join(__dirname, "..");
 
+type ElicitPayload = {
+  message: string;
+  requestedSchema: { properties: Record<string, unknown>; required?: string[] };
+};
+
 function readSrc(file: string): string {
   return readFileSync(join(gsdDir, file), "utf-8");
 }
 
+function extractElicitPayload(request: unknown): ElicitPayload {
+  const payload = (request as { params?: unknown }).params ?? request;
+  return payload as ElicitPayload;
+}
+
 test("guided execute-task requires canonical task completion tool", () => {
   assert.deepEqual(getRequiredWorkflowToolsForGuidedUnit("execute-task"), ["gsd_task_complete"]);
 });
@@ -190,15 +200,7 @@ test("workflow MCP launch config reaches mutation tools over stdio", async () =>
     { capabilities: { elicitation: {} } },
   );
   client.setRequestHandler(ElicitRequestSchema, async (request) => {
-    const elicitation = (request as {
-      params?: {
-        message: string;
-        requestedSchema: { properties: Record<string, unknown>; required?: string[] };
-      };
-    }).params ?? request as {
-      message: string;
-      requestedSchema: { properties: Record<string, unknown>; required?: string[] };
-    };
+    const elicitation = extractElicitPayload(request as unknown);
 
     assert.match(elicitation.message, /Please answer the following question/);
     assert.ok(elicitation.requestedSchema.properties.transport_mode);
@@ -362,17 +364,7 @@ test("workflow MCP ask_user_questions uses stdio elicitation round-trip", async
   } | null = null;
 
   client.setRequestHandler(ElicitRequestSchema, async (request) => {
-    const params = (
-      request as {
-        params?: {
-          message: string;
-          requestedSchema: { properties: Record<string, unknown>; required?: string[] };
-        };
-      }
-    ).params ?? request as {
-      message: string;
-      requestedSchema: { properties: Record<string, unknown>; required?: string[] };
-    };
+    const params = extractElicitPayload(request as unknown);
 
     requestSeen = params;
 
@@ -418,12 +410,14 @@ test("workflow MCP ask_user_questions uses stdio elicitation round-trip", async
     );
 
     assert.ok(requestSeen, "expected stdio transport to forward an elicitation request");
-    assert.match(requestSeen.message, /Please answer the following question/);
-    assert.ok(requestSeen.requestedSchema.properties.deployment);
-    assert.ok(requestSeen.requestedSchema.properties.deployment__note);
-    assert.ok(requestSeen.requestedSchema.required?.includes("deployment"));
+    const seen = requestSeen as ElicitPayload;
+    assert.match(seen.message, /Please answer the following question/);
+    assert.ok(seen.requestedSchema.properties.deployment);
+    assert.ok(seen.requestedSchema.properties.deployment__note);
+    assert.ok(seen.requestedSchema.required?.includes("deployment"));
 
-    const text = result.content.find((item) => item.type === "text");
+    const content = (result as { content: Array<{ type: string; text?: string }> }).content;
+    const text = content.find((item: { type: string; text?: string }) => item.type === "text");
     assert.ok(text && "text" in text);
     assert.equal(
       text.text,