singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #4182 from jeremymcs/claude/refactor-code-cleanup-078AQ

Browse source 
fix: keep assistant text visible when thinking traces are long
This commit is contained in:
Jeremy McSpadden 2026-04-14 09:17:49 -05:00 • committed by GitHub
commit 7f77322fe2
2 changed files with 44 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
packages/pi-coding-agent/src/modes/interactive/components/assistant-message.ts
View file

@ -87,6 +87,7 @@ export class AssistantMessageComponent extends Container {
const hasVisibleContent = slice.some(
(c) => (c.type === "text" && c.text.trim()) || (c.type === "thinking" && c.thinking.trim()),
);
const hasTextContent = message.content.some((c) => c.type === "text" && c.text.trim().length > 0);
if (hasVisibleContent) {
this.contentContainer.addChild(new Spacer(1));
@ -114,12 +115,15 @@ export class AssistantMessageComponent extends Container {
}
} else {
// Thinking traces in thinkingText color, italic
this.contentContainer.addChild(
new Markdown(content.thinking.trim(), 1, 0, this.markdownTheme, {
color: (text: string) => theme.fg("thinkingText", text),
italic: true,
}),
);
const thinkingMarkdown = new Markdown(content.thinking.trim(), 1, 0, this.markdownTheme, {
color: (text: string) => theme.fg("thinkingText", text),
italic: true,
});
// Keep assistant text/questions visible even when thinking traces are long.
if (hasTextContent) {
thinkingMarkdown.maxLines = 8;
}
this.contentContainer.addChild(thinkingMarkdown);
if (hasVisibleContentAfter) {
this.contentContainer.addChild(new Spacer(1));
}

34
src/tests/assistant-message-thinking-visibility.test.ts Normal file
View file

@ -0,0 +1,34 @@
// Regression test for #4181:
// When assistant messages include both thinking + text, cap visible thinking
// lines so question/chat text remains visible without toggling thinking off.
import test from "node:test";
import assert from "node:assert/strict";
import { readFileSync } from "node:fs";
import { join } from "node:path";
const assistantMessagePath = join(
process.cwd(),
"packages",
"pi-coding-agent",
"src",
"modes",
"interactive",
"components",
"assistant-message.ts",
);
test("assistant-message caps thinking block height when text content is present", () => {
const src = readFileSync(assistantMessagePath, "utf-8");
assert.match(
src,
/const hasTextContent = message\.content\.some\(\(c\) => c\.type === "text" && c\.text\.trim\(\)\.length > 0\);/,
"assistant-message should detect text presence in mixed thinking+text messages",
);
assert.match(
src,
/if \(hasTextContent\)\s*\{\s*thinkingMarkdown\.maxLines = 8;\s*\}/s,
"assistant-message should cap visible thinking lines when assistant text also exists",
);
});