singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(skills): address QA round 3

Browse source 
F3.1: Move migrateSkillsToEcosystemDir() above the manifest hash
gate so it runs on every launch. Previously, partial migration
failures would not retry until the next version bump because
initResources() wrote the manifest and early-returned on match.

F3.2: Resolve relative symlink targets to absolute paths before
recreating in the ecosystem directory. A relative symlink like
../../custom/my-skill resolves differently from ~/.agents/skills/
than from ~/.gsd/agent/skills/, silently pointing to the wrong
location.
This commit is contained in:
Derek Pearson 2026-03-22 14:42:03 -04:00
parent b09ac9b24d
commit 75f564e2ba
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/resource-loader.ts
View file

@ -377,6 +377,10 @@ export function initResources(agentDir: string): void {
// extensions fail to resolve @gsd/* packages, rendering GSD non-functional.
ensureNodeModulesSymlink(agentDir)
// Migrate legacy skills on every launch (not gated by manifest) so that
// partial-failure retries don't wait for a version bump.
migrateSkillsToEcosystemDir(agentDir)
// Skip the full copy when both version AND content fingerprint match.
// Version-only checks miss same-version content changes (npm link dev workflow,
// hotfixes within a release). The content hash catches those at ~1ms cost.
@ -397,9 +401,9 @@ export function initResources(agentDir: string): void {
// skills.sh CLI (`npx skills add <repo>`) into ~/.agents/skills/ which
// is the industry-standard Agent Skills ecosystem directory.
//
// Migrate any user-customized skills from the legacy ~/.gsd/agent/skills/
// directory into ~/.agents/skills/ so they aren't silently lost on upgrade.
migrateSkillsToEcosystemDir(agentDir)
// Migration from the legacy ~/.gsd/agent/skills/ directory is handled
// above the manifest check so it runs on every launch (including retries
// after partial copy failures).
// Sync GSD-WORKFLOW.md to agentDir as a fallback for when GSD_WORKFLOW_PATH
// env var is not set (e.g. fork/dev builds, alternative entry points).
@ -482,9 +486,13 @@ function migrateSkillsToEcosystemDir(agentDir: string): void {
candidates++
try {
if (isSymlink) {
// Recreate the symlink in the ecosystem directory
const linkTarget = readlinkSync(sourcePath)
symlinkSync(linkTarget, target)
// Recreate the symlink in the ecosystem directory using an absolute
// target. Relative symlinks would resolve from the new parent dir
// (~/.agents/skills/) instead of the original (~/.gsd/agent/skills/),
// pointing to the wrong location.
const rawTarget = readlinkSync(sourcePath)
const absTarget = resolve(dirname(sourcePath), rawTarget)
symlinkSync(absTarget, target)
} else {
cpSync(sourcePath, target, { recursive: true })
}