singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #3774 from mastertyko/fix/3759-preferences-section-warn-once

Browse source 
fix(gsd): suppress repeated preferences section warnings
This commit is contained in:
Jeremy McSpadden 2026-04-08 08:07:41 -05:00 • committed by GitHub
commit 695cab8b63
2 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/resources/extensions/gsd/preferences.ts
View file

@ -200,11 +200,13 @@ function loadPreferencesFile(path: string, scope: "global" | "project"): LoadedG
}
let _warnedUnrecognizedFormat = false;
let _warnedSectionParse = false;
/** @internal Reset the warn-once flags — exported for testing only. */
export function _resetParseWarningFlag(): void {
_warnedUnrecognizedFormat = false;
_warnedFrontmatterParse = false;
_warnedSectionParse = false;
}
/** @internal Exported for testing only */
@ -309,7 +311,10 @@ function parseHeadingListFormat(content: string): GSDPreferences {
typed[targetSection] = value;
} catch (e) {
logWarning("guided", `preferences section parse failed: ${(e as Error).message}`);
if (!_warnedSectionParse) {
_warnedSectionParse = true;
logWarning("guided", `preferences section parse failed: ${(e as Error).message}`);
}
}
}

20
src/resources/extensions/gsd/tests/preferences.test.ts
View file

@ -17,6 +17,7 @@ import {
parsePreferencesMarkdown,
_resetParseWarningFlag,
} from "../preferences.ts";
import { _resetLogs, peekLogs } from "../workflow-logger.ts";
import type { GSDPreferences, GSDModelConfigV2, GSDPhaseModelConfig } from "../preferences.ts";
// ── Git preferences ──────────────────────────────────────────────────────────
@ -422,6 +423,25 @@ test("parsePreferencesMarkdown parses heading+list format without frontmatter (#
assert.deepStrictEqual(result!.git, { isolation: "none" });
});
test("section parse warning is emitted at most once for heading+list YAML failures (#3759)", () => {
_resetParseWarningFlag();
_resetLogs();
const content = `## Git
bad: [
`;
parsePreferencesMarkdown(content);
parsePreferencesMarkdown(content);
parsePreferencesMarkdown(content);
const warnings = peekLogs().filter((entry) => entry.component === "guided" && entry.message.includes("preferences section parse failed"));
assert.equal(warnings.length, 1, `expected exactly 1 guided warning, got ${warnings.length}`);
_resetParseWarningFlag();
_resetLogs();
});
// ── Experimental preferences ─────────────────────────────────────────────────
test("experimental.rtk: true is accepted and stored", () => {