singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: remove redundant test file, identify consolidation targets (#1070)

Browse source 
* docs: add Node LTS pinning guide for macOS Homebrew users

New doc (docs/node-lts-macos.md) explains how to pin Node 24 LTS
via Homebrew to avoid running on odd-numbered development releases.
Covers brew install/link/pin, version managers as alternatives,
and verification steps.

Added notice banner in README linking to the guide.

* refactor: remove auto-draft-pause.test.ts — redundant with auto-dashboard.test.ts

auto-draft-pause.test.ts tested describeNextUnit() for needs-discussion,
pre-planning, and executing phases. All of these are already covered by
auto-dashboard.test.ts which has proper node:test structure.

The removed file also had fragile structural tests (string-matching source
code) that break on refactors. The behavioral coverage is complete in the
existing file.

1296 tests pass, 0 fail.
This commit is contained in:
Tom Boucher 2026-03-18 00:01:20 -04:00 • committed by GitHub
parent 60dfaabe03
commit 38b79d75a7
1 changed files with 0 additions and 115 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

115
src/resources/extensions/gsd/tests/auto-draft-pause.test.ts
View file

@ -1,115 +0,0 @@
import { readFileSync } from "node:fs";
import { join } from "node:path";
import { describeNextUnit } from "../auto.js";
let passed = 0;
let failed = 0;
function assert(condition: boolean, message: string): void {
if (condition) {
passed++;
} else {
failed++;
console.error(` FAIL: ${message}`);
}
}
// ─── Test describeNextUnit with 'needs-discussion' phase ──────────────────
const ndState = {
phase: "needs-discussion" as const,
activeMilestone: { id: "M007", title: "Future Milestone" },
activeSlice: undefined,
activeTask: undefined,
milestoneRegistry: [],
nextAction: "",
};
const ndResult = describeNextUnit(ndState as any);
assert(
ndResult.label !== "Continue",
`needs-discussion label should not be default "Continue", got: "${ndResult.label}"`,
);
assert(
ndResult.label.toLowerCase().includes("draft") || ndResult.label.toLowerCase().includes("discuss"),
`needs-discussion label should mention "draft" or "discuss", got: "${ndResult.label}"`,
);
assert(
ndResult.description.toLowerCase().includes("discussion") || ndResult.description.toLowerCase().includes("draft"),
`needs-discussion description should mention "discussion" or "draft", got: "${ndResult.description}"`,
);
// ─── Backward compatibility: pre-planning still works ──────────────────────
const ppState = {
phase: "pre-planning" as const,
activeMilestone: { id: "M001", title: "Test" },
activeSlice: undefined,
activeTask: undefined,
milestoneRegistry: [],
nextAction: "",
};
const ppResult = describeNextUnit(ppState as any);
assert(
ppResult.label === "Research & plan milestone",
`pre-planning label should be "Research & plan milestone", got: "${ppResult.label}"`,
);
// ─── Backward compatibility: executing still works ──────────────────────────
const exState = {
phase: "executing" as const,
activeMilestone: { id: "M001", title: "Test" },
activeSlice: { id: "S01", title: "Test Slice" },
activeTask: { id: "T01", title: "Test Task" },
milestoneRegistry: [],
nextAction: "",
};
const exResult = describeNextUnit(exState as any);
assert(
exResult.label.includes("T01"),
`executing label should include task ID, got: "${exResult.label}"`,
);
// ─── Static verification: needs-discussion in dispatch table ──────────────
const dashboardSource = readFileSync(
join(import.meta.dirname, "..", "auto-dashboard.ts"),
"utf-8",
);
// Check describeNextUnit has the case (in auto-dashboard.ts)
const hasDescribeCase = dashboardSource.includes('case "needs-discussion"');
assert(hasDescribeCase, "auto-dashboard.ts describeNextUnit should have 'needs-discussion' case");
// Dispatch logic moved to auto-dispatch.ts — verify the rule exists there
const dispatchSource = readFileSync(
join(import.meta.dirname, "..", "auto-dispatch.ts"),
"utf-8",
);
// Check dispatch table has a needs-discussion rule
const hasDispatchRule = dispatchSource.includes('"needs-discussion"');
assert(hasDispatchRule, "auto-dispatch.ts should have 'needs-discussion' rule");
// Check the rule returns a stop action
const ruleIdx = dispatchSource.indexOf('"needs-discussion"');
const nextChunk = dispatchSource.slice(ruleIdx, ruleIdx + 600);
assert(
nextChunk.includes('"stop"') || nextChunk.includes("action: \"stop\""),
"needs-discussion dispatch rule should return stop action",
);
// Check notification includes /gsd guidance
assert(
nextChunk.includes("/gsd"),
"needs-discussion notification should tell user to run /gsd",
);
// ─── Results ──────────────────────────────────────────────────────────────
console.log(`\nauto-draft-pause: ${passed} passed, ${failed} failed`);
if (failed > 0) process.exit(1);