From 310ce963eab7eca79555d489ad54dda9a4abdf3a Mon Sep 17 00:00:00 2001 From: Mikael Hugo Date: Wed, 29 Apr 2026 13:56:55 +0200 Subject: [PATCH] docs: add session follow-ups to BUILD_PLAN Six items surfaced during 2026-04-29 ports/refactors that didn't get tracked anywhere: - Tier 1: Remove OpenRouter (~248 model entries; user confirmed unused) - Tier 1: Minimax search tests (deferred from initial port) - Tier 2: Search provider registry refactor (rid of 9-file-per-provider) - Tier 2: Product-audit phase machine wire-up (slim port shipped tool; phase dispatch not yet wired) - Tier 2: Headless assistant-text preview (bunker pattern, deferred from headless UX commit) - Tier 3: Pi-mono SDK sync cadence Each entry has rationale + effort estimate. Co-Authored-By: Claude Sonnet 4.6 --- BUILD_PLAN.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/BUILD_PLAN.md b/BUILD_PLAN.md index b2dff1d1c..daa07a385 100644 --- a/BUILD_PLAN.md +++ b/BUILD_PLAN.md @@ -4,6 +4,21 @@ A practical cut of the 56 NEW items in `SPEC.md` into tiers. Not every spec item This document is the answer to: **what should we actually ship for v3?** +--- + +## Active follow-ups (added during 2026-04-29 session) + +These came up during recent ports and refactor passes — tracked here so they don't get lost. + +| Follow-up | Why | Tier | Effort | +|---|---|---|---| +| **Remove OpenRouter** | User confirmed we don't use OpenRouter. ~248 model entries in `models.generated.ts` + ~84 file mentions. Also removes `provider: "openrouter"` xiaomi entries (we now have direct via `xiaomi-token-plan-*`). | 1 | 1-2 days | +| **Search provider registry refactor** | Adding minimax took 9 files because the provider list is duplicated across `provider.ts` (type + VALID_PREFERENCES), `native-search.ts`, `command-search-provider.ts` (CLI), `tool-search.ts` + `tool-llm-context.ts` (two separate execute paths!), `preferences-types.ts`, `preferences-validation.ts`, manifest, docs. A single `SearchProviderRegistry` array would let everything iterate. | 2 | 3-5 days | +| **Minimax search tests** | Search agent ported the feature but explicitly skipped tests because bunker's tests don't match our preferences/provider export shape. Need: `getMiniMaxSearchApiKey()` priority order, `resolveSearchProvider()` returning "minimax", `/search-provider minimax` CLI behavior, no-key error messages, `executeMiniMaxSearch` request shape. | 1 | 0.5 day | +| **Product-audit phase machine wire-up** | Slim port (commit `a8cf2cd94`) shipped the prompt + `sf_product_audit` tool + workflow template, but doesn't yet dispatch into PhaseMerge or PhaseComplete. The tool is callable; the phase doesn't auto-fire. | 2 | 0.5 day | +| **Headless assistant-text preview** | Headless UX commit (`dff0df5fd`) covered notification spam, categorization, and phase/status tag distinction. The fourth bunker improvement — separating `assistantTextBuffer` from `thinkingBuffer` and flushing both as concise previews on tool-execution-start / message-end — was deferred because it's a meatier change in `headless.ts`. | 2 | 0.5 day | +| **Pi-mono SDK sync** | We pull from pi-mono directly (separate from gsd-2 sync stance). Periodically check `pi-mono/main` for SDK improvements worth taking. The remote is set up; cadence is not. | 3 | recurring | + It is opinionated. Each item has a tier and a one-line rationale. Reorder freely. ---