singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: break reassess-roadmap skip loop by preventing re-persistence of evicted keys (#912) (#927)

Browse source 
After the skip-loop breaker evicts a completion key, the fallback path
at the bottom of dispatchNextUnit re-persists it because the expected
artifact exists on disk. This recreates the exact loop the breaker was
trying to break:

  evict key → dispatch → verifyArtifact(true) → re-persist key → skip → evict → repeat

Fix: Track recently-evicted keys in a Set. The fallback artifact-check
path skips re-persistence for keys that were just evicted by the
skip-loop breaker. Set is cleared on stopAuto.
This commit is contained in:
Tom Boucher 2026-03-17 16:01:36 -04:00 • committed by GitHub
parent 2306e6bb34
commit 2cba5bc072
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/resources/extensions/gsd/auto.ts
View file

@ -564,6 +564,7 @@ export async function stopAuto(ctx?: ExtensionContext, pi?: ExtensionAPI, reason
clearSliceProgressCache();
clearActivityLogState();
resetProactiveHealing();
recentlyEvictedKeys.clear();
pendingCrashRecovery = null;
pendingVerificationRetry = null;
verificationRetryCount.clear();
@ -2033,6 +2034,9 @@ const MAX_SKIP_DEPTH = 20;
* allowed via _skipDepth > 0. */
let _dispatching = false;
/** Keys recently evicted by skip-loop breaker — prevents re-persistence in the fallback path (#912). */
const recentlyEvictedKeys = new Set<string>();
async function dispatchNextUnit(
ctx: ExtensionContext,
pi: ExtensionAPI,
@ -2589,6 +2593,7 @@ async function dispatchNextUnit(
}
unitConsecutiveSkips.delete(idempotencyKey);
completedKeySet.delete(idempotencyKey);
recentlyEvictedKeys.add(idempotencyKey);
removePersistedKey(basePath, idempotencyKey);
invalidateAllCaches();
ctx.ui.notify(
@ -2637,9 +2642,11 @@ async function dispatchNextUnit(
// Fallback: if the idempotency key is missing but the expected artifact already
// exists on disk, the task completed in a prior session without persisting the key.
// Persist it now and skip re-dispatch. This prevents infinite loops where a task
// completes successfully but the completion key was never written (e.g., completed
// on the first attempt before hitting the retry-threshold persistence logic).
if (verifyExpectedArtifact(unitType, unitId, basePath)) {
// completes successfully but the completion key was never written.
//
// EXCEPTION: if the key was just evicted by the skip-loop breaker above, do NOT
// re-persist — that would recreate the exact loop the breaker was trying to break (#912).
if (verifyExpectedArtifact(unitType, unitId, basePath) && !recentlyEvictedKeys.has(idempotencyKey)) {
persistCompletedKey(basePath, idempotencyKey);
completedKeySet.add(idempotencyKey);
invalidateAllCaches();