singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test(gsd): add regression test for verbose-gated model change notification

Browse source 
Verifies that the Model [phase] [tier] notification in selectAndApplyModel
is gated behind the verbose flag to prevent auto-mode notification noise.
This commit is contained in:
Jeremy 2026-04-07 10:48:41 -05:00
parent d25a7d6fb7
commit 230939e558
1 changed files with 33 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/resources/extensions/gsd/tests/auto-model-selection.test.ts
View file

@ -1,8 +1,11 @@
import test from "node:test";
import assert from "node:assert/strict";
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
import { join } from "node:path";
import { mkdtempSync, mkdirSync, rmSync, writeFileSync, readFileSync } from "node:fs";
import { dirname, join } from "node:path";
import { tmpdir } from "node:os";
import { fileURLToPath } from "node:url";
const __dirname = dirname(fileURLToPath(import.meta.url));
import { resolvePreferredModelConfig, resolveModelId } from "../auto-model-selection.js";
@ -196,6 +199,34 @@ test("resolveModelId: bare ID with claude-code as only provider still resolves",
assert.equal(result.provider, "claude-code");
});
// ─── selectAndApplyModel verbose-gating tests ──────────────────────────
test("model change notify in selectAndApplyModel is gated behind verbose flag", () => {
// The Model [phase] [tier] notification should only fire when verbose=true.
// The dashboard header already shows the active model, so the notification
// is redundant noise during auto-mode (#3719).
const gsdDir = join(__dirname, "..");
const src = readFileSync(join(gsdDir, "auto-model-selection.ts"), "utf-8");
// Find the block where setModel succeeds (appliedModel = model) and
// verify notify is inside an `if (verbose)` guard.
const setModelBlock = src.match(
/const ok = await pi\.setModel\(model[\s\S]*?appliedModel = model;([\s\S]*?)break;/,
);
assert.ok(setModelBlock, "should find the setModel success block");
const blockBody = setModelBlock![1];
// The notify call must be inside an if (verbose) block
assert.ok(
blockBody.includes("if (verbose)"),
"Model change ctx.ui.notify must be gated behind if (verbose) to avoid auto-mode notification noise",
);
assert.ok(
blockBody.includes("ctx.ui.notify"),
"notify call should still exist (just verbose-gated)",
);
});
test("resolveModelId: anthropic wins over claude-code regardless of list order", () => {
const availableModels = [
{ id: "claude-sonnet-4-6", provider: "claude-code" },