singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: handle EPIPE in LSP sendNotification and wait for process exit on reload (#815) (#837)

Browse source
This commit is contained in:
Tom Boucher 2026-03-17 09:59:25 -04:00 • committed by GitHub
parent 4a43679bc0
commit 0873961550
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/pi-coding-agent/src/core/lsp/client.ts
View file

@ -842,7 +842,17 @@ export async function sendNotification(client: LspClient, method: string, params
};
client.lastActivity = Date.now();
await writeMessage(client.proc.stdin, notification);
try {
await writeMessage(client.proc.stdin, notification);
} catch (err: unknown) {
// EPIPE means the LSP process died (e.g. after lsp.reload killed it).
// Swallow so callers don't crash — the next getOrCreateClient call
// will spawn a fresh server (#815).
if (err instanceof Error && 'code' in err && (err as NodeJS.ErrnoException).code === 'EPIPE') {
return;
}
throw err;
}
}
/**

7
packages/pi-coding-agent/src/core/lsp/index.ts
View file

@ -211,6 +211,13 @@ async function reloadServer(client: LspClient, serverName: string, signal?: Abor
}
if (output.startsWith("Restarted")) {
client.proc.kill();
// Wait for the process to actually exit so the crash recovery handler
// removes the client from the cache. Without this, the next
// getOrCreateClient call may return the dead client (#815).
await Promise.race([
client.proc.exited,
new Promise(r => setTimeout(r, 3000)),
]);
}
return output;
}