singularity/singularity-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(gsd): use explicit parameter syntax in skill activation prompts

Browse source 
The skill activation block used positional-looking syntax
`Call Skill('name')` which caused LLMs (especially non-Anthropic
models) to pass `{name: "..."}` instead of the required
`{skill: "..."}` parameter. This triggered tool validation failures
and stuck dispatch loops in auto-mode.

Change the prompt template to `Call Skill({ skill: 'name' })` which
makes the parameter name explicit and matches the Skill tool schema.

Update all 4 affected test assertions to match the new format.

Closes #2224
This commit is contained in:
mastertyko 2026-03-23 18:46:44 +01:00
parent 419a74672e
commit 006184456a
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/resources/extensions/gsd/auto-prompts.ts
View file

@ -421,7 +421,9 @@ function resolvePreferredSkillNames(
function formatSkillActivationBlock(skillNames: string[]): string {
if (skillNames.length === 0) return "";
const calls = skillNames.map(name => `Call Skill('${name}')`).join('. ');
// Use explicit parameter syntax so LLMs pass { skill: "..." } instead of { name: "..." }.
// Positional-looking `Skill('name')` caused validation failures — see #2224.
const calls = skillNames.map(name => `Call Skill({ skill: '${name}' })`).join('. ');
return `<skill_activation>${calls}.</skill_activation>`;
}

8
src/resources/extensions/gsd/tests/skill-activation.test.ts
View file

@ -75,7 +75,7 @@ test("buildSkillActivationBlock activates skills via prefer_skills when context
prefer_skills: ["react"],
});
assert.match(result, /Call Skill\('react'\)/);
assert.match(result, /Call Skill\(\{ skill: 'react' \}\)/);
assert.doesNotMatch(result, /swiftui/);
} finally {
cleanup(base);
@ -92,7 +92,7 @@ test("buildSkillActivationBlock includes always_use_skills from preferences usin
always_use_skills: ["swift-testing"],
});
assert.equal(result, "<skill_activation>Call Skill('swift-testing').</skill_activation>");
assert.equal(result, "<skill_activation>Call Skill({ skill: 'swift-testing' }).</skill_activation>");
} finally {
cleanup(base);
}
@ -120,8 +120,8 @@ test("buildSkillActivationBlock includes skill_rules matches and task-plan skill
skill_rules: [{ when: "prisma database schema", use: ["prisma"] }],
});
assert.match(result, /Call Skill\('accessibility'\)/);
assert.match(result, /Call Skill\('prisma'\)/);
assert.match(result, /Call Skill\(\{ skill: 'accessibility' \}\)/);
assert.match(result, /Call Skill\(\{ skill: 'prisma' \}\)/);
} finally {
cleanup(base);
}