From 5471a15959630bf6864586c22ee0add434e057bc Mon Sep 17 00:00:00 2001 From: Murilo Date: Tue, 23 Dec 2025 14:47:48 -0300 Subject: [PATCH 1/4] Add support for 'image/jpg' MIME type Requesting support for displaying jpg images in notifications. Currently, they are not embedded in the notification. --- app/src/main/java/io/heckel/ntfy/util/Util.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/io/heckel/ntfy/util/Util.kt b/app/src/main/java/io/heckel/ntfy/util/Util.kt index 28be312b..393b99fb 100644 --- a/app/src/main/java/io/heckel/ntfy/util/Util.kt +++ b/app/src/main/java/io/heckel/ntfy/util/Util.kt @@ -327,7 +327,7 @@ fun mimeTypeToIconResource(mimeType: String?): Int { } fun supportedImage(mimeType: String?): Boolean { - return listOf("image/jpeg", "image/png", "image/gif", "image/webp").contains(mimeType) + return listOf("image/jpeg", "image/jpg", "image/png", "image/gif", "image/webp").contains(mimeType) } // We cannot open .apk files, because we don't have the REQUEST_INSTALL_PACKAGES anymore From c5e86ddd56155666c5650ac0e7834c6f09847085 Mon Sep 17 00:00:00 2001 From: Philipp Heckel Date: Fri, 26 Dec 2025 09:53:51 -0500 Subject: [PATCH 2/4] Bump version --- app/build.gradle | 4 ++-- .../metadata/android/en-US/changelog/{NEXT.txt => 53.txt} | 0 2 files changed, 2 insertions(+), 2 deletions(-) rename fastlane/metadata/android/en-US/changelog/{NEXT.txt => 53.txt} (100%) diff --git a/app/build.gradle b/app/build.gradle index aa02fe48..bab1da71 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -17,8 +17,8 @@ android { minSdkVersion 26 targetSdkVersion 36 - versionCode 52 - versionName "1.19.4" + versionCode 53 + versionName "1.20.0" testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" diff --git a/fastlane/metadata/android/en-US/changelog/NEXT.txt b/fastlane/metadata/android/en-US/changelog/53.txt similarity index 100% rename from fastlane/metadata/android/en-US/changelog/NEXT.txt rename to fastlane/metadata/android/en-US/changelog/53.txt From 6949a92f8bc6c8ae67ba54fb218eaeb8b64c7801 Mon Sep 17 00:00:00 2001 From: Philipp Heckel Date: Fri, 26 Dec 2025 13:07:50 -0500 Subject: [PATCH 3/4] Release notes --- fastlane/metadata/android/en-US/changelog/NEXT.txt | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 fastlane/metadata/android/en-US/changelog/NEXT.txt diff --git a/fastlane/metadata/android/en-US/changelog/NEXT.txt b/fastlane/metadata/android/en-US/changelog/NEXT.txt new file mode 100644 index 00000000..5d5b01f6 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelog/NEXT.txt @@ -0,0 +1,2 @@ +Maintenance + bug fixes: +* Add support for (technically incorrect) 'image/jpg' MIME type (ntfy-android#142, thanks to @Murilobeluco) From b31624fc297a973ea7c1c5b5080d39774fcdd238 Mon Sep 17 00:00:00 2001 From: Philipp Heckel Date: Fri, 26 Dec 2025 13:11:06 -0500 Subject: [PATCH 4/4] Add comment --- app/src/main/java/io/heckel/ntfy/util/Util.kt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/io/heckel/ntfy/util/Util.kt b/app/src/main/java/io/heckel/ntfy/util/Util.kt index 393b99fb..02d512b7 100644 --- a/app/src/main/java/io/heckel/ntfy/util/Util.kt +++ b/app/src/main/java/io/heckel/ntfy/util/Util.kt @@ -327,7 +327,13 @@ fun mimeTypeToIconResource(mimeType: String?): Int { } fun supportedImage(mimeType: String?): Boolean { - return listOf("image/jpeg", "image/jpg", "image/png", "image/gif", "image/webp").contains(mimeType) + return listOf( + "image/jpeg", + "image/jpg", // Technically not a valid MIME type, see https://github.com/binwiederhier/ntfy-android/pull/142 + "image/png", + "image/gif", + "image/webp" + ).contains(mimeType) } // We cannot open .apk files, because we don't have the REQUEST_INSTALL_PACKAGES anymore