06933a696a
# What this PR does This PR adds support for routing alerts based on labels. https://www.loom.com/share/4401de6e3c4945d5b8961fe43ee373c9 Additionally: - improve the typing around the `get_object` method that is inherited by [`PublicPrimaryKeyMixin.get_object`](https://github.com/grafana/oncall/blob/dev/engine/common/api_helpers/mixins.py#L153) in most of our models. `PublicPrimaryKeyMixin` is generic, so it can be more strongly typed when it is being subclassed, which results in better typing of the `get_object` method in child classes - I decided to do this because I started looking into this task via the [`AlertReceiveChannelView.send_demo_alert` method/endpoint](https://github.com/grafana/oncall/blob/dev/engine/apps/api/views/alert_receive_channel.py#L242). Within that method, `instance` is not typed because the inherited `get_object` method is not typed.. I digress 😄 - improve typing around `Alert.create` and `apps.integrations.tasks.create_alert` functions - make `Alert.render_group_data` more DRY by extracting some logic out into `Alert._apply_jinja_template_to_alert_payload_and_labels` - deduplicate the logic of `value.strip().lower() in ["1", "true", "ok"]` into a shared function, `common.jinja_templater.apply_jinja_template.templated_value_is_truthy` Closes https://github.com/grafana/oncall-private/issues/2490 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) - [x] Documentation added (or `pr:no public docs` PR label added if not required) (will be done in #3762)
70 lines
3 KiB
Python
70 lines
3 KiB
Python
from rest_framework.permissions import IsAuthenticated
|
|
from rest_framework.viewsets import ModelViewSet
|
|
|
|
from apps.alerts.models import ResolutionNote
|
|
from apps.alerts.tasks import send_update_resolution_note_signal
|
|
from apps.api.permissions import RBACPermission
|
|
from apps.api.serializers.resolution_note import ResolutionNoteSerializer, ResolutionNoteUpdateSerializer
|
|
from apps.auth_token.auth import PluginAuthentication
|
|
from apps.mobile_app.auth import MobileAppAuthTokenAuthentication
|
|
from common.api_helpers.mixins import PublicPrimaryKeyMixin, TeamFilteringMixin, UpdateSerializerMixin
|
|
|
|
|
|
class ResolutionNoteView(
|
|
TeamFilteringMixin, PublicPrimaryKeyMixin[ResolutionNote], UpdateSerializerMixin, ModelViewSet
|
|
):
|
|
authentication_classes = (
|
|
MobileAppAuthTokenAuthentication,
|
|
PluginAuthentication,
|
|
)
|
|
permission_classes = (IsAuthenticated, RBACPermission)
|
|
|
|
rbac_permissions = {
|
|
"metadata": [RBACPermission.Permissions.ALERT_GROUPS_READ],
|
|
"list": [RBACPermission.Permissions.ALERT_GROUPS_READ],
|
|
"retrieve": [RBACPermission.Permissions.ALERT_GROUPS_READ],
|
|
"create": [RBACPermission.Permissions.ALERT_GROUPS_WRITE],
|
|
"update": [RBACPermission.Permissions.ALERT_GROUPS_WRITE],
|
|
"partial_update": [RBACPermission.Permissions.ALERT_GROUPS_WRITE],
|
|
"destroy": [RBACPermission.Permissions.ALERT_GROUPS_WRITE],
|
|
}
|
|
|
|
model = ResolutionNote
|
|
serializer_class = ResolutionNoteSerializer
|
|
update_serializer_class = ResolutionNoteUpdateSerializer
|
|
|
|
TEAM_LOOKUP = "alert_group__channel__team"
|
|
|
|
def get_queryset(self, ignore_filtering_by_available_teams=False):
|
|
alert_group_id = self.request.query_params.get("alert_group", None)
|
|
lookup_kwargs = {}
|
|
if alert_group_id:
|
|
lookup_kwargs = {"alert_group__public_primary_key": alert_group_id}
|
|
queryset = ResolutionNote.objects.filter(
|
|
alert_group__channel__organization=self.request.auth.organization,
|
|
**lookup_kwargs,
|
|
)
|
|
|
|
if not ignore_filtering_by_available_teams:
|
|
queryset = queryset.filter(*self.available_teams_lookup_args).distinct()
|
|
|
|
queryset = self.serializer_class.setup_eager_loading(queryset)
|
|
return queryset
|
|
|
|
def dispatch(self, request, *args, **kwargs):
|
|
result = super().dispatch(request, *args, **kwargs)
|
|
|
|
# send signal to update alert group and resolution note
|
|
method = request.method.lower()
|
|
if method in ["post", "put", "patch", "delete"]:
|
|
instance_id = self.kwargs.get("pk") or result.data.get("id")
|
|
if instance_id:
|
|
instance = ResolutionNote.objects_with_deleted.filter(public_primary_key=instance_id).first()
|
|
if instance is not None:
|
|
send_update_resolution_note_signal.apply_async(
|
|
kwargs={
|
|
"alert_group_pk": instance.alert_group.pk,
|
|
"resolution_note_pk": instance.pk,
|
|
}
|
|
)
|
|
return result
|