centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
oncall-engine/engine/apps/alerts/tests
History
Vadim Stepanov 602ed535e3
Fix duplicate orders on routes and escalation policies (#2568) 
# What this PR does

Fix duplicate `order` values for models `EscalationPolicy` and
`ChannelFilter` using the same approach as
https://github.com/grafana/oncall/pull/2278.

- Make internal API action `move_to_position` a part of
[OrderedModelViewSet](https://github.com/grafana/oncall/pull/2568/files#diff-eb62521ccbcb072d1bd2156adeadae3b5895bce6d0d54432a23db3948b0ada54R11-R34),
so all ordered model views use the same logic.
- Make public API serializers for ordered models inherit from
[OrderedModelSerializer](https://github.com/grafana/oncall/pull/2568/files#diff-d749f94af5a49adaf5074325cdfad10ddd5a52dbfd78b49582867ebb9c92fae5R6-R38),
so ordered model views are consistent with each other in public API.
- Remove `order` from plugin fronted, since it's not being used
anywhere. The frontend uses step indices & `move_to_position` action
instead.
- Make escalation snapshot use step indices instead of orders, since
orders are not guaranteed to be sequential (+fix a minor off-by-one bug)

## Which issue(s) this PR fixes

https://github.com/grafana/oncall-private/issues/1680

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-07-18 17:17:53 +00:00
..
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
conftest.py modify check_escalation_finished_task task (#1266) 2023-03-17 10:14:08 +00:00
factories.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
test_alert.py Add escalation chain option when creating a direct page alert group (#1143) 2023-01-18 12:58:26 -03:00
test_alert_group.py Remove outdated Slack functionality to create alerts (#2383) 2023-06-29 10:09:02 +00:00
test_alert_group_renderer.py remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
test_alert_manager.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
test_alert_receiver_channel.py Remove INTEGRATIONS_TO_REVERSE_URL_MAP (#2533) 2023-07-17 04:43:24 +00:00
test_channel_filter.py augment API response pagination attributes (#2471) 2023-07-14 11:19:40 -04:00
test_check_escalation_finished_task.py minor improvements for check_escalation_finished celery task (#2554) 2023-07-17 14:04:53 +00:00
test_custom_button.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
test_custom_webhook_result.py Add escalation chain support for new webhooks (#1654) 2023-04-05 12:03:55 +00:00
test_default_templates.py Fix warnings when running backend tests (#2079) 2023-06-06 18:38:00 +00:00
test_escalation_chain.py Allow changing team for escalation chains (#1658) 2023-03-30 10:43:00 +01:00
test_escalation_policy_snapshot.py Fix warnings when running backend tests (#2079) 2023-06-06 18:38:00 +00:00
test_escalation_snapshot.py Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
test_escalation_snapshot_mixin.py modify check_escalation_finished_task task (#1266) 2023-03-17 10:14:08 +00:00
test_grafana_alerting_sync.py Update find contact point name, receiver could be missing key (#2046) 2023-05-29 18:52:24 +00:00
test_incident_log_builder.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
test_maintenance.py remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
test_notify_ical_schedule_shift.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
test_notify_user.py Add RBAC Support (#777) 2022-11-29 09:41:56 +01:00
test_paging.py remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
test_representative.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
test_silence.py OnCall prometheus metrics exporter (#1605) 2023-05-25 18:26:13 +00:00
test_utils.py Fix outgoing webhook to resolve IP from parsed hostname 2022-09-22 14:35:37 -03:00
test_wipe.py World, meet OnCall! 2022-06-03 08:09:47 -06:00