oncall-engine/engine/apps
Joey Orlando dcf08425eb
Fix few minor Slack connection issues (#3327)
# What this PR does

Closes https://github.com/grafana/oncall-private/issues/2289

- Fix issue where if you try connecting your Slack user to your OnCall
user and the first time around you encounter an error (ex. connecting to
the wrong Slack workspace), you will see the same error banner message
despite a successful connection. Now we clear the session upon
successful connection to ensure that you will not see any previously
encountered errors.
- Fix some alignment issues on the Slack connection buttons
  **Before**

<img width="564" alt="Screenshot 2023-11-10 at 15 07 48"
src="https://github.com/grafana/oncall/assets/9406895/1a256ae9-668c-4a76-b101-cb4e0af29c43">
<img width="789" alt="Screenshot 2023-11-10 at 15 16 22"
src="https://github.com/grafana/oncall/assets/9406895/61649d9d-2f11-497a-9f2d-274c6dbe90eb">

  **After**

<img width="470" alt="Screenshot 2023-11-10 at 15 10 28"
src="https://github.com/grafana/oncall/assets/9406895/92c0f1d3-75eb-4de2-a3d3-4e014489f970">
<img width="738" alt="Screenshot 2023-11-10 at 15 16 42"
src="https://github.com/grafana/oncall/assets/9406895/dc825266-c45e-4c48-af78-0cd5c3c5b64e">

- On the "User Info" user settings modal tab, render `display_name`
instead of `slack_login`. Currently we prefix `@` before `slack_login`,
which is a bit confusing as it makes you think that this is the handle
you would use to `@` your user in Slack. `display_name` corresponds to
the handle that would be used to `@` your user

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-11-13 12:44:54 +00:00
..
alerts Add notifications success ratio log to auditor (#3312) 2023-11-10 16:39:13 +08:00
api Direct paging integrations table (#3290) 2023-11-10 16:54:22 +00:00
api_for_grafana_incident Add render_for_web information to alert group incident API (#3005) 2023-09-12 12:02:42 +00:00
auth_token Return API URL as part of status (#2791) 2023-08-22 17:17:26 +00:00
base WIP: Direct paging improvements (#3064) 2023-09-28 03:57:49 +00:00
email Minor formatting changes (#2641) 2023-07-26 14:45:44 +01:00
grafana_plugin Add labels implementation for integration (#3014) 2023-10-20 07:30:11 +00:00
heartbeat Check if organization was deleted for heartbeat integration (#3270) 2023-11-03 17:05:37 +00:00
integrations Add test ensuring ingestion works without db access (#3322) 2023-11-10 17:44:37 +00:00
labels Add test ensuring ingestion works without db access (#3322) 2023-11-10 17:44:37 +00:00
metrics_exporter Fix metrics and dashboard (#2895) 2023-08-29 13:52:24 +00:00
mobile_app Fix db migration for mobile app (#3260) 2023-11-02 16:40:26 +00:00
oss_installation Minor formatting changes (#2641) 2023-07-26 14:45:44 +01:00
phone_notifications Re-enable a few mypy rules + fix existing errors (#2725) 2023-08-03 09:43:03 +00:00
public_api fix(3093) Return timezone field of the user via public API (#3311) 2023-11-10 11:47:11 -05:00
schedules Update test to avoid failure depending on when it is run (#3289) 2023-11-07 13:29:46 +00:00
slack Pass all integration labels down to alert groups (#3302) 2023-11-08 14:04:58 +00:00
social_auth Fix few minor Slack connection issues (#3327) 2023-11-13 12:44:54 +00:00
telegram Fix getting alert group from telegram action (#3262) 2023-11-03 10:22:38 +00:00
twilioapp add missing db migrations + add additional backend db migration check to CI (#3234) 2023-10-31 16:00:55 -04:00
user_management Forward headers for Amazon SNS (#3326) 2023-11-11 11:11:51 -07:00
webhooks Pass all integration labels down to alert groups (#3302) 2023-11-08 14:04:58 +00:00
zvonok add missing db migrations + add additional backend db migration check to CI (#3234) 2023-10-31 16:00:55 -04:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00