oncall-engine/engine/apps/alerts
Joey Orlando ea9b7a6331
Fix warnings when running backend tests (#2079)
# What this PR does

- update `make test` to always use `settings.ci-test`. Right now it will
use whatever the value of `DJANGO_SETTINGS_MODULE` is in
`./dev/.env.dev`, which causes ~45 tests to fail
- Fix several Python warnings that we see when running the tests
```bash
RemovedInDjango40Warning: The providing_args argument is deprecated. As it is purely documentational, it has no replacement. If you rely on this argument as documentation, you can move the text to a code comment or docstring.
    alert_create_signal = django.dispatch.Signal(
```

```bash
PytestCollectionWarning: cannot collect test class 'TestOnlyBackend' because it has a __init__ constructor (from: apps/api/tests/test_alert_receive_channel_template.py)
    class TestOnlyBackend(BaseMessagingBackend):
```

```bash
DeprecationWarning: The parameter 'use_aliases' in emoji.emojize() is deprecated and will be removed in version 2.0.0. Use language='alias' instead.
  To hide this warning, pin/downgrade the package to 'emoji~=1.6.3'
    return emoji.emojize(self.verbal_name, use_aliases=True)
```

```bash
DateTimeField CustomOnCallShift.start received a naive datetime (2023-06-01 12:53:12) while time zone support is active.
    warnings.warn("DateTimeField %s received a naive datetime (%s)"
```

```bash
apps/twilioapp/tests/test_phone_calls.py::test_resolve_by_phone
  /etc/app/apps/twilioapp/tests/test_phone_calls.py:173: DeprecationWarning: The 'text' argument to find()-type methods is deprecated. Use 'string' instead.
    content = BeautifulSoup(content, features="html.parser").findAll(text=True)
```

```bash
apps/twilioapp/tests/test_phone_calls.py::test_resolve_by_phone
apps/twilioapp/tests/test_phone_calls.py::test_wrong_pressed_digit
  /usr/local/lib/python3.11/site-packages/bs4/builder/__init__.py:545: XMLParsedAsHTMLWarning: It looks like you're parsing an XML document using an HTML parser. If this really is an HTML document (maybe it's XHTML?), you can ignore or filter this warning. If it's XML, you should know that using an XML parser will be more reliable. To parse this document as XML, make sure you have the lxml package installed, and pass the keyword argument `features="xml"` into the BeautifulSoup constructor.
```

```bash
apps/twilioapp/tests/test_phone_calls.py::test_forbidden_requests
  /usr/local/lib/python3.11/site-packages/social_django/urls.py:15: RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
    url(r'^login/(?P<backend>[^/]+){0}$'.format(extra), views.auth,
```

```bash
apps/twilioapp/tests/test_phone_calls.py: 66 warnings
  /usr/local/lib/python3.11/site-packages/debug_toolbar/utils.py:255: DeprecationWarning: currentThread() is deprecated, use current_thread() instead
    thread = threading.currentThread()
```


## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-06-06 18:38:00 +00:00
..
escalation_snapshot add several new database columns + emit two new Django signals (#1522) 2023-04-14 09:15:57 +02:00
grafana_alerting_sync_manager Update find contact point name, receiver could be missing key (#2046) 2023-05-29 18:52:24 +00:00
incident_appearance Fix warnings when running backend tests (#2079) 2023-06-06 18:38:00 +00:00
incident_log_builder modify check_escalation_finished_task task (#1266) 2023-03-17 10:14:08 +00:00
migrations OnCall prometheus metrics exporter (#1605) 2023-05-25 18:26:13 +00:00
models Fix warnings when running backend tests (#2079) 2023-06-06 18:38:00 +00:00
tasks Fix warnings when running backend tests (#2079) 2023-06-06 18:38:00 +00:00
terraform_renderer World, meet OnCall! 2022-06-03 08:09:47 -06:00
tests Fix warnings when running backend tests (#2079) 2023-06-06 18:38:00 +00:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
admin.py Alert group search (#488) 2022-09-06 11:30:12 +01:00
constants.py OnCall prometheus metrics exporter (#1605) 2023-05-25 18:26:13 +00:00
integration_options_mixin.py Change integrations page wording and add more guidance (#1986) 2023-05-31 11:26:36 +00:00
paging.py Keep track of direct paging schedule/importance in logs (#1269) 2023-02-02 09:21:31 -03:00
representative.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
signals.py Fix warnings when running backend tests (#2079) 2023-06-06 18:38:00 +00:00
utils.py Fix outgoing webhook to resolve IP from parsed hostname 2022-09-22 14:35:37 -03:00