c7f8ac3559
# What this PR does Introduces BaseFailed exception for phone_notificator. # Why We need to somehow distinguish errors we want to be notified - like network errors or invalid twilio credentials (I will call them "real" errors) and errors we want to share with user, but don't want to be paged ( I will call them "fake" errors). To do that I added "graceful_msg" to all Failed... exceptions. If details field is present - it mean we can return 400 code with the message, if not - 500 code. So, "real" errors will raise Failed... exception, while "fake" will add "graceful_msg". # TODO handle exceptions handled here https://github.com/grafana/oncall/pull/2065 ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Michael Derynck <michael.derynck@grafana.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| conftest.py | ||
| factories.py | ||
| test_phone_calls.py | ||
| test_senders.py | ||
| test_sms_message.py | ||
| test_twilio_provider.py | ||