oncall-engine/engine/apps/alerts/tasks
Joey Orlando 34a90134fb
patch default user notification policy changes + fix failing e2e test (#4635)
# What this PR does

This is a follow-up PR to https://github.com/grafana/oncall/pull/4628.
As @Ferril pointed out, there was a slight issue in
`apps.alerts.tasks.notify_user.perform_notification` method when using a
"fallback"/default user notification policy. This is because the
`log_record_pk` arg passed into `perform_notification` will fetch the
`UserNotificationPolicyLogRecord` object, but that object will have a
`notification_policy` set to `None` (because there's no persistent
`UserNotificationPolicy` object to refer to).

Instead we now pass in a second argument to `perform_notification`,
`use_default_notification_policy_fallback`. If this is true, simply grab
the transient/in-memory `UserNotificationPolicy` and use that inside of
this task

Related to https://github.com/grafana/oncall/issues/4410

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-07-09 11:23:53 -04:00
..
__init__.py Handle alert group deleted when task is already queued (#4230) 2024-04-16 14:39:00 +00:00
acknowledge_reminder.py Add transaction on_commit before signals for alert group actions (#3731) 2024-01-31 15:54:50 -07:00
alert_group_web_title_cache.py remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
call_ack_url.py apps.get_model -> import (#2619) 2023-07-25 09:43:23 +00:00
check_escalation_finished.py Update escalation auditor logs to expose succeeding count (#4431) 2024-05-31 18:29:31 +00:00
compare_escalations.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
custom_webhook_result.py Add escalation chain support for new webhooks (#1654) 2023-04-05 12:03:55 +00:00
delete_alert_group.py Add transaction on_commit before signals for alert group actions (#3731) 2024-01-31 15:54:50 -07:00
distribute_alert.py Handle alert group deleted when task is already queued (#4230) 2024-04-16 14:39:00 +00:00
escalate_alert_group.py Update transaction.on_commit to use partial instead of lambda (#3448) 2023-11-29 12:01:30 +00:00
invite_user_to_join_incident.py apps.get_model -> import (#2619) 2023-07-25 09:43:23 +00:00
maintenance.py Update transaction.on_commit to use partial instead of lambda (#3448) 2023-11-29 12:01:30 +00:00
notify_all.py Fix order filtering when executing notify all/group steps from snapshot (#4381) 2024-05-23 12:36:28 +00:00
notify_group.py fix failing e2e tests 2024-07-08 13:04:16 -04:00
notify_ical_schedule_shift.py Update when slack client ratelimit retry handler is enabled (#3447) 2023-11-30 12:35:46 +00:00
notify_user.py patch default user notification policy changes + fix failing e2e test (#4635) 2024-07-09 11:23:53 -04:00
resolve_alert_group_by_source_if_needed.py Minor formatting changes (#2641) 2023-07-26 14:45:44 +01:00
resolve_by_last_step.py apps.get_model -> import (#2619) 2023-07-25 09:43:23 +00:00
send_alert_group_signal.py Add transaction on_commit before signals for alert group actions (#3731) 2024-01-31 15:54:50 -07:00
send_update_log_report_signal.py Fix task retries for deleted alert groups (#3553) 2023-12-12 12:01:47 +00:00
send_update_resolution_note_signal.py apps.get_model -> import (#2619) 2023-07-25 09:43:23 +00:00
sync_grafana_alerting_contact_points.py Remove deprecated alerting integration tasks (#2944) 2023-09-01 13:11:02 +00:00
task_logger.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
unsilence.py Update transaction.on_commit to use partial instead of lambda (#3448) 2023-11-29 12:01:30 +00:00
wipe.py Improve alert group deletion API (#3124) 2023-10-05 14:32:40 +01:00