oncall-engine/engine/apps/api/serializers
Joey Orlando d568ad6707
few add responders patches (#3220)
# Which issue(s) this PR fixes

Closes https://github.com/grafana/support-escalations/issues/8143

Fix a few minor issues introduced in #3128:

- Fix slow `GET /users` internal API endpoint related to [this
change](https://github.com/grafana/oncall/blob/dev/engine/apps/api/views/user.py#L239)
- Fix slow `GET /teams` internal API endpoint. Introduced a `short`
query parameter that only invokes
`apps.schedules.ical_utils.get_oncall_users_for_multiple_schedules` when
`short=false`.
- Order results from `GET /teams` internal API endpoint by name
(ascending)
- Fix search issue when searching for teams in the add responders popup
window (this was strictly a frontend issue)
- CSS changes to add responders dropdown to fix lonnnggg results list:
  **Before**
<img width="377" alt="Screenshot 2023-10-31 at 10 06 20"
src="https://github.com/grafana/oncall/assets/9406895/246c7c3b-7bea-44a1-afec-a38144c2c2d1">
  **After**
<img width="444" alt="Screenshot 2023-10-31 at 10 48 12"
src="https://github.com/grafana/oncall/assets/9406895/b5602a22-c691-4dc7-bd3d-e4d6b76d04a0">



## Still todo

The `apps.schedules.ical_utils.get_oncall_users_for_multiple_schedules`
method is still very slow when an instance has a lot of users (ex.
`ops`). Ideally we should refactor this method to be more efficient
because we still need to call this method under some circumstances. Ex.
to populate this dropdown when Direct Paging a user (note that it didn't
finish loading here on `ops`):
<img width="1037" alt="Screenshot 2023-10-30 at 18 14 59"
src="https://github.com/grafana/oncall/assets/9406895/9d91a57c-5db8-4ff9-862a-cd3755f52690">



## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-10-31 11:18:33 -04:00
..
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
alert.py add several new database columns + emit two new Django signals (#1522) 2023-04-14 09:15:57 +02:00
alert_group.py Add responders improvements (#3128) 2023-10-27 12:12:07 -04:00
alert_receive_channel.py Add labels implementation for integration (#3014) 2023-10-20 07:30:11 +00:00
alerts_field_cache_buster_mixin.py add several new database columns + emit two new Django signals (#1522) 2023-04-14 09:15:57 +02:00
channel_filter.py Fix channel filter endpoint (#3192) 2023-10-25 12:33:05 +00:00
custom_button.py use CustomURLValidator in custom_button (#1398) 2023-03-23 12:21:17 +00:00
custom_serializers.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
escalation_chain.py Add alert group filter by escalation chain (#1535) 2023-03-14 14:38:18 +00:00
escalation_policy.py Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
integration_heartbeat.py Remove integration html instructions (#2627) 2023-07-25 04:31:28 +00:00
labels.py Add labels implementation for integration (#3014) 2023-10-20 07:30:11 +00:00
live_setting.py Allow no-auth SMTP connection for email notifications (#759) 2022-11-03 16:18:37 +00:00
on_call_shifts.py Disable updates for API/terraform shifts in internal API (#3224) 2023-10-31 15:08:07 +00:00
organization.py Make field rbac_enabled readonly for organization endpoint (#2782) 2023-08-11 13:37:44 +00:00
organization_slack_settings.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
paging.py Add responders improvements (#3128) 2023-10-27 12:12:07 -04:00
public_api_token.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
resolution_note.py Resolution note source mobile app (#3174) 2023-10-20 15:22:45 +01:00
schedule_base.py Add responders improvements (#3128) 2023-10-27 12:12:07 -04:00
schedule_calendar.py shift swap requests model + CRUD endpoints (#2597) 2023-07-21 19:35:19 +00:00
schedule_ical.py Update ical schedule creation/update to trigger final schedule refresh (#3156) 2023-10-18 16:41:25 +00:00
schedule_polymorphic.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
schedule_reminder.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
schedule_web.py shift swap requests model + CRUD endpoints (#2597) 2023-07-21 19:35:19 +00:00
shift_swap.py Add optional param to return shift swaps detailed user information (#2923) 2023-08-31 14:46:45 +00:00
slack_channel.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
slack_user_identity.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
team.py few add responders patches (#3220) 2023-10-31 11:18:33 -04:00
telegram.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
user.py Add responders improvements (#3128) 2023-10-27 12:12:07 -04:00
user_group.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
user_notification_policy.py Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
webhook.py Add webhook presets (#2996) 2023-09-27 07:22:52 -06:00