aa0d4468db
# Which issue(s) this PR fixes So because of how we run the task that sends the "You're going oncall" push notifications, there are sometimes rounding "errors" in the displayed text of the push notification. For example, if you've configured your mobile app to remind you 12h before your on-call shift starts it sometimes might say: > You're going oncall in 11 hours This is because of the [background task being executed every 10mins](https://github.com/grafana/oncall/blob/dev/engine/settings/base.py#L545-L548) and us continually checking if now is the appropriate time to send the notification (we took this approach because we don't have any easy way of emitting an event exactly when a shift starts.. yay ical). This PR corrects that by rounding to the closest configuration value that we allow. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| going_oncall_notification.py | ||
| new_alert_group.py | ||
| new_shift_swap_request.py | ||